[ML] New Platform server shim: update results service routes to use new platform router#56886
Conversation
|
Pinging @elastic/ml-ui (:ml) |
0e2d2c8 to
ddb9d9f
Compare
peteharverson
left a comment
There was a problem hiding this comment.
A few minor text edits for the API docs. You also need to add the apiGroup and apiNames to the apidoc.json file to ensure they get added to the docs.
There was a problem hiding this comment.
Edit to Returns the maximum anomaly score of the bucket results for the request job ID(s) and time range.
There was a problem hiding this comment.
Copy / paste error - should be Returns category examples
There was a problem hiding this comment.
Edit to Returns examples for the categories with the specified IDs from the job with the supplied ID.
There was a problem hiding this comment.
Edit to Returns partition fields values
There was a problem hiding this comment.
Returns the partition fields with values that match the provided criteria for the specified job ID.
There was a problem hiding this comment.
why do you need a shallow copy here?
There was a problem hiding this comment.
and all the other places with validate schemas
There was a problem hiding this comment.
I saw this pattern initially when I was looking for examples 🤔 Though you're right, we don't really need it. Happy to change these if it makes sense. 😄
ddb9d9f to
20d3ea8
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
…ew platform router (elastic#56886) * migrate resultsService routes to NP. begin conversion of model file to TS * add schema validation to routes * add types to results service model file * add docs for routes * update route description and add routes to doc json file
…b.com:jloleysens/kibana into console/feature/text-objects-in-saved-objects * 'console/feature/text-objects-in-saved-objects' of github.com:jloleysens/kibana: (103 commits) fix auto closing new vis modal when navigating to lens or when navigating away with browser history (elastic#56998) TS of esKuery\node_types (elastic#56857) Kibana app migration: Move static code dependencies into kibana_legacy plugin, part 1 (elastic#56408) Retry ES API calls that fail with 410/Gone (elastic#56950) [APM] Show missing permissions message to the user on the Services overview (elastic#56374) Fixing flaky CI tests for custom appRoutes (elastic#55763) [State Management][Docs] State syncing utils docs (elastic#56479) [Index management] Remove index mapper setting in tests (elastic#57066) Exposed common EuiExpressions to separate components be able to reuse for building new for Alert Types (elastic#56466) [SIEM] update url state between page if date is relative (elastic#56813) fix for chart_types test (elastic#57056) chore(NA): remove compress from dll minimizer (elastic#57023) [File upload] Migrate routing to NP & add route validation (elastic#52313) Adding docs for grouped nav advanced setting (elastic#57013) Use i18n titles for field formatters, human names for numeral locales (elastic#56348) [Maps] Remove EMS catalogue url from docs (elastic#57020) [Endpoint] ERT-82 ERT-83 ERT-84: Alert list API with pagination (elastic#56538) [DOCS] Adds Apple notarization info to install doc (elastic#57042) [ML] New Platform server shim: update results service routes to use new platform router (elastic#56886) Fix typo on detection engine rule (elastic#56993) ...
Summary
Related meta issue: #49743
Validation audit: https://github.com/elastic/kibana-team/issues/167
Updates all
results_serviceroutes to use new platform router.Updates
results_servicemodel totsfile. It should still be able to be used by legacy code still usingcallWithRequestChecklist
Delete any items that are not applicable to this PR.