moving visualize/utils to new platform by ppisljar · Pull Request #56650 · elastic/kibana

ppisljar · 2020-02-03T16:56:37Z

Summary

moves utils related to fieldFormatters to data/fieldFormatters and moves getTableAggs to vislib legend (last place its used)

Dev Docs

if you are importing FormatFactory, getFormat or createFormat from ui/visualize/utilities

you should upgrade to importing the new platform version of those:

instead of getFormat use npStart.plugins.data.fieldFormats.deserialize()
for createFormat (renamed to serialize) and FormatFactory type:

import { fieldFormats } from 'src/plugins/data/public'
fieldFormats.serialize();
fieldFormats.FormatFactory

elasticmachine · 2020-02-03T16:57:04Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

lukeelmers

All LGTM, most of my notes are just around conflicts with #56353. Depending on which merges first, we'll need to update the other PR accordingly.

lukeelmers · 2020-02-03T19:27:09Z

src/legacy/ui/public/visualize/loader/pipeline_helpers/utilities.ts

You may be able to get rid of as any with !, or by doing if (mapping)

Suggested change

return npStart.plugins.data.fieldFormats.deserialize(mapping as any);

return mapping ? npStart.plugins.data.fieldFormats.deserialize(mapping) : undefined;

...or:

Suggested change

return npStart.plugins.data.fieldFormats.deserialize(mapping as any);

return npStart.plugins.data.fieldFormats.deserialize(mapping!);

lukeelmers · 2020-02-03T19:28:34Z

src/legacy/core_plugins/vis_type_vislib/public/vislib/components/legend/legend.tsx

nit: I'm adding IAggConfig in #56353, so if that merges first, it would be preferable to use it here instead.

lukeelmers · 2020-02-03T19:31:22Z

src/plugins/data/common/field_formats/utils/deserialize.ts

These will also break when #56353 merges; the BWC for imports from agg_types only supports imports from the top level ui/agg_types:

import { convertDateRangeToString, DateRangeKey, convertIPRangeToString, IpRangeKey, } from 'ui/agg_types';

lukeelmers · 2020-02-03T19:32:02Z

src/plugins/data/common/field_formats/utils/serialize.ts

Same note re: IAggConfig

ppisljar · 2020-02-04T14:06:10Z

@elasticmachine merge upstream

ppisljar · 2020-02-04T23:50:12Z

@elasticmachine merge upstream

flash1293 · 2020-02-05T15:40:06Z

src/legacy/core_plugins/vis_type_vislib/public/vislib/components/legend/legend.tsx

There should be no legacy imports within the vis types, please re-export those via legacy_imports (same with the type import a little further up). I'm currently working on a separate PR that will break on these changes.

flash1293 · 2020-02-05T15:40:27Z

src/legacy/core_plugins/vis_type_vislib/public/vislib/components/legend/legend.tsx

Should we re-export this from the top level of the data plugin?

I would consider waiting for #57177

@ppisljar as #57177 got merged can we clean up this import? Not a blocker though

lizozom · 2020-02-10T10:43:56Z

Also expect breakage on #56975 🙄

lizozom · 2020-02-10T10:44:54Z

src/legacy/core_plugins/data/public/search/aggs/buckets/lib/date_range.ts

Isn't this the same as the TimeRange type?

And convertDateRangeToString looks like a function that could be exported as a utility from data/public/index, taking in a TimeRange and returning a string

lizozom · 2020-02-10T10:46:59Z

src/plugins/data/common/field_formats/field_formats_registry.ts

public deserialize: Function ?

lizozom · 2020-02-10T10:47:39Z

src/plugins/data/common/field_formats/static.ts

I removed this file and changed the way we export utils here #56975

# Conflicts: # src/legacy/core_plugins/vis_type_vislib/public/legacy_imports.ts # src/plugins/data/public/index.ts

flash1293

Kibana app changes LGTM

flash1293 · 2020-02-12T15:49:49Z

src/legacy/core_plugins/vis_type_vislib/public/vislib/components/legend/legend.tsx

@ppisljar as #57177 got merged can we clean up this import? Not a blocker though

This reverts commit 3d3cbfa

ppisljar · 2020-02-12T19:21:53Z

@elasticmachine merge upstream

lizozom · 2020-02-13T14:19:06Z

src/plugins/data/common/field_formats/field_formats_registry.ts

The input is not being used here?

lizozom · 2020-02-13T14:19:48Z

src/plugins/data/public/index.ts

No need to export this I think

Use DataPluginPublicStart['fieldFormats'] where needed

lizozom

Overall LGTM

ppisljar · 2020-02-13T17:58:29Z

@elasticmachine merge upstream

ppisljar · 2020-02-13T21:39:32Z

@elasticmachine merge upstream

# Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

ppisljar · 2020-02-14T20:56:12Z

@elasticmachine merge upstream

kibanamachine · 2020-02-14T22:55:13Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: d86ee0e
Flaky suites:
- xpack-kibana-ciGroup4

Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/visualize/feature_controls/visualize_spaces·ts.Visualize visualize space with no features disabled can view existing Visualization

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/45244

[00:00:00]       │
[00:37:44]         └-: Visualize
[00:37:44]           └-> "before all" hook
[00:37:44]           └-: visualize
[00:37:44]             └-> "before all" hook
[00:37:44]             └-> "before all" hook
[00:37:44]               │ info [logstash_functional] Loading "mappings.json"
[00:37:44]               │ info [logstash_functional] Loading "data.json.gz"
[00:37:44]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:37:44]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:37:44]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:37:45]             └-: space with no features disabled
[00:37:45]               └-> "before all" hook
[00:37:45]               └-> "before all" hook
[00:37:45]                 │ info [visualize/default] Loading "mappings.json"
[00:37:45]                 │ info [visualize/default] Loading "data.json"
[00:37:45]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1581713809759443448] [.kibana_1/K_pTIJjvTsiob7lbiTWnJw] deleting index
[00:37:45]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1581713809759443448] [.kibana_2/tmrVGm6qRPijvLv4SrHD8Q] deleting index
[00:37:46]                 │ info [visualize/default] Deleted existing index [".kibana_2",".kibana_1"]
[00:37:46]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1581713809759443448] [.kibana] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:37:46]                 │ info [visualize/default] Created index ".kibana"
[00:37:46]                 │ debg [visualize/default] ".kibana" settings {"index":{"number_of_shards":"1","auto_expand_replicas":"0-1","number_of_replicas":"0"}}
[00:37:46]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1581713809759443448] [metricbeat-7] creating index, cause [auto(bulk api)], templates [], shards [1]/[1], mappings []
[00:37:46]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581713809759443448] [metricbeat-7/e3qs8_STSSmbkvwRyhSa_w] create_mapping
[00:37:46]                 │ info [visualize/default] Indexed 8 docs into ".kibana"
[00:37:46]                 │ info [visualize/default] Indexed 1 docs into "metricbeat-7"
[00:37:47]                 │ info Creating index .kibana_2.
[00:37:47]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1581713809759443448] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:37:47]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1581713809759443448] updating number_of_replicas to [0] for indices [.kibana_2]
[00:37:47]                 │ info Reindexing .kibana to .kibana_1
[00:37:47]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1581713809759443448] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:37:47]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1581713809759443448] updating number_of_replicas to [0] for indices [.kibana_1]
[00:37:47]                 │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-centos-tests-xl-1581713809759443448] 45460 finished with response BulkByScrollResponse[took=77ms,timed_out=false,sliceId=null,updated=0,created=8,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:37:47]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1581713809759443448] [.kibana/enEBKK2vQ26dpvliEm_YtA] deleting index
[00:37:47]                 │ info Migrating .kibana_1 saved objects to .kibana_2
[00:37:47]                 │ debg Migrating saved objects space:default, index-pattern:metricbeat-*, custom-space:index-pattern:metricbeat-*, index-pattern:logstash-*, custom_space:index-pattern:logstash-*, visualization:i-exist, custom_space:visualization:i-exist, query:okjpgs
[00:37:47]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581713809759443448] [.kibana_2/6aaqnxRVSOmWDNJfedBaPg] update_mapping [_doc]
[00:37:47]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581713809759443448] [.kibana_2/6aaqnxRVSOmWDNJfedBaPg] update_mapping [_doc]
[00:37:47]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581713809759443448] [.kibana_2/6aaqnxRVSOmWDNJfedBaPg] update_mapping [_doc]
[00:37:47]                 │ info Pointing alias .kibana to .kibana_2.
[00:37:47]                 │ info Finished in 645ms.
[00:37:47]                 │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:37:48]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581713809759443448] [.kibana_2/6aaqnxRVSOmWDNJfedBaPg] update_mapping [_doc]
[00:37:49]                 │ debg creating space
[00:37:50]                 │ debg created space
[00:37:50]               └-> shows visualize navlink
[00:37:50]                 └-> "before each" hook: global before each
[00:37:50]                 │ debg navigating to home url: http://localhost:6141/s/custom_space/app/kibana#/home
[00:37:50]                 │ debg Navigate to: http://localhost:6141/s/custom_space/app/kibana#/home
[00:37:51]                 │ debg ... sleep(700) start
[00:37:51]                 │ debg browser[INFO] http://localhost:6141/s/custom_space/app/kibana?_t=1581718224364#/home 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:37:51]                 │
[00:37:51]                 │ debg browser[INFO] http://localhost:6141/s/custom_space/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:37:52]                 │ debg ... sleep(700) end
[00:37:52]                 │ debg returned from get, calling refresh
[00:37:52]                 │ debg browser[INFO] http://localhost:6141/s/custom_space/app/kibana?_t=1581718224364#/home 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:37:52]                 │
[00:37:52]                 │ debg browser[INFO] http://localhost:6141/s/custom_space/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:37:52]                 │ debg currentUrl = http://localhost:6141/s/custom_space/app/kibana#/home
[00:37:52]                 │          appUrl = http://localhost:6141/s/custom_space/app/kibana#/home
[00:37:52]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:37:59]                 │ debg TestSubjects.find(kibanaChrome)
[00:37:59]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:37:59]                 │ debg browser[INFO] http://localhost:6141/s/custom_space/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-14T22:10:32Z
[00:37:59]                 │        Adding connection to http://localhost:6141/s/custom_space/elasticsearch
[00:37:59]                 │
[00:37:59]                 │      "
[00:37:59]                 │ debg ... sleep(501) start
[00:38:00]                 │ debg ... sleep(501) end
[00:38:00]                 │ debg in navigateTo url = http://localhost:6141/s/custom_space/app/kibana#/home
[00:38:00]                 │ debg TestSubjects.exists(statusPageContainer)
[00:38:00]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:38:02]                 │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:38:03]                 │ debg navigating to settings url: http://localhost:6141/app/kibana#/management
[00:38:03]                 │ debg Navigate to: http://localhost:6141/app/kibana#/management
[00:38:03]                 │ debg ... sleep(700) start
[00:38:03]                 │ debg browser[INFO] http://localhost:6141/app/kibana?_t=1581718237498#/management 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:38:03]                 │
[00:38:03]                 │ debg browser[INFO] http://localhost:6141/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:38:04]                 │ debg ... sleep(700) end
[00:38:04]                 │ debg returned from get, calling refresh
[00:38:04]                 │ debg browser[INFO] http://localhost:6141/app/kibana?_t=1581718237498#/management 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:38:04]                 │
[00:38:04]                 │ debg browser[INFO] http://localhost:6141/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:38:04]                 │ debg currentUrl = http://localhost:6141/app/kibana#/management
[00:38:04]                 │          appUrl = http://localhost:6141/app/kibana#/management
[00:38:04]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:38:09]                 │ debg TestSubjects.find(kibanaChrome)
[00:38:09]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:38:09]                 │ debg browser[INFO] http://localhost:6141/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-14T22:10:41Z
[00:38:09]                 │        Adding connection to http://localhost:6141/elasticsearch
[00:38:09]                 │
[00:38:09]                 │      "
[00:38:09]                 │ debg ... sleep(501) start
[00:38:10]                 │ debg ... sleep(501) end
[00:38:10]                 │ debg in navigateTo url = http://localhost:6141/app/kibana#/management?_g=()
[00:38:10]                 │ debg TestSubjects.exists(statusPageContainer)
[00:38:10]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:38:12]                 │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:38:13]                 │ debg TestSubjects.click(settings)
[00:38:13]                 │ debg Find.clickByCssSelector('[data-test-subj="settings"]') with timeout=10000
[00:38:13]                 │ debg Find.findByCssSelector('[data-test-subj="settings"]') with timeout=10000
[00:38:14]                 │ debg isGlobalLoadingIndicatorVisible
[00:38:14]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:38:14]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:38:17]                 │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:38:17]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:38:17]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:38:17]                 │ debg TestSubjects.exists(managementSettingsTitle)
[00:38:17]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="managementSettingsTitle"]') with timeout=120000
[00:38:17]                 │ debg Find.clickByCssSelector('[data-test-subj="advancedSetting-editField-pageNavigation"] option[value="individual"]') with timeout=10000
[00:38:17]                 │ debg Find.findByCssSelector('[data-test-subj="advancedSetting-editField-pageNavigation"] option[value="individual"]') with timeout=10000
[00:38:17]                 │ debg isGlobalLoadingIndicatorVisible
[00:38:17]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:38:17]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:38:19]                 │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:38:19]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:38:19]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:38:19]                 │ debg TestSubjects.click(advancedSetting-saveEditField-pageNavigation)
[00:38:19]                 │ debg Find.clickByCssSelector('[data-test-subj="advancedSetting-saveEditField-pageNavigation"]') with timeout=10000
[00:38:19]                 │ debg Find.findByCssSelector('[data-test-subj="advancedSetting-saveEditField-pageNavigation"]') with timeout=10000
[00:38:20]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581713809759443448] [.kibana_2/6aaqnxRVSOmWDNJfedBaPg] update_mapping [_doc]
[00:38:20]                 │ debg isGlobalLoadingIndicatorVisible
[00:38:20]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:38:20]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:38:20]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:38:20]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:38:21]                 │ debg TestSubjects.find(navDrawer)
[00:38:21]                 │ debg Find.findByCssSelector('[data-test-subj="navDrawer"]') with timeout=10000
[00:38:21]                 └- ✓ pass  (31.1s) "Visualize visualize space with no features disabled shows visualize navlink"
[00:38:21]               └-> can view existing Visualization
[00:38:21]                 └-> "before each" hook: global before each
[00:38:21]                 │ debg navigateToActualUrl http://localhost:6141/s/custom_space/app/kibana#/visualize/edit/i-exist
[00:38:21]                 │ debg browser[INFO] http://localhost:6141/s/custom_space/app/kibana?_t=1581718255494#/visualize/edit/i-exist 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:38:21]                 │
[00:38:21]                 │ debg browser[INFO] http://localhost:6141/s/custom_space/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:38:21]                 │ debg TestSubjects.exists(visualizationLoader)
[00:38:21]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="visualizationLoader"]') with timeout=10000
[00:38:26]                 │ debg --- retry.tryForTime error: [data-test-subj="visualizationLoader"] is not displayed
[00:38:30]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581713809759443448] [.kibana_2/6aaqnxRVSOmWDNJfedBaPg] update_mapping [_doc]
[00:38:31]                 │ debg browser[INFO] http://localhost:6141/s/custom_space/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-14T22:11:02Z
[00:38:31]                 │        Adding connection to http://localhost:6141/s/custom_space/elasticsearch
[00:38:31]                 │
[00:38:31]                 │      "
[00:38:31]                 │ debg --- retry.tryForTime failed again with the same message...
[00:38:31]                 │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/Visualize visualize space with no features disabled can view existing Visualization.png"
[00:38:31]                 │ info Current URL is: http://localhost:6141/s/custom_space/app/kibana#/visualize/edit/i-exist?_g=(refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(filters:!(),linked:!f,query:(language:lucene,query:%27%27),uiState:(),vis:(aggs:!((enabled:!t,id:%271%27,params:(),schema:metric,type:count),(enabled:!t,id:%272%27,params:(field:geo.src,missingBucket:!f,missingBucketLabel:Missing,order:desc,orderBy:%271%27,otherBucket:!f,otherBucketLabel:Other,size:5),schema:segment,type:terms)),params:(addLegend:!t,addTooltip:!t,dimensions:(metric:(accessor:0,aggType:count,format:(id:number),params:())),isDonut:!t,labels:(last_level:!t,show:!f,truncate:100,values:!t),legendPosition:right,type:pie),title:%27A%20Pie%27,type:pie))
[00:38:32]                 │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/Visualize visualize space with no features disabled can view existing Visualization.html
[00:38:32]                 └- ✖ fail: "Visualize visualize space with no features disabled can view existing Visualization"
[00:38:32]                 │

Stack Trace

Error: expected testSubject(visualizationLoader) to exist
    at TestSubjects.existOrFail (/dev/shm/workspace/kibana/test/functional/services/test_subjects.ts:60:15)

History

💔 Build #26814 failed 2c5581e
💔 Build #26606 failed bbb9f3e1081f0550f1143308fb7f2ceb163618b4
💔 Build #26523 failed 4554631
💚 Build #26291 succeeded d5cca211dc4b57127b8b615605c6c753997d7ffe
💛 Build #26253 was flaky f0648cb

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

# Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

…re/files-and-filetree * 'master' of github.com:elastic/kibana: (139 commits) Move Ace XJSON lexer-rules, worker and utils to es_ui_shared (elastic#57563) [Upgrade Assistant] Fix filter deprecations search filter (elastic#57541) [ML] New Platform server shim: update indices routes (elastic#57685) Bump redux dependencies (elastic#53348) [Index management] Client-side NP ready (elastic#57295) change id of x-pack event_log plugin to eventLog (elastic#57612) [eventLog] get kibana.index name from config instead of hard-coding it (elastic#57607) revert allow using any path to generate fixes ui titles (elastic#57535) Fix login redirect for expired sessions (elastic#57157) Expose Vis on the contract as it requires visTypes (elastic#56968) [SIEM][Detection Engine] Fixes queries to ignore errors when signals index is not present [Remote clusters] Migrate client-side code out of legacy (elastic#57365) Fix failed test reporter for SIEM Cypress use (elastic#57240) skip flaky suite (elastic#45244) update chromedriver to 80.0.1 (elastic#57602) change slack action to only report on whitelisted host name (elastic#57582) [kbn/optimizer] throw errors into stream on invalid completion (elastic#57735) moving visualize/utils to new platform (elastic#56650) ...

ppisljar requested a review from a team February 3, 2020 16:56

ppisljar requested review from a team as code owners February 3, 2020 16:56

ppisljar added Feature:NP Migration review Team:AppArch v7.7.0 v8.0.0 labels Feb 3, 2020

ppisljar added the release_note:skip Skip the PR/issue when compiling release notes label Feb 3, 2020

ppisljar mentioned this pull request Feb 3, 2020

moving expression utils into visualizations plugin #54999

Closed

7 tasks

ppisljar force-pushed the vis/cleanup2 branch from bcf388c to 0b4f53e Compare February 3, 2020 19:36

lukeelmers reviewed Feb 3, 2020

View reviewed changes

ppisljar force-pushed the vis/cleanup2 branch 3 times, most recently from 5e35f04 to 42bde92 Compare February 4, 2020 12:27

ppisljar force-pushed the vis/cleanup2 branch from 353584e to 7e3d5e4 Compare February 4, 2020 15:51

ppisljar force-pushed the vis/cleanup2 branch 3 times, most recently from 347f059 to 693c2dc Compare February 5, 2020 12:17

flash1293 requested changes Feb 5, 2020

View reviewed changes

lizozom reviewed Feb 10, 2020

View reviewed changes

src/plugins/data/common/field_formats/field_formats_registry.ts Outdated

Copy link
Copy Markdown

Contributor

lizozom Feb 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public deserialize: Function ?

lizozom reviewed Feb 10, 2020

View reviewed changes

ppisljar added 3 commits February 10, 2020 09:52

moving getFormat, createFormat to data/fieldFormats

f94e251

moving getTableAggs to the last place its used (vislib legend)

7c021de

getting reference to UISettins

47e228b

ppisljar added 6 commits February 12, 2020 07:05

fixing after merge master

ee2c696

Merge branch 'master' into vis/cleanup2

044950a

# Conflicts: # src/legacy/core_plugins/vis_type_vislib/public/legacy_imports.ts # src/plugins/data/public/index.ts

review feedback

c8496ab

fixing karma test stub

19da49a

review feedback

cb0985f

fix

98b203c

flash1293 approved these changes Feb 12, 2020

View reviewed changes

ppisljar added 2 commits February 12, 2020 11:33

review feedback

3d3cbfa

Revert "review feedback"

f0648cb

This reverts commit 3d3cbfa

lizozom reviewed Feb 13, 2020

View reviewed changes

src/plugins/data/common/field_formats/field_formats_registry.ts Outdated

Copy link
Copy Markdown

Contributor

lizozom Feb 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The input is not being used here?

lizozom reviewed Feb 13, 2020

View reviewed changes

updating based on review

5f5091d

lizozom approved these changes Feb 13, 2020

View reviewed changes

Merge branch 'master' into vis/cleanup2

4554631

ppisljar force-pushed the vis/cleanup2 branch from d5cca21 to 4554631 Compare February 13, 2020 14:44

updating based on review

e1cf453

Merge branch 'master' into vis/cleanup2

2c5581e

# Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

ppisljar force-pushed the vis/cleanup2 branch from 55336d3 to 2c5581e Compare February 14, 2020 13:06

fixing i18n

2fffeb6

Merge branch 'master' into vis/cleanup2

d86ee0e

ppisljar merged commit 78bff53 into elastic:master Feb 14, 2020

ppisljar mentioned this pull request Feb 14, 2020

[7.x] moving visualize/utils to new platform (#56650) #57741

Merged

ppisljar added a commit to ppisljar/kibana that referenced this pull request Feb 14, 2020

moving visualize/utils to new platform (elastic#56650)

6b2330c

# Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

ppisljar added a commit that referenced this pull request Feb 15, 2020

moving visualize/utils to new platform (#56650) (#57741)

4d71322

# Conflicts: # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json

	return npStart.plugins.data.fieldFormats.deserialize(mapping as any);
	return mapping ? npStart.plugins.data.fieldFormats.deserialize(mapping) : undefined;

Conversation

ppisljar commented Feb 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Dev Docs

Uh oh!

elasticmachine commented Feb 3, 2020

Uh oh!

lukeelmers left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ppisljar commented Feb 4, 2020

Uh oh!

ppisljar commented Feb 4, 2020

Uh oh!

flash1293 Feb 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lizozom commented Feb 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ppisljar commented Feb 12, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

ppisljar commented Feb 13, 2020

Uh oh!

ppisljar commented Feb 13, 2020

Uh oh!

ppisljar commented Feb 14, 2020

Uh oh!

kibanamachine commented Feb 14, 2020

💛 Build succeeded, but was flaky

Standard Out

Stack Trace

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ppisljar commented Feb 3, 2020 •

edited

Loading

flash1293 Feb 5, 2020 •

edited

Loading

lizozom commented Feb 10, 2020 •

edited

Loading