Bump redux dependencies by patrykkopycinski · Pull Request #53348 · elastic/kibana

patrykkopycinski · 2019-12-17T22:26:01Z

Summary

Bump redux dependencies and give us an access to Hooks 🎉

ConnectedProps 💪

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

sebelga

LGTM. When the CI passes I will check our ES management apps that use redux and confirm that there are no regression. Thanks! 👍

…edux-7-2

…edux-7

kibanamachine · 2019-12-22T12:26:40Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: dcdf93e

History

💔 Build #16289 failed ab800e8
💔 Build #16285 failed 253f459

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

patrykkopycinski · 2019-12-22T16:16:59Z

x-pack/legacy/plugins/infra/public/utils/typed_react.tsx

  hoc: InferableComponentEnhancerWithProps<InjectedProps, OwnProps>,
  { onInitialize, onCleanup }: ChildFunctionRendererOptions<InjectedProps> = {}
-) =>
+): ConnectedComponent<


wasn't sure how to solve it in a better way, if someone has a better idea feel free to suggest or commit :)

We are getting rid of redux for the infra plugin so I wouldn't dedicate a big effort here

elasticmachine · 2019-12-22T16:18:29Z

Pinging @elastic/kibana-canvas (Team:Canvas)

darnautov

LGTM

clintandrewhall · 2020-01-07T14:59:33Z

Would it be more prudent to target 7.x instead of 7.6, to give this time to shake out?

spalger

LGTM

…edux-7 # Conflicts: # package.json # packages/kbn-pm/dist/index.js # x-pack/legacy/plugins/infra/public/components/logging/log_text_stream/scrollable_log_text_stream_view.tsx # x-pack/legacy/plugins/infra/public/components/logging/log_time_controls.tsx # x-pack/legacy/plugins/siem/public/components/flyout/index.tsx # x-pack/legacy/plugins/siem/public/components/timeline/index.tsx # x-pack/legacy/plugins/siem/public/components/timeline/search_or_filter/index.tsx # x-pack/legacy/plugins/siem/public/containers/global_time/index.tsx # x-pack/legacy/plugins/siem/public/pages/detection_engine/components/signals/index.tsx # x-pack/package.json # yarn.lock

…edux-7 # Conflicts: # x-pack/legacy/plugins/uptime/public/components/connected/charts/ping_histogram.tsx

…edux-7 # Conflicts: # packages/kbn-pm/dist/index.js # x-pack/legacy/plugins/uptime/public/components/connected/charts/ping_histogram.tsx # x-pack/legacy/plugins/uptime/public/hooks/update_kuery_string.ts # yarn.lock

patrykkopycinski · 2020-02-05T23:51:24Z

do you think we can merge it now @clintandrewhall?

…edux-7 # Conflicts: # x-pack/legacy/plugins/siem/public/components/search_bar/index.tsx

crob611

Canvas changes look good 👍

flash1293

Graph changes LGTM. Not pretty, but fine for now. Let's hope they fix it soon.

…edux-7 # Conflicts: # package.json # packages/kbn-pm/dist/index.js # x-pack/legacy/plugins/siem/public/components/events_viewer/index.tsx # x-pack/legacy/plugins/siem/public/components/search_bar/index.tsx # x-pack/legacy/plugins/siem/public/components/timeline/index.tsx # x-pack/legacy/plugins/siem/public/components/timeline/search_or_filter/index.tsx # x-pack/legacy/plugins/siem/public/components/timeline/timeline.tsx # x-pack/legacy/plugins/siem/public/pages/detection_engine/components/signals/index.tsx # x-pack/legacy/plugins/siem/public/pages/detection_engine/detection_engine.tsx # x-pack/legacy/plugins/siem/public/pages/detection_engine/rules/details/index.tsx # x-pack/legacy/plugins/siem/public/pages/hosts/details/index.tsx # x-pack/legacy/plugins/siem/public/pages/hosts/details/types.ts # x-pack/legacy/plugins/siem/public/pages/hosts/types.ts # x-pack/legacy/plugins/siem/public/pages/network/ip_details/types.ts # x-pack/legacy/plugins/siem/public/pages/network/types.ts # x-pack/legacy/plugins/siem/public/pages/overview/overview.tsx # x-pack/legacy/plugins/uptime/public/components/functional/charts/__tests__/ping_histogram.test.tsx # yarn.lock

…edux-7

kibanamachine · 2020-02-17T08:45:32Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: fcd69f7

History

💔 Build #27090 failed 822dea3
💔 Build #27086 failed 18a5974
💚 Build #24900 succeeded 77717af
💔 Build #24795 failed 27889f9
💔 Build #24793 failed e33e6b5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

angorayc · 2020-02-17T08:47:04Z

x-pack/legacy/plugins/graph/public/components/field_manager/field_manager.test.tsx

    store.dispatch = dispatchSpy;

    instance = shallow(
+      // https://github.com/airbnb/enzyme/issues/2176#issuecomment-532361526


angorayc · 2020-02-17T08:49:00Z

x-pack/legacy/plugins/graph/public/components/field_manager/field_manager.tsx

  deselectField: (fieldName: string) => void;
  pickerOpen: boolean;
  setPickerOpen: (open: boolean) => void;
+  store?: GraphStore; // only for testing purpose


I think it would be clearer if we also put enzymejs/enzyme#2176 (comment) here as a comment

…re/files-and-filetree * 'master' of github.com:elastic/kibana: (139 commits) Move Ace XJSON lexer-rules, worker and utils to es_ui_shared (elastic#57563) [Upgrade Assistant] Fix filter deprecations search filter (elastic#57541) [ML] New Platform server shim: update indices routes (elastic#57685) Bump redux dependencies (elastic#53348) [Index management] Client-side NP ready (elastic#57295) change id of x-pack event_log plugin to eventLog (elastic#57612) [eventLog] get kibana.index name from config instead of hard-coding it (elastic#57607) revert allow using any path to generate fixes ui titles (elastic#57535) Fix login redirect for expired sessions (elastic#57157) Expose Vis on the contract as it requires visTypes (elastic#56968) [SIEM][Detection Engine] Fixes queries to ignore errors when signals index is not present [Remote clusters] Migrate client-side code out of legacy (elastic#57365) Fix failed test reporter for SIEM Cypress use (elastic#57240) skip flaky suite (elastic#45244) update chromedriver to 80.0.1 (elastic#57602) change slack action to only report on whitelisted host name (elastic#57582) [kbn/optimizer] throw errors into stream on invalid completion (elastic#57735) moving visualize/utils to new platform (elastic#56650) ...

Bump redux dependencies

253f459

patrykkopycinski self-assigned this Dec 17, 2019

patrykkopycinski requested review from sebelga and spalger and removed request for spalger December 17, 2019 22:26

patrykkopycinski added release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0 labels Dec 17, 2019

yarn.lock

ab800e8

patrykkopycinski requested review from clintandrewhall and spalger December 17, 2019 23:01

sebelga reviewed Dec 20, 2019

View reviewed changes

patrykkopycinski added 3 commits December 20, 2019 17:53

Merge branch 'master' of github.com:elastic/kibana into chore/react-r…

23d4d65

…edux-7-2

Merge branch 'master' of github.com:elastic/kibana into chore/react-r…

19b6e65

…edux-7-2

fix types

9479a73

patrykkopycinski requested review from a team as code owners December 22, 2019 09:58

patrykkopycinski added 3 commits December 22, 2019 10:58

Merge branch 'master' of github.com:elastic/kibana into chore/react-r…

18dbe7c

…edux-7

fix types

424c2ff

fix router

dcdf93e

elastic deleted a comment from elasticmachine Dec 22, 2019

bump enzyme

726248c

patrykkopycinski requested a review from a team December 22, 2019 13:24

patrykkopycinski commented Dec 22, 2019

View reviewed changes

patrykkopycinski added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// label Dec 22, 2019

patrykkopycinski removed the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// label Dec 22, 2019

darnautov approved these changes Jan 7, 2020

View reviewed changes

patrykkopycinski added chore v7.7.0 and removed v7.6.0 labels Jan 7, 2020

spalger approved these changes Jan 7, 2020

View reviewed changes

patrykkopycinski added 6 commits February 3, 2020 00:36

cleanup

503042d

yarn.lock

6ead424

Merge branch 'master' of github.com:elastic/kibana into chore/react-r…

774bf85

…edux-7 # Conflicts: # x-pack/legacy/plugins/uptime/public/components/connected/charts/ping_histogram.tsx

update dist

27889f9

Merge branch 'master' of github.com:elastic/kibana into chore/react-r…

77717af

…edux-7 # Conflicts: # x-pack/legacy/plugins/siem/public/components/search_bar/index.tsx

crob611 approved these changes Feb 7, 2020

View reviewed changes

flash1293 approved these changes Feb 12, 2020

View reviewed changes

patrykkopycinski added 4 commits February 16, 2020 22:38

Merge branch 'master' of github.com:elastic/kibana into chore/react-r…

519d4a1

…edux-7

bump

822dea3

bump

fcd69f7

angorayc reviewed Feb 17, 2020

View reviewed changes

angorayc approved these changes Feb 17, 2020

View reviewed changes

patrykkopycinski merged commit f4d29ab into elastic:master Feb 17, 2020

patrykkopycinski deleted the chore/react-redux-7 branch February 17, 2020 08:59

patrykkopycinski mentioned this pull request Feb 17, 2020

[7.x] Bump redux dependencies (#53348) #57776

Merged

patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Feb 17, 2020

Bump redux dependencies (elastic#53348)

7d94b76

patrykkopycinski added a commit that referenced this pull request Feb 17, 2020

Bump redux dependencies (#53348) (#57776)

2c7fba2

Conversation

patrykkopycinski commented Dec 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

sebelga left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Dec 22, 2019

💔 Build Failed

History

Uh oh!

patrykkopycinski Dec 22, 2019

Choose a reason for hiding this comment

Uh oh!

afgomez Dec 30, 2019

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Dec 22, 2019

Uh oh!

darnautov left a comment

Choose a reason for hiding this comment

Uh oh!

clintandrewhall commented Jan 7, 2020

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

patrykkopycinski commented Feb 5, 2020

Uh oh!

crob611 left a comment

Choose a reason for hiding this comment

Uh oh!

flash1293 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Feb 17, 2020

💚 Build Succeeded

History

Uh oh!

angorayc Feb 17, 2020

Choose a reason for hiding this comment

Uh oh!

angorayc Feb 17, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

patrykkopycinski commented Dec 17, 2019 •

edited

Loading

flash1293 left a comment •

edited

Loading