Migrate saved_object_save_as_checkbox directive to timelion#56114
Merged
kertal merged 3 commits intoelastic:masterfrom Jan 29, 2020
Merged
Migrate saved_object_save_as_checkbox directive to timelion#56114kertal merged 3 commits intoelastic:masterfrom
kertal merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
maryia-lapata
approved these changes
Jan 29, 2020
Contributor
maryia-lapata
left a comment
There was a problem hiding this comment.
LGTM
Tested in Chrome (Mac)
sulemanof
reviewed
Jan 29, 2020
| "timelion.savedObjects.howToSaveAsNewDescription": "在 Kibana 的以前版本中,更改 {savedObjectName} 的名称将创建具有新名称的副本。使用“另存为新的 {savedObjectName}” 复选框可立即达到此目的。", | ||
| "common.ui.savedObjects.overwriteRejectedDescription": "已拒绝覆盖确认", | ||
| "common.ui.savedObjects.saveAsNewLabel": "另存为新的 {savedObjectName}", | ||
| "timelion.savedObjects.saveAsNewLabel": "另存为新的 {savedObjectName}", |
Contributor
There was a problem hiding this comment.
Don't we need to move it manually to a group of timelion translations?
Because I did it in my PRs ... 😩
Member
Author
There was a problem hiding this comment.
You're right, thanks for that hint. I've improved that! you did it right 🎁
- Put keys in order
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Jan 29, 2020
…56114) - since it's only used there
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 29, 2020
* master: Migrate saved_object_save_as_checkbox directive to timelion (elastic#56114)
kertal
added a commit
that referenced
this pull request
Jan 29, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 29, 2020
…55831 * '7.x' of github.com:elastic/kibana: (78 commits) Re-enable watcher FireFox functional test (elastic#56112) (elastic#56294) [Metrics UI] Fixing title truncation in Metrics Explorer (elastic#55917) (elastic#56248) [APM] x-axis labels on Error occurrences chart are incorrect based on Kibana timezone (elastic#55686) (elastic#56288) Migrate saved_object_save_as_checkbox directive to timelion (elastic#56114) (elastic#56286) [APM] Treat error.exception.stacktrace.line as optional (elastic#55733) (elastic#55840) Remove alerts and actions from feature catalogue (elastic#56140) (elastic#56208) Migrate UI capabilities to use new platform APIs (elastic#56070) (elastic#56207) [ML] Add functional tests for analytics UI: creation addition and regression/outlier results (elastic#56059) (elastic#56191) [SIEM] Overview page feedback (elastic#56261) (elastic#56276) [NP Cleanup] Remove ui/public/inspector (elastic#55677) (elastic#56271) [Index template] Fix editor should support mappings types (elastic#55804) fixes map index message (elastic#56104) (elastic#56194) [SIEM] [TIMELINE] Only add endpoint logo when on event.module === endgame (elastic#56263) (elastic#56269) [SIEM] Fix filters on Hosts and Network page (elastic#56234) (elastic#56267) [SIEM] Adds ability to infer the newsfeed.enabled setting (elastic#56236) (elastic#56265) [SIEM][Detection Engine] critical blocker for updated rules (elastic#56259) [SIEM] Put the notice for rules in comment block (elastic#56123) (elastic#56246) [SIEM][Detection Engine] critical blocker, fixes ordering issue that causes rules to not run the first time (elastic#56256) [Reporting/NP] Migration of Reporting Security dependency (elastic#56046) (elastic#56198) [SIEM] Add link to endpoint app through reference.url (elastic#56211) (elastic#56250) ... # Conflicts: # x-pack/plugins/watcher/public/plugin.ts
Contributor
💔 Build FailedTest FailuresKibana Pipeline / kibana-intake-agent / API Integration Tests.test/api_integration/apis/saved_objects/export·js.apis saved_objects export with kibana index basic amount of saved objects should return objects in dependency orderStandard OutStack TraceKibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/context/_date_nanos_custom_timestamp·js.context app context view for date_nanos with custom timestamp displays predessors - anchor - successors in right orderStandard OutStack TraceKibana Pipeline / kibana-xpack-agent / X-Pack Saved Object API Integration Tests -- security_and_spaces.x-pack/test/saved_object_api_integration/security_and_spaces/apis/export·ts.saved objects security and spaces enabled export superuser with the default space space aware type should return 200 with only the visualization when querying by typeStandard OutStack Traceand 2 more failures, only showing the first 3. History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate
saved_object_save_as_checkboxAngular directive totimelion, since it's only used thereDev Docs
Use our React component
SavedObjectSaveModalwithshowCopyOnSave={true}instead of the react directive. Note thatSavedObjectSaveModalsoon will be part of a new plugin, so the path will change.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately