Skip to content

[Watcher] Re-enable watcher functional test#56112

Merged
jloleysens merged 2 commits intoelastic:masterfrom
jloleysens:fix/watcher/failing-firefox-test
Jan 29, 2020
Merged

[Watcher] Re-enable watcher functional test#56112
jloleysens merged 2 commits intoelastic:masterfrom
jloleysens:fix/watcher/failing-firefox-test

Conversation

@jloleysens
Copy link
Copy Markdown
Contributor

@jloleysens jloleysens commented Jan 28, 2020

Summary

Fix #56014

Additional information

While this #55985 is yet to be resolved, we just retry navigating to the watcher app in the Firefox smoke test.

@jloleysens jloleysens added Feature:Watcher v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Jan 28, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 28, 2020

Pinging @elastic/es-ui (Team:Elasticsearch UI)

cjcenizal
cjcenizal approved these changes Jan 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! How about testing this with multiple runs to detect flakiness? Here's an example of how we've done that in the past: 2f457eb

@jloleysens
Copy link
Copy Markdown
Contributor Author

jloleysens commented Jan 29, 2020 •
edited
Loading

@cjcenizal Thanks for the review! I'll keep an eye on the build-stats over the course of the next week for now - I did run this multiple times locally (I realise it's not a very good proxy for the machines used in CI). I am also confident that a page refresh will fix this most (if not all) of the time because of how the license is loaded up first time vs subsequent page loads.

@jloleysens
Copy link
Copy Markdown
Contributor Author

jloleysens commented Jan 29, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 29, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit c2aff7e into elastic:master Jan 29, 2020
@jloleysens jloleysens deleted the fix/watcher/failing-firefox-test branch January 29, 2020 13:40
@jloleysens jloleysens mentioned this pull request Jan 29, 2020
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 29, 2020
@jloleysens @elasticmachine
Re-enable watcher FireFox functional test (elastic#56112)
bb3fd73 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens added a commit that referenced this pull request Jan 29, 2020
@jloleysens @elasticmachine
Re-enable watcher FireFox functional test (#56112) (#56294)
0c67507 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 29, 2020
@jloleysens
Merge branch '7.x' of github.com:elastic/kibana into backport/7.x/pr-…
e3a4775 
…55831

* '7.x' of github.com:elastic/kibana: (78 commits)
  Re-enable watcher FireFox functional test (elastic#56112) (elastic#56294)
  [Metrics UI] Fixing title truncation in Metrics Explorer (elastic#55917) (elastic#56248)
  [APM] x-axis labels on Error occurrences chart are incorrect based on Kibana timezone (elastic#55686) (elastic#56288)
  Migrate saved_object_save_as_checkbox directive to timelion (elastic#56114) (elastic#56286)
  [APM] Treat error.exception.stacktrace.line as optional (elastic#55733) (elastic#55840)
  Remove alerts and actions from feature catalogue (elastic#56140) (elastic#56208)
  Migrate UI capabilities to use new platform APIs (elastic#56070) (elastic#56207)
  [ML] Add functional tests for analytics UI: creation addition and regression/outlier results (elastic#56059) (elastic#56191)
  [SIEM] Overview page feedback (elastic#56261) (elastic#56276)
  [NP Cleanup] Remove ui/public/inspector (elastic#55677) (elastic#56271)
  [Index template] Fix editor should support mappings types (elastic#55804)
  fixes map index message (elastic#56104) (elastic#56194)
  [SIEM] [TIMELINE] Only add endpoint logo when on event.module === endgame (elastic#56263) (elastic#56269)
  [SIEM] Fix filters on Hosts and Network page (elastic#56234) (elastic#56267)
  [SIEM] Adds ability to infer the newsfeed.enabled setting (elastic#56236) (elastic#56265)
  [SIEM][Detection Engine] critical blocker for updated rules (elastic#56259)
  [SIEM] Put the notice for rules in comment block (elastic#56123) (elastic#56246)
  [SIEM][Detection Engine] critical blocker, fixes ordering issue that causes rules to not run the first time (elastic#56256)
  [Reporting/NP] Migration of Reporting Security dependency (elastic#56046) (elastic#56198)
  [SIEM] Add link to endpoint app through reference.url (elastic#56211) (elastic#56250)
  ...

# Conflicts:
#	x-pack/plugins/watcher/public/plugin.ts
This was referenced Jan 30, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianseeders brianseeders Awaiting requested review from brianseeders

1 more reviewer

@cjcenizal cjcenizal cjcenizal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Watcher release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v7.7.0 v8.0.0

Projects

None yet

Milestone

No milestone

4 participants

@jloleysens @elasticmachine @kibanamachine @cjcenizal