Skip to content

[Maps] Remove incorrect regionmap param#55427

Merged
thomasneirynck merged 1 commit intoelastic:masterfrom
thomasneirynck:maps/regionmap_docs
Jan 21, 2020
Merged

[Maps] Remove incorrect regionmap param#55427
thomasneirynck merged 1 commit intoelastic:masterfrom
thomasneirynck:maps/regionmap_docs

Conversation

@thomasneirynck
Copy link
Copy Markdown
Contributor

map.regionmap.includeElasticMapsService should be map.includeElasticMapsService instead.

Also removes this from the docker config.

@thomasneirynck thomasneirynck requested a review from a team as a code owner January 21, 2020 16:45
@thomasneirynck thomasneirynck added bug Fixes for quality problems that affect the customer experience Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.7.0 v8.0.0 labels Jan 21, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck thomasneirynck added the release_note:skip Skip the PR/issue when compiling release notes label Jan 21, 2020
@thomasneirynck thomasneirynck requested a review from jsanz January 21, 2020 16:46
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Copy Markdown
Contributor

@jsanz jsanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation change looks good to me 👍

Copy link
Copy Markdown
Contributor

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasneirynck thomasneirynck merged commit 391c348 into elastic:master Jan 21, 2020
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Jan 21, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 22, 2020
* master: (38 commits)
  [ML] Fix counters and percentages for array fields on the Data visualizer page (elastic#55209)
  [SIEM][Detection Engine] Tags being turned into null
  rules part deux (elastic#55507)
  [DOCS] Add tip for using elasticsearch-certutil http command (elastic#55357)
  [SIEM][Detection Engine] Critical blocker, fixes schema accepting values it should not (elastic#55488)
  [SIEM] Detections create prepackage rules (elastic#55403)
  [Reporting] Convert CSV Export libs to Typescript (elastic#55117)
  [Maps] show field type icons in data driven styling field select (elastic#55166)
  Adds event log for actions and alerting (elastic#45081)
  [SIEM][Detection Engine] Fixes critical blocker where signals on signals are not operating
  [SIEM][Detection Engine] Critical blocker, adds need REST prefix for cloud
  remove incorrect config (elastic#55427)
  Retain pinned filters when loading and clearing saved queries (elastic#54307)
  Resolver zoom, pan, and center controls (elastic#55221)
  Skip failing endpoint saga tests
  [skip-ci] Update migration guide to add rendering service example (elastic#54744)
  [DOCS] Updates to heat map page (elastic#55097)
  [Endpoint] Fix saga to start only after store is created and stopped on app unmount (elastic#55245)
  [Logs UI] Use the correct icons and labels in the feature cont… (elastic#55292)
  [Uptime] Handle locations with names but no geo data (elastic#55234)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.7.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants