[SIEM] Detections create prepackage rules#55403
Merged
XavierM merged 28 commits intoelastic:masterfrom Jan 22, 2020
Merged
Conversation
…re-packages rules
…eate-prepackage-rules
…eate-prepackage-rules
…eate-prepackage-rules
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
0ea8d70 to
657521e
Compare
Contributor
MichaelMarcialis
left a comment
There was a problem hiding this comment.
Looking good, @XavierM. Leaving a few small comments below.
Also, assuming the "Activity monitor" (or something like "Failure history") tab at the top of the rules page is not being included as part of the initial release, can we add back the border prop to the HeaderPage component? If/when the tabs get introduced on the page, we can remove the prop again.
x-pack/legacy/plugins/siem/public/pages/detection_engine/rules/translations.ts
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/siem/public/pages/detection_engine/rules/index.tsx
Outdated
Show resolved
Hide resolved
...siem/public/pages/detection_engine/rules/components/pre_packaged_rules/load_empty_prompt.tsx
Outdated
Show resolved
Hide resolved
...ugins/siem/public/pages/detection_engine/rules/components/pre_packaged_rules/translations.ts
Outdated
Show resolved
Hide resolved
...ugins/siem/public/pages/detection_engine/rules/components/pre_packaged_rules/translations.ts
Outdated
Show resolved
Hide resolved
...siem/public/pages/detection_engine/rules/components/pre_packaged_rules/load_empty_prompt.tsx
Outdated
Show resolved
Hide resolved
...ugins/siem/public/pages/detection_engine/rules/components/pre_packaged_rules/translations.ts
Outdated
Show resolved
Hide resolved
...ugins/siem/public/pages/detection_engine/rules/components/pre_packaged_rules/translations.ts
Show resolved
Hide resolved
...ugins/siem/public/pages/detection_engine/rules/components/pre_packaged_rules/translations.ts
Show resolved
Hide resolved
...ns/siem/public/pages/detection_engine/rules/components/pre_packaged_rules/update_callout.tsx
Outdated
Show resolved
Hide resolved
dhurley14
reviewed
Jan 21, 2020
FrankHassanabad
approved these changes
Jan 21, 2020
Contributor
FrankHassanabad
left a comment
There was a problem hiding this comment.
Checked out, gave a quick test spin, LGTM
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Jan 22, 2020
* update extra action on rule detail to match design * remove experimental label * allow pre-package to be deleted + do not allow wrong user to create pre-packages rules * Additional look back minimum value to 1 * fix flow with edit rule * add success toaster when rule is created or updated * Fix Timeline selector loading * review ben doc + change detectin engine to detection even in url * Succeeded text size consistency in rule details page * fix description of threats * fix test * fix type * fix internatinalization * adding pre-packaged rules * fix bug + enhance ux * unified icon * fix i18n * fix bugs * review I * review II * add border back
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Jan 22, 2020
* update extra action on rule detail to match design * remove experimental label * allow pre-package to be deleted + do not allow wrong user to create pre-packages rules * Additional look back minimum value to 1 * fix flow with edit rule * add success toaster when rule is created or updated * Fix Timeline selector loading * review ben doc + change detectin engine to detection even in url * Succeeded text size consistency in rule details page * fix description of threats * fix test * fix type * fix internatinalization * adding pre-packaged rules * fix bug + enhance ux * unified icon * fix i18n * fix bugs * review I * review II * add border back
XavierM
added a commit
that referenced
this pull request
Jan 22, 2020
* update extra action on rule detail to match design * remove experimental label * allow pre-package to be deleted + do not allow wrong user to create pre-packages rules * Additional look back minimum value to 1 * fix flow with edit rule * add success toaster when rule is created or updated * Fix Timeline selector loading * review ben doc + change detectin engine to detection even in url * Succeeded text size consistency in rule details page * fix description of threats * fix test * fix type * fix internatinalization * adding pre-packaged rules * fix bug + enhance ux * unified icon * fix i18n * fix bugs * review I * review II * add border back
XavierM
added a commit
that referenced
this pull request
Jan 22, 2020
* update extra action on rule detail to match design * remove experimental label * allow pre-package to be deleted + do not allow wrong user to create pre-packages rules * Additional look back minimum value to 1 * fix flow with edit rule * add success toaster when rule is created or updated * Fix Timeline selector loading * review ben doc + change detectin engine to detection even in url * Succeeded text size consistency in rule details page * fix description of threats * fix test * fix type * fix internatinalization * adding pre-packaged rules * fix bug + enhance ux * unified icon * fix i18n * fix bugs * review I * review II * add border back
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 22, 2020
* master: (38 commits) [ML] Fix counters and percentages for array fields on the Data visualizer page (elastic#55209) [SIEM][Detection Engine] Tags being turned into null rules part deux (elastic#55507) [DOCS] Add tip for using elasticsearch-certutil http command (elastic#55357) [SIEM][Detection Engine] Critical blocker, fixes schema accepting values it should not (elastic#55488) [SIEM] Detections create prepackage rules (elastic#55403) [Reporting] Convert CSV Export libs to Typescript (elastic#55117) [Maps] show field type icons in data driven styling field select (elastic#55166) Adds event log for actions and alerting (elastic#45081) [SIEM][Detection Engine] Fixes critical blocker where signals on signals are not operating [SIEM][Detection Engine] Critical blocker, adds need REST prefix for cloud remove incorrect config (elastic#55427) Retain pinned filters when loading and clearing saved queries (elastic#54307) Resolver zoom, pan, and center controls (elastic#55221) Skip failing endpoint saga tests [skip-ci] Update migration guide to add rendering service example (elastic#54744) [DOCS] Updates to heat map page (elastic#55097) [Endpoint] Fix saga to start only after store is created and stopped on app unmount (elastic#55245) [Logs UI] Use the correct icons and labels in the feature cont… (elastic#55292) [Uptime] Handle locations with names but no geo data (elastic#55234) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow user to load/re-load/update pre-packaged rules from Elastic.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers