[BUG] Data fetching twice on discover timefilter change #55279
Merged
lizozom merged 6 commits intoelastic:masterfrom Jan 21, 2020
Merged
[BUG] Data fetching twice on discover timefilter change #55279lizozom merged 6 commits intoelastic:masterfrom
lizozom merged 6 commits intoelastic:masterfrom
Conversation
- Filters are not only fetch once on timefilter change - Make sure that discover doesn't fetch data when a disabled filter is changed - Support compareFilters on an array of filters. - Added tests to compare filters - Exctracted sortFilters and added tests to it.
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Contributor
Author
|
@elasticmachine merge upstream |
Dosant
reviewed
Jan 20, 2020
src/plugins/data/public/query/filter_manager/lib/compare_filters.ts
Outdated
Show resolved
Hide resolved
Dosant
reviewed
Jan 20, 2020
src/legacy/core_plugins/data/public/filter/filter_manager/filter_state_manager.ts
Show resolved
Hide resolved
src/plugins/data/public/query/filter_manager/lib/compare_filters.ts
Outdated
Show resolved
Hide resolved
src/plugins/data/public/query/filter_manager/lib/sort_filters.ts
Outdated
Show resolved
Hide resolved
Dosant
approved these changes
Jan 20, 2020
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
flash1293
approved these changes
Jan 21, 2020
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Tested around and couldn't find a case where fetch is triggered multiple times - LGTM and thank you so much!
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Jan 21, 2020
* Fix bug elastic#54887 - Filters are not only fetch once on timefilter change - Make sure that discover doesn't fetch data when a disabled filter is changed - Support compareFilters on an array of filters. - Added tests to compare filters - Exctracted sortFilters and added tests to it. * code review + FilterCompareOptions * Remove sort by Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Jan 21, 2020
* Fix bug elastic#54887 - Filters are not only fetch once on timefilter change - Make sure that discover doesn't fetch data when a disabled filter is changed - Support compareFilters on an array of filters. - Added tests to compare filters - Exctracted sortFilters and added tests to it. * code review + FilterCompareOptions * Remove sort by Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lizozom
pushed a commit
that referenced
this pull request
Jan 21, 2020
) * Fix bug #54887 - Filters are not only fetch once on timefilter change - Make sure that discover doesn't fetch data when a disabled filter is changed - Support compareFilters on an array of filters. - Added tests to compare filters - Exctracted sortFilters and added tests to it. * code review + FilterCompareOptions * Remove sort by Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lizozom
pushed a commit
that referenced
this pull request
Jan 21, 2020
) * Fix bug #54887 - Filters are not only fetch once on timefilter change - Make sure that discover doesn't fetch data when a disabled filter is changed - Support compareFilters on an array of filters. - Added tests to compare filters - Exctracted sortFilters and added tests to it. * code review + FilterCompareOptions * Remove sort by Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 21, 2020
* master: [State Management] remove AppState from Dashboard app (elastic#54105) Expose fatalErrors API from the Start contract (elastic#55300) [BUG] Data fetching twice on discover timefilter change (elastic#55279) [Mappings editor] Add missing max_shingle_size parameter to search_as_you_type (elastic#55161) [Logs UI] Fix z-index of logs page toolbar (elastic#54469) removes CTA from Task Manager info message (elastic#55334)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix bug #54887
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers