Skip to content

[Logs UI] Fix z-index of logs page toolbar#54469

Merged
afgomez merged 6 commits intoelastic:masterfrom
afgomez:54449-log-datepicker-z-index
Jan 20, 2020
Merged

[Logs UI] Fix z-index of logs page toolbar#54469
afgomez merged 6 commits intoelastic:masterfrom
afgomez:54449-log-datepicker-z-index

Conversation

@afgomez
Copy link
Copy Markdown
Contributor

@afgomez afgomez commented Jan 10, 2020

Closes #54449

The header of the log stream overlaps with the datepicker. This PR adjust the z-index of the logs toolbar to prevent it from happening.

@afgomez afgomez added v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Jan 10, 2020
@afgomez afgomez requested a review from a team as a code owner January 10, 2020 16:07
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 10, 2020

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@afgomez afgomez changed the title Fix z-index of logs page toolbar [Logs UI] Fix z-index of logs page toolbar Jan 10, 2020
@afgomez
Copy link
Copy Markdown
Contributor Author

afgomez commented Jan 13, 2020

@elasticmachine merge upstream

weltenwort
weltenwort reviewed Jan 13, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 Reviewing on behalf of @elastic/logs-metrics-ui...

weltenwort
weltenwort reviewed Jan 13, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We encoutered a problem like that before in the log analysis setup screen. react-datepicker has unfortunate z-index values, which we overrode in

kibana/x-pack/legacy/plugins/infra/public/components/logging/log_analysis_setup/initial_configuration_step/analysis_setup_timerange_form.tsx

Lines 137 to 150 in ea4a1ac

const FixedDatePicker = euiStyled(
({
className,
inputClassName,
...datePickerProps
}: {
className?: string;
inputClassName?: string;
} & EuiDatePickerProps) => (
<EuiDatePicker {...datePickerProps} className={inputClassName} popperClassName={className} />
)
)`
z-index: 3 !important;
`;
. Maybe we want to factor out the FixedDatePicker and re-use it here?

@afgomez
Copy link
Copy Markdown
Contributor Author

afgomez commented Jan 17, 2020

. Maybe we want to factor out the FixedDatePicker and re-use it here?

I'll give it a shot, but if we takes me more than 1 hour I think it's better to merge this as it is. I'm getting rid of the datepicker in #54280 anyway

@afgomez
Copy link
Copy Markdown
Contributor Author

afgomez commented Jan 17, 2020

@elasticmachine merge upstream

weltenwort
weltenwort approved these changes Jan 17, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is green 👍

x-pack/legacy/plugins/infra/public/pages/logs/stream/page_toolbar.tsx Outdated
import { LogPositionState } from '../../../containers/logs/log_position';
import { Source } from '../../../containers/source';
import { WithKueryAutocompletion } from '../../../containers/with_kuery_autocompletion';
import euiStyled from '../../../../../../common/eui_styled_components';
Copy link
Copy Markdown
Member

@weltenwort weltenwort Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used anymore.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 20, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afgomez afgomez merged commit cdb0021 into elastic:master Jan 20, 2020
@afgomez afgomez deleted the 54449-log-datepicker-z-index branch January 20, 2020 17:28
@afgomez afgomez mentioned this pull request Jan 20, 2020
Merged
afgomez pushed a commit to afgomez/kibana that referenced this pull request Jan 20, 2020
@elasticmachine
[Logs UI] Fix z-index of logs page toolbar (elastic#54469)
63e2419 
* Fix z-index of logs page toolbar

* Extract `FixedDatePicker` from log setup page, and use it in the stream page

* Clean unused import

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
afgomez pushed a commit to afgomez/kibana that referenced this pull request Jan 20, 2020
@elasticmachine
[Logs UI] Fix z-index of logs page toolbar (elastic#54469)
f2d5910 
* Fix z-index of logs page toolbar

* Extract `FixedDatePicker` from log setup page, and use it in the stream page

* Clean unused import

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@afgomez afgomez mentioned this pull request Jan 20, 2020
Merged
afgomez pushed a commit that referenced this pull request Jan 21, 2020
@elasticmachine
[Logs UI] Fix z-index of logs page toolbar (#54469) (#55348)
c88501f 
* Fix z-index of logs page toolbar

* Extract `FixedDatePicker` from log setup page, and use it in the stream page

* Clean unused import

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
afgomez pushed a commit that referenced this pull request Jan 21, 2020
@elasticmachine
[Logs UI] Fix z-index of logs page toolbar (#54469) (#55346)
8d8d3a0 
* Fix z-index of logs page toolbar

* Extract `FixedDatePicker` from log setup page, and use it in the stream page

* Clean unused import

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 21, 2020
@gmmorris
Merge branch 'master' into actions/platform
78e0253 
* master:
  [State Management] remove AppState from Dashboard app (elastic#54105)
  Expose fatalErrors API from the Start contract (elastic#55300)
  [BUG] Data fetching twice on discover timefilter change  (elastic#55279)
  [Mappings editor] Add missing max_shingle_size parameter to search_as_you_type (elastic#55161)
  [Logs UI] Fix z-index of logs page toolbar (elastic#54469)
  removes CTA from Task Manager info message (elastic#55334)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weltenwort weltenwort weltenwort approved these changes

Assignees

No one assigned

Labels

Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.6.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Logs UI] Date picker sits underneath the log stream table header

4 participants

@afgomez @elasticmachine @kibanamachine @weltenwort