[SIEM][Detection Engine] Adds actions to Rule Details by spong · Pull Request #54828 · elastic/kibana

spong · 2020-01-14T21:45:06Z

Summary

This PR adds the following actions to the Rule Details page via the RuleActionsOverflow component (which is permission-aware):

Duplicate
Export
Delete

Additional fixes include:

Fixes duplication action (recent regression as part of status update additions)
i18n of Duplicate postfix when duplicating rules
Adds success toast when duplication is a success
Enabled Edit Index Patterns batch action
Removes unused Run Rule Manually action

Rule Details Actions:

Edit Index Patterns Batch Action:

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

~~This was checked for breaking API changes and was labeled appropriately~~
~~This includes a feature addition or change that requires a release note and was labeled appropriately~~

…ions

elasticmachine · 2020-01-14T21:45:09Z

Pinging @elastic/siem (Team:SIEM)

FrankHassanabad · 2020-01-14T22:25:02Z

x-pack/legacy/plugins/siem/public/containers/detection_engine/rules/api.ts

      body: JSON.stringify({
        ...rule,
-        name: `${rule.name} [Duplicate]`,
+        name: `${rule.name} [${i18n.DUPLICATE}]`,


nice catch! 👍

FrankHassanabad · 2020-01-14T22:26:47Z

x-pack/legacy/plugins/siem/public/pages/detection_engine/rules/all/actions.tsx

      );
+    } else {
+      // FP: See https://github.com/typescript-eslint/typescript-eslint/issues/1138#issuecomment-566929566
+      onRuleDeleted?.(); // eslint-disable-line no-unused-expressions


Thanks for the link when putting the disable in 👍 , really helpful and interesting to read.

Yeah, they're stilling working out some quirks with linting these new language features it seems. FWIW it was happy with the below, but I wanted the code feng shui.... 😬

if (onRuleDeleted) { onRuleDeleted(); }

FrankHassanabad · 2020-01-14T22:29:21Z

...ins/siem/public/pages/detection_engine/rules/components/rule_actions_overflow/index.test.tsx

+    );
+    expect(wrapper).toMatchSnapshot();
+  });
+});


FrankHassanabad

Looked at the code, test ran it, and everything looks as advertised.

Appreciate the one off fix for an accidental earlier bug.

…ions

kibanamachine · 2020-01-15T00:01:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 9ec5a7d

History

💔 Build #20352 failed 23c1cc7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

This PR adds the following actions to the `Rule Details` page via the `RuleActionsOverflow` component (which is permission-aware): * Duplicate * Export * Delete Additional fixes include: * Fixes duplication action (recent regression as part of status update additions) * i18n of `Duplicate` postfix when duplicating rules * Adds success toast when duplication is a success * Enabled `Edit Index Patterns` batch action * Removes unused `Run Rule Manually` action Rule Details Actions: ![image](https://user-images.githubusercontent.com/2946766/72385375-9c3a6880-36dc-11ea-8249-4ae92eb72dd1.png) Edit Index Patterns Batch Action: ![image](https://user-images.githubusercontent.com/2946766/72385468-c5f38f80-36dc-11ea-93c8-b70e4982f01a.png) Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [X] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~ - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~ - [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~ - [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

This PR adds the following actions to the `Rule Details` page via the `RuleActionsOverflow` component (which is permission-aware): * Duplicate * Export * Delete Additional fixes include: * Fixes duplication action (recent regression as part of status update additions) * i18n of `Duplicate` postfix when duplicating rules * Adds success toast when duplication is a success * Enabled `Edit Index Patterns` batch action * Removes unused `Run Rule Manually` action Rule Details Actions: ![image](https://user-images.githubusercontent.com/2946766/72385375-9c3a6880-36dc-11ea-8249-4ae92eb72dd1.png) Edit Index Patterns Batch Action: ![image](https://user-images.githubusercontent.com/2946766/72385468-c5f38f80-36dc-11ea-93c8-b70e4982f01a.png) Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [X] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~ - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~ - [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~ - [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~ Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* upstream/master: (72 commits) [ML] Calculate model memory limit API integration tests (elastic#54557) Skip flakey index template component integration tests. (elastic#54878) Add label and icon to nested fields in the doc table (elastic#54199) Reverse dependency of home plugin and apm/ml/cloud (elastic#52883) [SIEM][Detection Engine] Order JSON keys, fix scripts, update pre-packaged rules update invalid snapshot add readme note about alerting / manage_api_key cluster privilege (elastic#54639) [SIEM] New Overview Page (elastic#54783) [Uptime] Feature/refactor context initialization (elastic#54494) Upgrade EUI to v18.2.0 (elastic#54786) [SIEM] [Detection engine] from signals to timeline (elastic#54769) [Index Management] Add Mappings Editor to Index Template Wizard (elastic#47562) [SIEM][Detection Engine] Removes deprecated filter from mapping [Maps] Add categorical styling (elastic#54408) Add mapbox-gl-rtl-text library (elastic#54842) [SIEM][Detection Engine] Adds actions to Rule Details (elastic#54828) Lexicographically sort location tags (elastic#54832) [Maps] expand extent filter to tile boundaries (elastic#54276) [Maps] Use v7.6 Elastic Maps Service API (elastic#54399) [DOCS] Adds monitoring setting (elastic#54819) ...

## Summary This PR adds the following actions to the `Rule Details` page via the `RuleActionsOverflow` component (which is permission-aware): * Duplicate * Export * Delete Additional fixes include: * Fixes duplication action (recent regression as part of status update additions) * i18n of `Duplicate` postfix when duplicating rules * Adds success toast when duplication is a success * Enabled `Edit Index Patterns` batch action * Removes unused `Run Rule Manually` action Rule Details Actions: ![image](https://user-images.githubusercontent.com/2946766/72385375-9c3a6880-36dc-11ea-8249-4ae92eb72dd1.png) Edit Index Patterns Batch Action: ![image](https://user-images.githubusercontent.com/2946766/72385468-c5f38f80-36dc-11ea-93c8-b70e4982f01a.png) ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [X] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~ - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~ ### For maintainers - [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~ - [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

spong added 2 commits January 14, 2020 14:20

Adds actions to Rule Details

115f9ae

Merge branch 'master' of github.com:elastic/kibana into edit-rule-act…

290742c

…ions

spong added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Jan 14, 2020

spong requested review from FrankHassanabad and XavierM January 14, 2020 21:45

spong self-assigned this Jan 14, 2020

Fixes tooltip flicker

23c1cc7

FrankHassanabad reviewed Jan 14, 2020

View reviewed changes

FrankHassanabad approved these changes Jan 14, 2020

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into edit-rule-act…

760c8d5

…ions

FrankHassanabad changed the title ~~[SIEM] Adds actions to Rule Details~~ [SIEM][Detection Engine] Adds actions to Rule Details Jan 14, 2020

Allows ability to duplicate pre-packaged immutable rule

9ec5a7d

spong merged commit b4e42d5 into elastic:master Jan 15, 2020

spong deleted the edit-rule-actions branch January 15, 2020 00:05

spong mentioned this pull request Jan 15, 2020

[7.x] [SIEM][Detection Engine] Adds actions to Rule Details (#54828) #54868

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SIEM][Detection Engine] Adds actions to Rule Details#54828

[SIEM][Detection Engine] Adds actions to Rule Details#54828
spong merged 5 commits intoelastic:masterfrom
spong:edit-rule-actions

spong commented Jan 14, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Jan 14, 2020

Uh oh!

FrankHassanabad Jan 14, 2020

Uh oh!

FrankHassanabad Jan 14, 2020

Uh oh!

spong Jan 14, 2020

Uh oh!

FrankHassanabad Jan 14, 2020

Uh oh!

FrankHassanabad left a comment

Uh oh!

kibanamachine commented Jan 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

spong commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Jan 14, 2020

Uh oh!

FrankHassanabad Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

FrankHassanabad Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

spong Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

FrankHassanabad Jan 14, 2020

Choose a reason for hiding this comment

Uh oh!

FrankHassanabad left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jan 15, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

spong commented Jan 14, 2020 •

edited

Loading