[Uptime] Feature/refactor context initialization#54494
Merged
justinkambic merged 10 commits intoelastic:masterfrom Jan 15, 2020
Merged
[Uptime] Feature/refactor context initialization#54494justinkambic merged 10 commits intoelastic:masterfrom
justinkambic merged 10 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
Contributor
justinkambic
left a comment
There was a problem hiding this comment.
I think this looks really good, thanks for stepping up and handling this one. I had a few comments we should address but I think this will be a good thing to add.
| export { UMSettingsContextValues, UptimeSettingsContext } from './uptime_settings_context'; | ||
| export { UptimeRefreshContext, UptimeRefreshContextProvider } from './uptime_refresh_context'; | ||
| export { | ||
| UMSettingsContextValues, |
Contributor
There was a problem hiding this comment.
We can probably rename this UptimeSettingsContextValues.. I was prefixing lots of things with UM back in the early days but we refer to it internally and publicly as simply "Uptime" now. WDYT?
…hahzad31/kibana into feature/refactor-context-initilization
andrewvc
approved these changes
Jan 14, 2020
Contributor
andrewvc
left a comment
There was a problem hiding this comment.
LGTM on the additional commits @justinkambic added
justinkambic
approved these changes
Jan 14, 2020
Contributor
justinkambic
left a comment
There was a problem hiding this comment.
LGTM on code review and smoke testing locally. We'll merge this after it passes CI.
| import { i18n } from '@kbn/i18n'; | ||
| import { DonutChartLegend } from './donut_chart_legend'; | ||
| import { UptimeSettingsContext } from '../../../contexts'; | ||
| import { UptimeThemeContext } from '../../../contexts/uptime_theme_context'; |
Contributor
There was a problem hiding this comment.
We're exporting this from the index.ts of the contexts directory, so we can remove the filename from the import.
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Jan 15, 2020
* update refactor * refactor context initilization * rename values * fix tests Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
7 tasks
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Jan 15, 2020
* update refactor * refactor context initilization * rename values * fix tests Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
shahzad31
added a commit
that referenced
this pull request
Jan 15, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 15, 2020
* upstream/master: (72 commits) [ML] Calculate model memory limit API integration tests (elastic#54557) Skip flakey index template component integration tests. (elastic#54878) Add label and icon to nested fields in the doc table (elastic#54199) Reverse dependency of home plugin and apm/ml/cloud (elastic#52883) [SIEM][Detection Engine] Order JSON keys, fix scripts, update pre-packaged rules update invalid snapshot add readme note about alerting / manage_api_key cluster privilege (elastic#54639) [SIEM] New Overview Page (elastic#54783) [Uptime] Feature/refactor context initialization (elastic#54494) Upgrade EUI to v18.2.0 (elastic#54786) [SIEM] [Detection engine] from signals to timeline (elastic#54769) [Index Management] Add Mappings Editor to Index Template Wizard (elastic#47562) [SIEM][Detection Engine] Removes deprecated filter from mapping [Maps] Add categorical styling (elastic#54408) Add mapbox-gl-rtl-text library (elastic#54842) [SIEM][Detection Engine] Adds actions to Rule Details (elastic#54828) Lexicographically sort location tags (elastic#54832) [Maps] expand extent filter to tile boundaries (elastic#54276) [Maps] Use v7.6 Elastic Maps Service API (elastic#54399) [DOCS] Adds monitoring setting (elastic#54819) ...
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 17, 2020
* update refactor * refactor context initilization * rename values * fix tests Co-authored-by: Justin Kambic <justin.kambic@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix: #54493
Context in uptime are properly initialized and have removed unused objects from context.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers