[Dashboard] Redesign empty screen in readonly mode#54073
Merged
majagrubic merged 3 commits intoelastic:masterfrom Jan 7, 2020
Merged
[Dashboard] Redesign empty screen in readonly mode#54073majagrubic merged 3 commits intoelastic:masterfrom
majagrubic merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
myasonik
approved these changes
Jan 6, 2020
Contributor
myasonik
left a comment
There was a problem hiding this comment.
I think we can improve the copy but not a hard requirement
|
|
||
| /** READONLY VIEW CONSTANTS **/ | ||
| export const emptyDashboardTitle: string = i18n.translate('kbn.dashboard.emptyDashboardTitle', { | ||
| defaultMessage: 'This dashboard is empty or you do not have permission to view.', |
Contributor
There was a problem hiding this comment.
Don't we know concretely that it's both, not one of these? Would suggest breaking this up to be able to provide direct messaging (You probably only need "This dashboard is empty" and "You do not have permission to view this dashboard"; "This dashboard is empty and you don't have permission to see it" seems a bit overkill.)
I think direct, unambiguous error/help messages are always appreciated even if it requires a few more conditionals on our side.
Contributor
Author
|
Thanks @myasonik , I agree it was ambiguous. I've updated the copy following @ryankeairns suggestion: |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
ryankeairns
approved these changes
Jan 7, 2020
Contributor
ryankeairns
left a comment
There was a problem hiding this comment.
👍 Thanks for updating the wording, short and sweet.
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Jan 7, 2020
* [Dashboard] Make empty screen nicer in readonly mode * Adding contact-the-owner part * Updating text
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 7, 2020
…le-saved-objects * 'master' of github.com:elastic/kibana: (86 commits) [Uptime] Added date range filter into expanded list query (elastic#52609) [SIEM] Add react/display-name eslint rule (elastic#53107) [SIEM] Enable eslint prefer-template rule (elastic#53983) Elasticsearch snapshots automation (elastic#53706) [SIEM] Enable eslint react/no-children-prop (elastic#53985) [DOCS][Reporting] Adds info about using a custom reporting index (elastic#54052) Changing background color to align with EUI color (elastic#54060) Fix linting issues (elastic#54068) NP Migration: Move doc views registry and existing doc views into discover plugin (elastic#53465) [ML] DF Analytics job creation: Add 'excludes' input field to form (elastic#53856) EMT-issue-65: add endpoint list api (elastic#53861) [SIEM] Fix doubled drag handles in Timeline (elastic#52679) Functional tests: refactor visualize_page (elastic#53845) [Dashboard] Redesign empty screen in readonly mode (elastic#54073) [ML] Support search for partitions on Single Metric Viewer (elastic#53879) update apm index pattern (elastic#54095) Add data ui for envoyproxy Metricbeat Module (elastic#53476) [ML] persist the brush when expanded to full width (elastic#54020) Skip failing test (elastic#54100) [APM] Show errors on the timeline instead of under the transaction (elastic#53756) ... # Conflicts: # src/legacy/core_plugins/console/public/np_ready/application/contexts/services_context.tsx # src/legacy/core_plugins/console/public/np_ready/application/index.tsx
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 7, 2020
…/kibana into feature/console-saved-objects * 'feature/console-saved-objects' of github.com:jloleysens/kibana: (86 commits) [Uptime] Added date range filter into expanded list query (elastic#52609) [SIEM] Add react/display-name eslint rule (elastic#53107) [SIEM] Enable eslint prefer-template rule (elastic#53983) Elasticsearch snapshots automation (elastic#53706) [SIEM] Enable eslint react/no-children-prop (elastic#53985) [DOCS][Reporting] Adds info about using a custom reporting index (elastic#54052) Changing background color to align with EUI color (elastic#54060) Fix linting issues (elastic#54068) NP Migration: Move doc views registry and existing doc views into discover plugin (elastic#53465) [ML] DF Analytics job creation: Add 'excludes' input field to form (elastic#53856) EMT-issue-65: add endpoint list api (elastic#53861) [SIEM] Fix doubled drag handles in Timeline (elastic#52679) Functional tests: refactor visualize_page (elastic#53845) [Dashboard] Redesign empty screen in readonly mode (elastic#54073) [ML] Support search for partitions on Single Metric Viewer (elastic#53879) update apm index pattern (elastic#54095) Add data ui for envoyproxy Metricbeat Module (elastic#53476) [ML] persist the brush when expanded to full width (elastic#54020) Skip failing test (elastic#54100) [APM] Show errors on the timeline instead of under the transaction (elastic#53756) ...
majagrubic
pushed a commit
that referenced
this pull request
Jan 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When in readonly mode, we were not showing a meaningful empty screen, which was a bit confusing. Related: #54002
This PR utilizes the new empty screen graphic to show it on readonly screen.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers