Functional tests: refactor visualize_page by dmlemeshko · Pull Request #53845 · elastic/kibana

dmlemeshko · 2019-12-30T15:54:54Z

Summary

This PR aim is to improve the developer's experience in writing functional tests. As described in #53117, visualize_page is one of those "heavy" PO: with 1.5k lines and ~200 functions, it is hard to search and determine suitable function.

The idea is to split visualize_page into smaller POs that represents different areas, remove duplicate functions, combine similar actions and convert it to TS:

visualize_page: interactions on the landing page (open, save, create new viz)
visualize_editor_page: interactions related to editor panel
visualize_chart_page: common interactions with chart viz and legend
tile_map_page: tilemap viz specific interactions
tag_cloud_page: tag cloud specific interactions
vega_chart_page: vega viz specific interactions

…age-objects

kibanamachine · 2019-12-30T17:12:20Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 971c72c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2019-12-30T22:03:00Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 9cd2915

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…age-objects

dmlemeshko · 2020-01-02T16:42:30Z

@elasticmachine merge upstream

dmlemeshko · 2020-01-02T19:56:31Z

@elasticmachine merge upstream

dmlemeshko · 2020-01-03T09:29:35Z

test/functional/services/listing_table.ts

 import { FtrProviderContext } from '../ftr_provider_context';

-export function VisualizeListingTableProvider({ getService, getPageObjects }: FtrProviderContext) {
+export function ListingTableProvider({ getService, getPageObjects }: FtrProviderContext) {


Can be reused for Dashboard and Settings landing pages

…kibana into ftr/reorganize--page-objects

dmlemeshko · 2020-01-06T10:53:28Z

@elasticmachine merge upstream

LeeDr · 2020-01-06T15:16:18Z

test/functional/page_objects/visualize_chart_page.ts

+      await testSubjects.existOrFail('visLibVisualizeError');
+    }
+
+    public async getChartTypes() {


I think getChartTypes should be in visualize_page?

You are right, fixing it

LeeDr · 2020-01-06T15:22:23Z

test/functional/page_objects/visualize_page.ts

+  const listingTable = getService('listingTable');
+  const { common, header, visEditor } = getPageObjects(['common', 'header', 'visEditor']);
+
+  class VisualizePage {


Maybe we can have a comment block here describing that this page object file contains the visualization type selection, the landing page, and the open/save dialog functions (is that correct?)

I was going to suggest we rename it to visualization_types_page or something like that, but now I see it has more than that.

LeeDr

LGTM - a few small comments you can address if you like. Wow, this looks like it was a lot of work but really makes it better! Some of the visualization_chart_page will be obsolete as we move over to elastic-charts library. But it's still a great improvement.

…kibana into ftr/reorganize--page-objects

kibanamachine · 2020-01-07T12:20:53Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 9f95928

History

💚 Build #18030 succeeded 3b6bafe
💚 Build #17850 succeeded 8f54e2c
💚 Build #17636 succeeded 2295dd0
💚 Build #17599 succeeded 620d7dd
💚 Build #17577 succeeded 4872d33

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* add new POs and services * split visualize_page * refactor PO and tests * lost changes * more fixes * fix tslint error * refactor POs * add vega_chart_page, refactor * review fix Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* add new POs and services * split visualize_page * refactor PO and tests * lost changes * more fixes * fix tslint error * refactor POs * add vega_chart_page, refactor * review fix Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…le-saved-objects * 'master' of github.com:elastic/kibana: (86 commits) [Uptime] Added date range filter into expanded list query (elastic#52609) [SIEM] Add react/display-name eslint rule (elastic#53107) [SIEM] Enable eslint prefer-template rule (elastic#53983) Elasticsearch snapshots automation (elastic#53706) [SIEM] Enable eslint react/no-children-prop (elastic#53985) [DOCS][Reporting] Adds info about using a custom reporting index (elastic#54052) Changing background color to align with EUI color (elastic#54060) Fix linting issues (elastic#54068) NP Migration: Move doc views registry and existing doc views into discover plugin (elastic#53465) [ML] DF Analytics job creation: Add 'excludes' input field to form (elastic#53856) EMT-issue-65: add endpoint list api (elastic#53861) [SIEM] Fix doubled drag handles in Timeline (elastic#52679) Functional tests: refactor visualize_page (elastic#53845) [Dashboard] Redesign empty screen in readonly mode (elastic#54073) [ML] Support search for partitions on Single Metric Viewer (elastic#53879) update apm index pattern (elastic#54095) Add data ui for envoyproxy Metricbeat Module (elastic#53476) [ML] persist the brush when expanded to full width (elastic#54020) Skip failing test (elastic#54100) [APM] Show errors on the timeline instead of under the transaction (elastic#53756) ... # Conflicts: # src/legacy/core_plugins/console/public/np_ready/application/contexts/services_context.tsx # src/legacy/core_plugins/console/public/np_ready/application/index.tsx

…/kibana into feature/console-saved-objects * 'feature/console-saved-objects' of github.com:jloleysens/kibana: (86 commits) [Uptime] Added date range filter into expanded list query (elastic#52609) [SIEM] Add react/display-name eslint rule (elastic#53107) [SIEM] Enable eslint prefer-template rule (elastic#53983) Elasticsearch snapshots automation (elastic#53706) [SIEM] Enable eslint react/no-children-prop (elastic#53985) [DOCS][Reporting] Adds info about using a custom reporting index (elastic#54052) Changing background color to align with EUI color (elastic#54060) Fix linting issues (elastic#54068) NP Migration: Move doc views registry and existing doc views into discover plugin (elastic#53465) [ML] DF Analytics job creation: Add 'excludes' input field to form (elastic#53856) EMT-issue-65: add endpoint list api (elastic#53861) [SIEM] Fix doubled drag handles in Timeline (elastic#52679) Functional tests: refactor visualize_page (elastic#53845) [Dashboard] Redesign empty screen in readonly mode (elastic#54073) [ML] Support search for partitions on Single Metric Viewer (elastic#53879) update apm index pattern (elastic#54095) Add data ui for envoyproxy Metricbeat Module (elastic#53476) [ML] persist the brush when expanded to full width (elastic#54020) Skip failing test (elastic#54100) [APM] Show errors on the timeline instead of under the transaction (elastic#53756) ...

dmlemeshko added 5 commits December 16, 2019 16:18

add new POs and services

191187a

Merge remote-tracking branch 'upstream/master' into ftr/reorganize--p…

18b9f91

…age-objects

split visualize_page

f0a62a2

refactor PO and tests

935ac34

Merge remote-tracking branch 'upstream/master' into ftr/reorganize--p…

971c72c

…age-objects

dmlemeshko added 2 commits December 30, 2019 20:45

lost changes

9c29b1c

more fixes

9cd2915

dmlemeshko added 2 commits January 2, 2020 11:03

fix tslint error

885b058

Merge remote-tracking branch 'upstream/master' into ftr/reorganize--p…

4872d33

…age-objects

Merge branch 'master' into ftr/reorganize--page-objects

620d7dd

Merge branch 'master' into ftr/reorganize--page-objects

2295dd0

dmlemeshko added test_ui_functional v8.0.0 labels Jan 3, 2020

dmlemeshko commented Jan 3, 2020

View reviewed changes

dmlemeshko added 3 commits January 3, 2020 19:30

refactor POs

4ab65d7

add vega_chart_page, refactor

bd0e10b

Merge branch 'ftr/reorganize--page-objects' of github.com:dmlemeshko/…

8f54e2c

…kibana into ftr/reorganize--page-objects

dmlemeshko marked this pull request as ready for review January 3, 2020 20:44

dmlemeshko added the release_note:skip Skip the PR/issue when compiling release notes label Jan 3, 2020

dmlemeshko requested review from a team, spalger and sulemanof January 3, 2020 20:46

Merge branch 'master' into ftr/reorganize--page-objects

3b6bafe

LeeDr reviewed Jan 6, 2020

View reviewed changes

LeeDr approved these changes Jan 6, 2020

View reviewed changes

dmlemeshko added 2 commits January 7, 2020 11:55

review fix

82b6fdb

Merge branch 'ftr/reorganize--page-objects' of github.com:dmlemeshko/…

9f95928

…kibana into ftr/reorganize--page-objects

dmlemeshko merged commit a1176b0 into elastic:master Jan 7, 2020

dmlemeshko mentioned this pull request Jan 7, 2020

[7.x] Functional tests: refactor visualize_page (#53845) #54126

Merged

dmlemeshko mentioned this pull request Jan 13, 2020

Functional tests: refactor dashboard_page #54588

Merged

dmlemeshko deleted the ftr/reorganize--page-objects branch January 31, 2022 12:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Functional tests: refactor visualize_page#53845

Functional tests: refactor visualize_page#53845
dmlemeshko merged 17 commits intoelastic:masterfrom
dmlemeshko:ftr/reorganize--page-objects

dmlemeshko commented Dec 30, 2019 •

edited

Loading

Uh oh!

kibanamachine commented Dec 30, 2019

Uh oh!

kibanamachine commented Dec 30, 2019

Uh oh!

dmlemeshko commented Jan 2, 2020

Uh oh!

dmlemeshko commented Jan 2, 2020

Uh oh!

dmlemeshko Jan 3, 2020

Uh oh!

dmlemeshko commented Jan 6, 2020

Uh oh!

LeeDr Jan 6, 2020 •

edited

Loading

Uh oh!

dmlemeshko Jan 6, 2020

Uh oh!

LeeDr Jan 6, 2020 •

edited

Loading

Uh oh!

LeeDr left a comment

Uh oh!

kibanamachine commented Jan 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dmlemeshko commented Dec 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

kibanamachine commented Dec 30, 2019

💔 Build Failed

Uh oh!

kibanamachine commented Dec 30, 2019

💔 Build Failed

Uh oh!

dmlemeshko commented Jan 2, 2020

Uh oh!

dmlemeshko commented Jan 2, 2020

Uh oh!

dmlemeshko Jan 3, 2020

Choose a reason for hiding this comment

Uh oh!

dmlemeshko commented Jan 6, 2020

Uh oh!

LeeDr Jan 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dmlemeshko Jan 6, 2020

Choose a reason for hiding this comment

Uh oh!

LeeDr Jan 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LeeDr left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jan 7, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dmlemeshko commented Dec 30, 2019 •

edited

Loading

LeeDr Jan 6, 2020 •

edited

Loading

LeeDr Jan 6, 2020 •

edited

Loading