Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data by alexwizp · Pull Request #53794 · elastic/kibana

alexwizp · 2019-12-24T14:48:58Z

Closes: #43444

Make sure that all index pattern related imports use NP (and delete index_pattern folder from shim)

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

Closes: elastic#43444 Make sure that all index pattern related imports use NP (and delete index_pattern folder from shim)

elasticmachine · 2019-12-26T10:37:37Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

kibanamachine · 2019-12-26T11:43:13Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 3cddb03

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alexwizp · 2019-12-26T11:45:19Z

@elasticmachine merge upstream

alexwizp · 2019-12-27T08:38:27Z

@elasticmachine merge upstream

kibanamachine · 2019-12-27T09:55:18Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ddf66fc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alexwizp · 2019-12-30T10:17:08Z

@elasticmachine merge upstream

alexwizp · 2020-01-01T16:17:37Z

@elasticmachine merge upstream

lizozom

LGTM!

peteharverson

ML changes LGTM

# Conflicts: # src/legacy/ui/public/vis/editors/default/components/agg_params.tsx

markov00

Changes LGTM. I've added a comment on a ML part that I think it should be changed

markov00 · 2020-01-03T09:32:35Z

...lytics/pages/analytics_management/components/create_analytics_form/create_analytics_form.tsx

 // remove the space character from the list of illegal characters
-INDEX_PATTERN_ILLEGAL_CHARACTERS.pop();
-const characterList = INDEX_PATTERN_ILLEGAL_CHARACTERS.join(', ');
+indexPatterns.ILLEGAL_CHARACTERS.pop();


Are we sure we want to allow this mutation? I know that it was there before but I'm not sure if we want to allow it. Also the above commit that use the old ui/index_patterns folder should change

Or maybe instead of using ILLEGAL_CHARACTERS just use ILLEGAL_CHARACTERS_VISIBLE that doesn't contain the space

cc @peteharverson

Yes to avoid the mutation, could do

const illegalCharacters = [...INDEX_PATTERN_ILLEGAL_CHARACTERS]; illegalCharacters.pop(); const characterList = illegalCharacters.join(', ');

and the

based on code used by ui/index_patterns internally

comment, could be edited to just based on code used by indexPatterns internally to remove the reference to the old ui_index_patterns folder.

@markov00 I agree with you, we cannot leave it as it is. Looks like you are absolutely right and here we should use ILLEGAL_CHARACTERS_VISIBLE

@liza-mae @peteharverson I've updated this PR please have a look it

markov00

Changes LGTM

peteharverson

Latest edits to remove the mutation of the illegal characters list LGTM.

Outside of the scope of this PR I guess, but am wondering if the name ILLEGAL_CHARACTERS_VISIBLE defined in src/plugins/data/public/index_patterns/lib/types.ts is that intuitive?

alexwizp · 2020-01-03T10:38:50Z

@elasticmachine merge upstream

alexwizp · 2020-01-03T11:28:37Z

@elasticmachine merge upstream

kibanamachine · 2020-01-03T12:42:23Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b433e59

History

💔 Build #17728 failed 9f53fa1
💚 Build #17705 succeeded 4c5b0a8
💚 Build #17510 succeeded 8ec6c911d846a0fafd506687b2e009d7b3a0c369
💚 Build #17387 succeeded 53d0108e93524a51361ae7fb23b80cf72d56254d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…lastic#53794) * Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data Closes: elastic#43444 Make sure that all index pattern related imports use NP (and delete index_pattern folder from shim) * fix JEST tests * fix CI * fix PR comments Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data (elastic#53794) moved Task Manager server code under "server" directory (elastic#53777)

…t-types * alerting/created_at-and-updated_at: updatedAt should equal createdAt on creation Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data (elastic#53794) moved Task Manager server code under "server" directory (elastic#53777) Rename `/api/security/oidc` to `/api/security/oidc/callback`. (elastic#53886) Updating transitive dependencies to use handlebars@4.5.3 (elastic#53899) [Reporting/Tests] consolidate functional test configs (elastic#52671) [Reporting] Correct the docvalue_fields params in the search query Download CSV from Dashboard Panel (elastic#52833) [Test/Newsfeed] Re-enable test and add news item to be filtered (elastic#53905) cleanup server-log action (elastic#53326) [Uptime] Delete uptime eslint rule skip (elastic#50912) [skip-ci] Expression Lifecycle Docs (elastic#51494) [Endpoint] add react router to endpoint app (elastic#53808) [SIEM][Detection Engine] Silence 409 errors on signal creation (elastic#53859) [Maps] get max_result_window and max_inner_result_window from index settings (elastic#53500) [ML] New Platform server shim: update analytics routes to use new platform router (elastic#53521) fixes typo on engine detection page (elastic#53877) [Maps] push mapbox value extraction from VectorStyle and into DynamicStyleProperty (elastic#53806) Fix suggested value for time_zone in range query (elastic#53841) Clean up generic hooks, use react-use instead (elastic#53822)

* master: Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data (elastic#53794) moved Task Manager server code under "server" directory (elastic#53777)

* master: [SR] Enable component integration tests (elastic#53893) Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data (elastic#53794) moved Task Manager server code under "server" directory (elastic#53777)

…53794) (#53936) * Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data Closes: #43444 Make sure that all index pattern related imports use NP (and delete index_pattern folder from shim) * fix JEST tests * fix CI * fix PR comments Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…nsole-dependencies * 'master' of github.com:elastic/kibana: (33 commits) adds strict types to Alerting Client (elastic#53821) [Dashboard] Empty screen redesign (elastic#53681) Migrate config deprecations and `ShieldUser` functionality to the New Platform (elastic#53768) increase delay to make sure license refetched (elastic#53882) Allow custom NP plugin paths in production (elastic#53562) [Maps] show custom color ramps in legend (elastic#53780) [Lens] Expression type on document can be null (elastic#53883) [SIEM] [Detection engine] Add user permission to detection engine (elastic#53778) Update dependency @elastic/charts to v16.0.2 (elastic#52619) Set consistent EOL symbol in core API docs (elastic#53815) [Logs UI] Refactor query bar state to hooks (elastic#52656) [Maps] pass getFieldFormatter to DynamicTextProperty (elastic#53937) Invalidate alert API Key when generating a new one (elastic#53732) [Logs UI] HTTP API for log entries (elastic#53798) [kbn/pm] add caching to bootstrap (elastic#53622) adds createdAt and updatedAt fields to alerting (elastic#53793) [SR] Enable component integration tests (elastic#53893) Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data (elastic#53794) moved Task Manager server code under "server" directory (elastic#53777) Rename `/api/security/oidc` to `/api/security/oidc/callback`. (elastic#53886) ... # Conflicts: # yarn.lock

alexwizp added 3 commits December 24, 2019 17:47

Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data

aea2047

Closes: elastic#43444 Make sure that all index pattern related imports use NP (and delete index_pattern folder from shim)

fix JEST tests

981c98d

Merge remote-tracking branch 'upstream/master' into 43444

5347193

elastic deleted a comment from kibanamachine Dec 26, 2019

alexwizp assigned gospodarsky Dec 26, 2019

fix CI

3cddb03

streamich mentioned this pull request Dec 26, 2019

Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data #43444

Closed

6 tasks

elastic deleted a comment from kibanamachine Dec 26, 2019

alexwizp requested review from lizozom, lukeelmers, ppisljar and streamich December 26, 2019 10:36

alexwizp assigned alexwizp and unassigned gospodarsky Dec 26, 2019

alexwizp added v7.6.0 v8.0.0 review Team:AppArch labels Dec 26, 2019

alexwizp added release_note:skip Skip the PR/issue when compiling release notes Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:NP Migration labels Dec 26, 2019

alexwizp marked this pull request as ready for review December 26, 2019 11:44

alexwizp requested a review from a team December 26, 2019 11:44

alexwizp requested review from a team as code owners December 26, 2019 11:44

Merge branch 'master' into 43444

34791b9

Merge branch 'master' into 43444

ddf66fc

lizozom approved these changes Jan 2, 2020

View reviewed changes

peteharverson approved these changes Jan 2, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into 43444

4c5b0a8

# Conflicts: # src/legacy/ui/public/vis/editors/default/components/agg_params.tsx

alexwizp force-pushed the 43444 branch from 8ec6c91 to 4c5b0a8 Compare January 3, 2020 08:23

markov00 reviewed Jan 3, 2020

View reviewed changes

peteharverson self-requested a review January 3, 2020 10:10

fix PR comments

9f53fa1

alexwizp force-pushed the 43444 branch from cc29d87 to 9f53fa1 Compare January 3, 2020 10:18

markov00 self-requested a review January 3, 2020 10:26

markov00 approved these changes Jan 3, 2020

View reviewed changes

peteharverson approved these changes Jan 3, 2020

View reviewed changes

Merge branch 'master' into 43444

b7c007f

Merge branch 'master' into 43444

b433e59

alexwizp merged commit 6942d0b into elastic:master Jan 3, 2020

alexwizp mentioned this pull request Jan 3, 2020

[7.x] Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data (#53794) #53936

Merged

Conversation

alexwizp commented Dec 24, 2019

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Dec 26, 2019

Uh oh!

kibanamachine commented Dec 26, 2019

💚 Build Succeeded

Uh oh!

alexwizp commented Dec 26, 2019

Uh oh!

alexwizp commented Dec 27, 2019

Uh oh!

kibanamachine commented Dec 27, 2019

💚 Build Succeeded

Uh oh!

alexwizp commented Dec 30, 2019

Uh oh!

alexwizp commented Jan 1, 2020

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

markov00 left a comment

Choose a reason for hiding this comment

Uh oh!

markov00 Jan 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markov00 Jan 3, 2020

Choose a reason for hiding this comment

Uh oh!

markov00 Jan 3, 2020

Choose a reason for hiding this comment

Uh oh!

peteharverson Jan 3, 2020

Choose a reason for hiding this comment

Uh oh!

alexwizp Jan 3, 2020

Choose a reason for hiding this comment

Uh oh!

markov00 left a comment

Choose a reason for hiding this comment

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

alexwizp commented Jan 3, 2020

Uh oh!

alexwizp commented Jan 3, 2020

Uh oh!

kibanamachine commented Jan 3, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

markov00 Jan 3, 2020 •

edited

Loading