[Maps] show custom color ramps in legend by thomasneirynck · Pull Request #53780 · elastic/kibana

thomasneirynck · 2019-12-23T22:23:31Z

Closes #50778.

This fix is also a prerequisite for supporting categorical styling.

elasticmachine · 2019-12-23T22:23:33Z

Pinging @elastic/kibana-gis (Team:Geo)

kibanamachine · 2019-12-23T23:39:54Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 44bb317

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

thomasneirynck · 2019-12-26T14:35:14Z

@elasticmachine merge upstream

kibanamachine · 2019-12-26T16:14:31Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: facba05

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2019-12-26T17:57:33Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 704be5c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nreese

This PR is introducing a detailed view for custom color ramp legends. This is inconsistent with existing ordinal legends that only support a condensed view. For a consistent user experience, the custom color ramps should also just display a condensed view consisting of the color ramps header with min/max values like the existing ordinal legends.

Then, separately, we can solve the problem of an expanded view for both ordinal legends and categorical legends. As a user, I would ask, "why can't my ordinal legend also display each breakout along with ranges"?

.../legacy/plugins/maps/public/layers/styles/vector/properties/components/dynamic_legend_row.js

x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_style_property.js

kibanamachine · 2019-12-26T18:32:20Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 69cad7b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2019-12-30T18:26:42Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b43fb8f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/components/ordinal_legend.js

x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_color_property.js

x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_style_property.js

nreese

lgtm with green CI

kibanamachine · 2020-01-06T00:38:20Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 2f461cb

History

💔 Build #17668 failed 90313e1
💚 Build #17469 succeeded 775af3a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: increase delay to make sure license refetched (elastic#53882) Allow custom NP plugin paths in production (elastic#53562) [Maps] show custom color ramps in legend (elastic#53780) [Lens] Expression type on document can be null (elastic#53883) [SIEM] [Detection engine] Add user permission to detection engine (elastic#53778) Update dependency @elastic/charts to v16.0.2 (elastic#52619) Set consistent EOL symbol in core API docs (elastic#53815) [Logs UI] Refactor query bar state to hooks (elastic#52656) [Maps] pass getFieldFormatter to DynamicTextProperty (elastic#53937) Invalidate alert API Key when generating a new one (elastic#53732) [Logs UI] HTTP API for log entries (elastic#53798)

* master: increase delay to make sure license refetched (elastic#53882) Allow custom NP plugin paths in production (elastic#53562) [Maps] show custom color ramps in legend (elastic#53780) [Lens] Expression type on document can be null (elastic#53883) [SIEM] [Detection engine] Add user permission to detection engine (elastic#53778) Update dependency @elastic/charts to v16.0.2 (elastic#52619) Set consistent EOL symbol in core API docs (elastic#53815) [Logs UI] Refactor query bar state to hooks (elastic#52656) [Maps] pass getFieldFormatter to DynamicTextProperty (elastic#53937) Invalidate alert API Key when generating a new one (elastic#53732) [Logs UI] HTTP API for log entries (elastic#53798) [kbn/pm] add caching to bootstrap (elastic#53622) adds createdAt and updatedAt fields to alerting (elastic#53793)

* master: increase delay to make sure license refetched (elastic#53882) Allow custom NP plugin paths in production (elastic#53562) [Maps] show custom color ramps in legend (elastic#53780) [Lens] Expression type on document can be null (elastic#53883) [SIEM] [Detection engine] Add user permission to detection engine (elastic#53778) Update dependency @elastic/charts to v16.0.2 (elastic#52619) Set consistent EOL symbol in core API docs (elastic#53815) [Logs UI] Refactor query bar state to hooks (elastic#52656) [Maps] pass getFieldFormatter to DynamicTextProperty (elastic#53937) Invalidate alert API Key when generating a new one (elastic#53732) [Logs UI] HTTP API for log entries (elastic#53798) [kbn/pm] add caching to bootstrap (elastic#53622) adds createdAt and updatedAt fields to alerting (elastic#53793) [SR] Enable component integration tests (elastic#53893)

…nsole-dependencies * 'master' of github.com:elastic/kibana: (33 commits) adds strict types to Alerting Client (elastic#53821) [Dashboard] Empty screen redesign (elastic#53681) Migrate config deprecations and `ShieldUser` functionality to the New Platform (elastic#53768) increase delay to make sure license refetched (elastic#53882) Allow custom NP plugin paths in production (elastic#53562) [Maps] show custom color ramps in legend (elastic#53780) [Lens] Expression type on document can be null (elastic#53883) [SIEM] [Detection engine] Add user permission to detection engine (elastic#53778) Update dependency @elastic/charts to v16.0.2 (elastic#52619) Set consistent EOL symbol in core API docs (elastic#53815) [Logs UI] Refactor query bar state to hooks (elastic#52656) [Maps] pass getFieldFormatter to DynamicTextProperty (elastic#53937) Invalidate alert API Key when generating a new one (elastic#53732) [Logs UI] HTTP API for log entries (elastic#53798) [kbn/pm] add caching to bootstrap (elastic#53622) adds createdAt and updatedAt fields to alerting (elastic#53793) [SR] Enable component integration tests (elastic#53893) Move index patterns: src/legacy/core_plugins/data 👉 src/plugins/data (elastic#53794) moved Task Manager server code under "server" directory (elastic#53777) Rename `/api/security/oidc` to `/api/security/oidc/callback`. (elastic#53886) ... # Conflicts: # yarn.lock

thomasneirynck added 6 commits December 23, 2019 14:27

rename for clarity

87760d0

switch on ordinal

462d48f

boilerplate for breaked legend

3c6c6aa

add ranged check

5f1b756

fix

decdb5a

add color breaks

44bb317

thomasneirynck added release_note:fix Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.6.0 labels Dec 23, 2019

thomasneirynck requested a review from a team as a code owner December 23, 2019 22:23

elasticmachine and others added 2 commits December 26, 2019 06:35

Merge branch 'master' into maps/color_stops_legend

6f2e262

dont render custom label text legend (needs discussion)

facba05

thomasneirynck added 3 commits December 26, 2019 11:37

add label color

c00ad5f

move label to center, similar to ramps

704be5c

make spacing smaller

69cad7b

nreese reviewed Dec 26, 2019

View reviewed changes

thomasneirynck added 2 commits December 30, 2019 11:43

Merge branch 'master' into maps/color_stops_legend

61e5891

feedback (1)

b43fb8f

thomasneirynck added 2 commits December 30, 2019 14:45

feedback (2)

71c7839

add jest test

775af3a

nreese reviewed Jan 2, 2020

View reviewed changes

Merge branch 'master' into maps/color_stops_legend

6ed20ce

thomasneirynck added 3 commits January 2, 2020 16:52

reuse symbol-icon

2d79d46

handle empty strings in component

0c1712f

fix test

90313e1

thomasneirynck requested a review from nreese January 2, 2020 22:21

nreese approved these changes Jan 5, 2020

View reviewed changes

thomasneirynck added 2 commits January 5, 2020 18:05

Merge branch 'master' into maps/color_stops_legend

b60a94d

update snapshot

2f461cb

thomasneirynck merged commit c19151d into elastic:master Jan 6, 2020

thomasneirynck mentioned this pull request Jan 6, 2020

[7.x] [Maps] show custom color ramps in legend (#53780) #53996

Merged

thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Jan 6, 2020

[Maps] show custom color ramps in legend (elastic#53780)

d2532b8

thomasneirynck added a commit that referenced this pull request Jan 6, 2020

[Maps] show custom color ramps in legend (#53780) (#53996)

647d7cd

nreese mentioned this pull request Jan 17, 2020

Custom Color Ramp Legend #55212

Closed

Conversation

thomasneirynck commented Dec 23, 2019

Uh oh!

elasticmachine commented Dec 23, 2019

Uh oh!

kibanamachine commented Dec 23, 2019

💚 Build Succeeded

Uh oh!

thomasneirynck commented Dec 26, 2019

Uh oh!

kibanamachine commented Dec 26, 2019

💚 Build Succeeded

Uh oh!

kibanamachine commented Dec 26, 2019

💚 Build Succeeded

Uh oh!

nreese left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Dec 26, 2019

💚 Build Succeeded

Uh oh!

kibanamachine commented Dec 30, 2019

💚 Build Succeeded

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jan 6, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nreese left a comment •

edited

Loading