Np kibana plugin home feature catalogue by TinaHeiligers · Pull Request #50838 · elastic/kibana

TinaHeiligers · 2019-11-15T23:54:10Z

Summary

Moves the feature_catalogue plugin (introduced in PR48818 ) into the home plugin.

Dev Docs

The ui/registries/feature_catalogue module has been deprecated for removal in 8.0

Plugins wishing to migrate may remove their usage of ui/registries/feature_catalogue and rely on either:

// For legacy plugins
import { npSetup } from 'ui/new_platform';
npSetup.plugins.home.featureCatalogue.register(/* same details here */);

// For new plugins: first add 'home` to the list of `optionalPlugins` 
// in your kibana.json file. Then access the plugin directly in `setup`:

class MyPlugin {
  setup(core, plugins) {
    if (plugins.home) {
      plugins.home.featureCatalogue.register(/* same details here. */);
    }
  }
}

Note that the old module supported providing a Angular DI function to receive Angular dependencies. This is no longer supported as we migrate away from Angular.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, including a check against IE11~~
~~- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~

Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
~~- [ ] This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

…ver_tutorials_api

…orm tutorial plugin registrations

…orials

…gin_home

… tutorials service

…gin_home

…rvice

…gin_home

… the home plugin public folder

…re_catalogue

elasticmachine · 2019-11-18T18:36:25Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: cbb950c

…gin_home_feature_catalogue

TinaHeiligers · 2019-11-18T22:58:03Z

Looks like this PR is built on top of #50444, right? When the other one is merged, this one will become easier to review.
@flash1293 PR #50444 has been merged. There are fewer files with changes now and this PR should be easier to review. For consistency, I renames the server plugin from HomePlugin to HomeServerPlugin. LMK if that shouldn't be done in this PR.

elasticmachine · 2019-11-18T23:55:36Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 68159e5

TinaHeiligers · 2019-11-19T00:06:22Z

@elasticmachine merge upstream

elasticmachine · 2019-11-19T01:21:47Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: f4548b2c0808367b4282138d058625dac178d832

flash1293

Code changes LGTM, didn't pull down to test

legrego

Spaces changes LGTM

…gin_home_feature_catalogue

TinaHeiligers · 2019-11-19T17:21:11Z

@joshdover I need a LGTM from the platform team before I can merge this PR. All this PR does is move the feature_catalogue plugin code to the home plugin as a service in the public folder.

elasticmachine · 2019-11-19T18:39:01Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 2fad345

joshdover

Looks great! Just two small suggestions.

I think it might be clearer if the services directory had top-level directories for each service so the source files don't get mixed up. For example:

services/
  feature_catalogue/
    index.ts
    feature_catalogue_registry.ts
  other_service/
    index.ts
    other_services.ts
  index.ts

May want to change the server-side as well.

src/core/MIGRATION.md

Co-Authored-By: Josh Dover <me@joshdover.com>

TinaHeiligers · 2019-11-19T19:23:06Z

Looks great! Just two small suggestions.

I think it might be clearer if the services directory had top-level directories for each service so the source files don't get mixed up. For example:
services/
  feature_catalogue/
    index.ts
    feature_catalogue_registry.ts
  other_service/
    index.ts
    other_services.ts
  index.ts
May want to change the server-side as well.

I was thinking the same thing! I'll do that in this PR because the next task is to migrate the sample data and that's going to be a much larger effort.

…folder for the home plugin

elasticmachine · 2019-11-19T20:44:34Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 83a43bf

elasticmachine · 2019-11-19T22:04:28Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 9a73942

* Moves feature_catalogue services into the home plugin public folder.

TinaHeiligers added 26 commits November 11, 2019 17:11

[NP:Kibana:homeAPI] initializes a new plugin (WIP)

6faa981

Merge branch 'master' of github.com:elastic/kibana into NP_kibana_ser…

a24e7f2

…ver_tutorials_api

Typing

eeeaae6

New plugin tutorials not needing server working

7a78b55

Retains legacy tutorial registration and adds new route for new platf…

dfa5e34

…orm tutorial plugin registrations

Adds comment on where to pre-register general non-plugin specific tut…

31548ef

…orials

Merge branch 'master' of github.com:elastic/kibana into NP_kibana_plu…

560e7d2

…gin_home

Converts TutorialsPlugin to TutorialsRegistry service in new Home plugin

c22d787

Changes call to location of registerTutorial in registerTutorials

1741e3c

Adds console log for the home plugin that's returning an empty object

aca40b9

Removes async from setup and start methods in the home plugin and the…

10d477a

… tutorials service

Starts writing tests and creating mocks

de06bc0

Adds basic tests for TutorialRegistry service

7a7ce9a

Adds basic tests for TutorialRegistry service

fcedb41

Merge branch 'master' of github.com:elastic/kibana into NP_kibana_plu…

a77aced

…gin_home

Merge branch 'master' of github.com:elastic/kibana into NP_kibana_plu…

1862438

…gin_home

Adds test for route

628e410

Adds mocks and tests for the home plugin

cc978bd

Adds home plugin to security plugin and registers scoped tutorials se…

6607a40

…rvice

Merge branch 'master' of github.com:elastic/kibana into NP_kibana_plu…

a4fba59

…gin_home

Removes incorrect addition to src core server

8e6177f

Fixes type errors

14d3068

Deletes unused code

16a0a38

[Kibana NP migration] begins moving the feature_catalogue plugin into…

4f9399f

… the home plugin public folder

Fixes feature_catalogue imports

02176a4

Deletes duplicate golangMetricsSpecProvider registration

93d67d6

TinaHeiligers added Feature:NP Migration Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.7.0 v8.0.0 labels Nov 15, 2019

Merge branch 'NP_kibana_plugin_home' into NP_kibana_plugin_home_featu…

cbb950c

…re_catalogue

TinaHeiligers added 2 commits November 18, 2019 15:12

Merge branch 'master' of github.com:elastic/kibana into NP_kibana_plu…

9a0f060

…gin_home_feature_catalogue

Changes HomePlugin to HomePluginServer

68159e5

TinaHeiligers requested a review from nickofthyme November 18, 2019 22:58

flash1293 approved these changes Nov 19, 2019

View reviewed changes

legrego approved these changes Nov 19, 2019

View reviewed changes

TinaHeiligers mentioned this pull request Nov 19, 2019

[NP Kibana Migrations ] kibana plugin home #50444

Merged

5 tasks

Merge branch 'master' of github.com:elastic/kibana into NP_kibana_plu…

a485ba2

…gin_home_feature_catalogue

TinaHeiligers force-pushed the NP_kibana_plugin_home_feature_catalogue branch from f4548b2 to a485ba2 Compare November 19, 2019 17:15

Merge branch 'master' of github.com:elastic/kibana into NP_kibana_plu…

2fad345

…gin_home_feature_catalogue

joshdover approved these changes Nov 19, 2019

View reviewed changes

src/core/MIGRATION.md Outdated Show resolved Hide resolved

Update src/core/MIGRATION.md

83a43bf

Co-Authored-By: Josh Dover <me@joshdover.com>

TinaHeiligers added 2 commits November 19, 2019 13:09

Moves feature_catalogue services into a subfolder

e0faa71

Moves tutorials-related service files into a subfolder in the server …

9a73942

…folder for the home plugin

TinaHeiligers merged commit e46f977 into elastic:master Nov 19, 2019

TinaHeiligers added a commit to TinaHeiligers/kibana that referenced this pull request Nov 19, 2019

Np kibana plugin home feature catalogue (elastic#50838)

a22717a

* Moves feature_catalogue services into the home plugin public folder.

TinaHeiligers mentioned this pull request Nov 19, 2019

[7.x] Np kibana plugin home feature catalogue (#50838) #51129

Merged

TinaHeiligers added a commit that referenced this pull request Nov 20, 2019

Np kibana plugin home feature catalogue (#50838) (#51129)

1954521

* Moves feature_catalogue services into the home plugin public folder.

TinaHeiligers deleted the NP_kibana_plugin_home_feature_catalogue branch November 20, 2019 00:30

Conversation

TinaHeiligers commented Nov 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Dev Docs

Checklist

For maintainers

Uh oh!

elasticmachine commented Nov 18, 2019

💚 Build Succeeded

Uh oh!

TinaHeiligers commented Nov 18, 2019

Uh oh!

elasticmachine commented Nov 18, 2019

💔 Build Failed

Uh oh!

TinaHeiligers commented Nov 19, 2019

Uh oh!

elasticmachine commented Nov 19, 2019

💚 Build Succeeded

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

legrego left a comment

Choose a reason for hiding this comment

Uh oh!

TinaHeiligers commented Nov 19, 2019

Uh oh!

elasticmachine commented Nov 19, 2019

💚 Build Succeeded

Uh oh!

joshdover left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TinaHeiligers commented Nov 19, 2019

Uh oh!

elasticmachine commented Nov 19, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Nov 19, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TinaHeiligers commented Nov 15, 2019 •

edited

Loading