Migrate ui/registry/feature_catalogue to New Platform plugin#48818
Migrate ui/registry/feature_catalogue to New Platform plugin#48818joshdover merged 6 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/kibana-platform (Team:Platform) |
src/plugins/feature_catalogue/public/services/feature_catalogue_registry.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
|
There was a problem hiding this comment.
I see this is desired behaviour https://github.com/elastic/kibana/pull/48818/files#diff-a757f884a32fbf9bab5a0c977e69bb9eR54
just curious why? to allow OSS ?
There was a problem hiding this comment.
It's for plugins that haven't registered features, eg. 3rd party plugins, functional test plugins, etc.
src/plugins/feature_catalogue/public/services/feature_catalogue_registry.test.ts
Outdated
Show resolved
Hide resolved
src/plugins/feature_catalogue/public/services/feature_catalogue_registry.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
optional: not sure those are really useful tests if TS enforces the contract
There was a problem hiding this comment.
I can go either way here, but I prefer some coverage here over nothing.
There was a problem hiding this comment.
then probably we should rename either?
There was a problem hiding this comment.
I think this will be more clear once this registry moves into a "home" plugin with the actual UI. I opted not to name this plugin "home" right now since it may not be split out until 8.x and I thought that would be confusing in the meantime.
b56a005 to
f612fb9
Compare
💔 Build Failed |
|
@elasticmachine merge upstream |
💚 Build Succeeded
|
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
7b58502 to
e6a27c2
Compare
| (Private(FeatureCatalogueRegistryProvider as any) as any).inTitleOrder.map( | ||
| npSetup.plugins.feature_catalogue.register | ||
| ); | ||
| return npStart.plugins.feature_catalogue.get(); |
There was a problem hiding this comment.
@flash1293 Any issues with doing this here?
💚 Build Succeeded |
Summary
Fixes #46738
This PR adds a new
feature_catalogueplugin which provides an interface for registering and reading a catalogue items.For the time being, the Home app will register all items out of the legacy registry with the new plugin, and then read these items out of the new plugin.
Dev Docs
The
ui/registries/feature_cataloguemodule has been deprecated for removal in 8.0Plugins wishing to migrate may remove their usage of
ui/registries/feature_catalogueand rely on either:Note that the old module supported providing a Angular DI function to receive Angular dependencies. This is no longer supported as we migrate away from Angular.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers