[Reporting] Convert main Reporting index to TS#49129
Merged
tsullivan merged 9 commits intoelastic:masterfrom Nov 14, 2019
Merged
[Reporting] Convert main Reporting index to TS#49129tsullivan merged 9 commits intoelastic:masterfrom
tsullivan merged 9 commits intoelastic:masterfrom
Conversation
Contributor
💔 Build Failed
|
Contributor
💔 Build Failed
|
b444a6c to
3f34734
Compare
Contributor
|
Pinging @elastic/kibana-stack-services (Team:Stack Services) |
tsullivan
commented
Oct 24, 2019
Member
Author
There was a problem hiding this comment.
@joelgriffith and I have been wanting to split up the Reporting index file for awhile. After converting it to Typescript and having all this code go through prettier, it made sense to break out this config section from the Reporting index.
Contributor
💔 Build Failed
|
This comment has been minimized.
This comment has been minimized.
Contributor
💔 Build Failed
|
3f34734 to
05ea029
Compare
Contributor
💔 Build Failed |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
| * @return {Object} kibana usage stats type collection object | ||
| */ | ||
| export function getReportingUsageCollector(server: any, isReady: boolean) { | ||
| export function getReportingUsageCollector(server: any, isReady: () => boolean) { |
joelgriffith
approved these changes
Oct 29, 2019
Contributor
joelgriffith
left a comment
There was a problem hiding this comment.
Really like separating out the config schema in index
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Nov 14, 2019
* [Reporting] Convert main Reporting index to TS * fix typo that broke build * fix type file import * fix the ts imports for build
tsullivan
added a commit
that referenced
this pull request
Nov 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow along #48825 in migrating Reporting to the Kibana new platform.
reporting/indexto Typescriptreporting/indexRelease Notes: Changes to prepare Reporting for Kibana v8.0.0
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers