[Reporting/New Platform] Prepare Typedefs for Legacy Shimming#48825
Merged
tsullivan merged 18 commits intoelastic:masterfrom Oct 23, 2019
Merged
[Reporting/New Platform] Prepare Typedefs for Legacy Shimming#48825tsullivan merged 18 commits intoelastic:masterfrom
tsullivan merged 18 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-stack-services (Team:Stack Services) |
tsullivan
commented
Oct 21, 2019
| }, | ||
|
|
||
| // TODO: Decouple Hapi: Build a server facade object based on the server to | ||
| // pass through to the libs. Do not pass server directly |
Member
Author
There was a problem hiding this comment.
Added this comment to point out the next step to do for migration. See https://github.com/elastic/kibana/blob/master/src/core/MIGRATION.md#de-couple-from-hapijs-server-and-request-objects
tsullivan
commented
Oct 22, 2019
| } | ||
|
|
||
| // Note: this seems to be nearly a duplicate of ExportTypeDefinition | ||
| export interface ExportType { |
Member
Author
There was a problem hiding this comment.
Removed this because it was duplicate of ExportTypeDefinition
tsullivan
commented
Oct 22, 2019
| server.route({ | ||
| path: `${BASE_GENERATE}/{p*}`, | ||
| method: 'GET', | ||
| config: getRouteConfig(), |
Member
Author
There was a problem hiding this comment.
This was removed because the routing middleware this adds is not applicable to the GET request for this.
6c46e61 to
6de1d4b
Compare
Contributor
💚 Build Succeeded |
| */ | ||
| export async function ensureBrowserDownloaded(browserType: BrowserType) { | ||
| await ensureDownloaded([BROWSERS_BY_TYPE[browserType]]); | ||
| await ensureDownloaded([chromium]); |
Contributor
|
LGTM, seems mostly Type/name changes from what I read. Did you have any other concerns @tsullivan? |
joelgriffith
approved these changes
Oct 23, 2019
Member
Author
Nope, no concerns. The purpose is just to get rid of our custom types that are provided by the core legacy framework, and get rid of direct references to Hapi. |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Oct 23, 2019
…c#48825) * [Reporting/New Platform] Prepare Typedefs for Legacy Shim * cleanup redundant * fix opts.interval / opts.pollInterval * comment on next todo * fix pretty * captureconfig typo * fix typescript conflict with shim * clean up loc * custom response toolkit type * remove unecessary route options * move getRouteOptions CSV * fix route configs * cleanup * split up type exports * fix types * fix ts errors * remove an any type
3 tasks
tsullivan
added a commit
that referenced
this pull request
Oct 24, 2019
#49124) * [Reporting/New Platform] Prepare Typedefs for Legacy Shim * cleanup redundant * fix opts.interval / opts.pollInterval * comment on next todo * fix pretty * captureconfig typo * fix typescript conflict with shim * clean up loc * custom response toolkit type * remove unecessary route options * move getRouteOptions CSV * fix route configs * cleanup * split up type exports * fix types * fix ts errors * remove an any type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR continues New Platform migration for Reporting.
KbnServertype with newServerFacadetype based onLegacy.ServerRequestFacadetype andLegacy.*types.configfields inserver.routeobject tooptions(configwas deprecated in Hapi v17)Release Notes: Changes to prepare Reporting for Kibana v8.0.0
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibility