Fix angular stack overflow by changing apply filters popover directiv…#48559
Merged
alexwizp merged 1 commit intoelastic:masterfrom Oct 18, 2019
Merged
Fix angular stack overflow by changing apply filters popover directiv…#48559alexwizp merged 1 commit intoelastic:masterfrom
alexwizp merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
367ebeb to
2aea7e5
Compare
Contributor
💚 Build Succeeded |
Contributor
|
I'm unclear if this aims to solve all stack overflow issues or just a specific subset. I'm running the branch locally and looking at discover - adding and removing filters causes stack overflow errors. Another action in discover which causes stack overflow - https://cl.ly/f62c957e90a8 |
Contributor
Author
|
@mattkime this is specific to the errors on dashboard. Sorry for not mentioning it in the issue. Now it seems we have more than one problem! |
alexwizp
approved these changes
Oct 18, 2019
alexwizp
pushed a commit
to alexwizp/kibana
that referenced
this pull request
Oct 18, 2019
alexwizp
pushed a commit
to alexwizp/kibana
that referenced
this pull request
Oct 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix angular stack overflow on dashboard application, by changing apply filters popover directive implementation
The bug was caused by a combination of now passing in the
notificationservice intoIndexPatternsand the custom way that theapplyFiltersPopoverdirective used to watch filters and modify state in it.This PR changes the way
applyFiltersPopoverwatches state. It also moves modifying the state into the React component.bee4212
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers