Skip to content

Replace ui/notify with npSetup.core.notifications#47588

Merged
gospodarsky merged 1 commit intoelastic:masterfrom
gospodarsky:replace-ui-notify-with-core-notification
Oct 9, 2019
Merged

Replace ui/notify with npSetup.core.notifications#47588
gospodarsky merged 1 commit intoelastic:masterfrom
gospodarsky:replace-ui-notify-with-core-notification

Conversation

@gospodarsky
Copy link
Copy Markdown

@gospodarsky gospodarsky commented Oct 8, 2019 •
edited
Loading

Summary

This is a part of #43443

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@gospodarsky gospodarsky self-assigned this Oct 8, 2019
@gospodarsky gospodarsky requested a review from alexwizp October 8, 2019 14:23
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 8, 2019

💚 Build Succeeded

@gospodarsky gospodarsky marked this pull request as ready for review October 9, 2019 06:54
ppisljar
ppisljar reviewed Oct 9, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

streamich
streamich approved these changes Oct 9, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gospodarsky gospodarsky merged commit bee4212 into elastic:master Oct 9, 2019
@gospodarsky gospodarsky mentioned this pull request Oct 9, 2019
Merged
gospodarsky pushed a commit that referenced this pull request Oct 9, 2019
Replace ui/notify with npSetup.core.notifications (#47588) (#47687)
18cfc42
@alexwizp alexwizp added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 and removed release_note:enhancement v7.6.0 labels Oct 14, 2019
@lizozom lizozom mentioned this pull request Oct 17, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ppisljar ppisljar ppisljar left review comments

@alexwizp alexwizp alexwizp left review comments

@lizozom lizozom Awaiting requested review from lizozom

+1 more reviewer

@streamich streamich streamich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@gospodarsky gospodarsky

Labels

Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gospodarsky @elasticmachine @streamich @ppisljar @alexwizp