[Vis: Default editor] EUIficate Vega options tab by sulemanof · Pull Request #47473 · elastic/kibana

sulemanof · 2019-10-07T14:42:40Z

Summary

A part of #38247.
EUIfication of the Vega visualization editor.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-10-07T15:54:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: aa6faf2

flash1293

LGTM, tested and didn't notice any problems

src/legacy/core_plugins/vis_type_vega/public/components/vega_vis_editor.tsx

…ns/vega

elasticmachine · 2019-10-10T11:17:35Z

Pinging @elastic/kibana-app (Team:KibanaApp)

elasticmachine · 2019-10-10T12:38:54Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: e8d22bd

elasticmachine · 2019-10-10T13:35:36Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 7797a76

sulemanof · 2019-10-14T08:04:18Z

@elasticmachine merge upstream

sulemanof · 2019-10-14T08:06:58Z

@snide @chandlerprall @cchaos @ryankeairns
Kindly ask someone of you to take a look at this PR 😊
Thanks in advance!

elasticmachine · 2019-10-14T09:20:10Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8f4ce74

maryia-lapata

Overall looks good, but we need to leave some configuration for reformatting. Please take a look at the comments below.

src/legacy/core_plugins/vis_type_vega/public/components/vega_help_menu.tsx

maryia-lapata · 2019-10-14T13:02:06Z

src/legacy/core_plugins/vis_type_vega/public/components/vega_vis_editor.tsx

+function format(value: string, stringify: typeof compactStringify) {
+  try {
+    const spec = hjson.parse(value, { legacyRoot: false, keepWsc: true });
+    return stringify(spec);


I don't think we can skip options like it was before https://github.com/elastic/kibana/pull/47473/files#diff-2abd10d2a2ed5649151d832d6ae32983L63.
For example without options reformatting as HJON removes comments:

Thanks!
Fixed.
But currently HJSON formatting works incorrectly because of upgrading -> #48023

src/legacy/core_plugins/vis_type_vega/public/components/vega_help_menu.tsx

…ns/vega

elasticmachine · 2019-10-16T15:44:10Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: a8a41ef

sulemanof · 2019-10-17T09:58:16Z

@elasticmachine merge upstream

elasticmachine · 2019-10-17T11:14:58Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: a55e598

cchaos

I found a couple regressions due to some of the CSS removals.

src/legacy/core_plugins/vis_type_vega/public/_vega_editor.scss

elasticmachine · 2019-10-18T12:20:04Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: e78a95b

cchaos

Thanks for fixing those

maryia-lapata

LGTM

* EUIficate Vega options tab * Update list of dependencies * Fix comments * Adjust styles

EUIficate Vega options tab

aa6faf2

sulemanof requested review from alexwizp and flash1293 October 8, 2019 11:06

flash1293 approved these changes Oct 10, 2019

View reviewed changes

src/legacy/core_plugins/vis_type_vega/public/components/vega_vis_editor.tsx Outdated Show resolved Hide resolved

src/legacy/core_plugins/vis_type_vega/public/components/vega_vis_editor.tsx Outdated Show resolved Hide resolved

sulemanof requested review from cchaos, ryankeairns and snide October 10, 2019 10:39

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

e8d22bd

…ns/vega

alexwizp approved these changes Oct 10, 2019

View reviewed changes

sulemanof marked this pull request as ready for review October 10, 2019 11:13

sulemanof requested a review from a team as a code owner October 10, 2019 11:13

timroes mentioned this pull request Oct 10, 2019

Convert Vega to New Platform #38247

Closed

4 tasks

sulemanof added Feature:Vega Vega visualizations release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.5.0 v8.0.0 labels Oct 10, 2019

Update list of dependencies

7797a76

Merge branch 'master' into EUIfication/options/vega

8f4ce74

timroes mentioned this pull request Oct 14, 2019

EUIficate visualization option panels #38273

Closed

10 tasks

maryia-lapata suggested changes Oct 14, 2019

View reviewed changes

sulemanof added 2 commits October 16, 2019 12:42

Merge remote-tracking branch 'upstream/master' into EUIfication/optio…

be1c9d6

…ns/vega

Fix comments

a8a41ef

Merge branch 'master' into EUIfication/options/vega

a55e598

cchaos suggested changes Oct 17, 2019

View reviewed changes

src/legacy/core_plugins/vis_type_vega/public/_vega_editor.scss Show resolved Hide resolved

src/legacy/core_plugins/vis_type_vega/public/_vega_editor.scss Show resolved Hide resolved

sulemanof added 2 commits October 18, 2019 12:27

Merge branch 'master' into EUIfication/options/vega

5ca2eda

Adjust styles

e78a95b

sulemanof requested review from cchaos and maryia-lapata October 18, 2019 11:05

cchaos approved these changes Oct 18, 2019

View reviewed changes

maryia-lapata approved these changes Oct 18, 2019

View reviewed changes

sulemanof merged commit 3138709 into elastic:master Oct 18, 2019

sulemanof deleted the EUIfication/options/vega branch October 18, 2019 13:26

sulemanof added v7.6.0 and removed v7.5.0 labels Oct 18, 2019

sulemanof mentioned this pull request Oct 18, 2019

[7.x] [Vis: Default editor] EUIficate Vega options tab (#47473) #48637

Merged

sulemanof added a commit to sulemanof/kibana that referenced this pull request Oct 18, 2019

[Vis: Default editor] EUIficate Vega options tab (elastic#47473)

96c036d

* EUIficate Vega options tab * Update list of dependencies * Fix comments * Adjust styles

sulemanof added a commit that referenced this pull request Oct 21, 2019

[Vis: Default editor] EUIficate Vega options tab (#47473) (#48637)

354973e

* EUIficate Vega options tab * Update list of dependencies * Fix comments * Adjust styles

alexwizp mentioned this pull request Aug 7, 2020

In autoapply, rapid typing in Vega plugin causes editor history & position reset #16161

Closed

Conversation

sulemanof commented Oct 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Oct 7, 2019

💚 Build Succeeded

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Oct 10, 2019

Uh oh!

elasticmachine commented Oct 10, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Oct 10, 2019

💚 Build Succeeded

Uh oh!

sulemanof commented Oct 14, 2019

Uh oh!

sulemanof commented Oct 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Oct 14, 2019

💚 Build Succeeded

Uh oh!

maryia-lapata left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maryia-lapata Oct 14, 2019

Choose a reason for hiding this comment

Uh oh!

sulemanof Oct 16, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticmachine commented Oct 16, 2019

💔 Build Failed

Uh oh!

sulemanof commented Oct 17, 2019

Uh oh!

elasticmachine commented Oct 17, 2019

💚 Build Succeeded

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Oct 18, 2019

💚 Build Succeeded

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

maryia-lapata left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sulemanof commented Oct 7, 2019 •

edited

Loading

sulemanof commented Oct 14, 2019 •

edited

Loading