Skip to content

Update dependency hjson to v3.2.0#48023

Merged
spalger merged 1 commit intomasterfrom
renovate/hjson-3.x
Oct 13, 2019
Merged

Update dependency hjson to v3.2.0#48023
spalger merged 1 commit intomasterfrom
renovate/hjson-3.x

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented Oct 11, 2019

This PR contains the following updates:

Package Type Update Change
hjson (source) dependencies minor 3.1.2 -> 3.2.0

Release Notes

hjson/hjson-js

v3.2.0

Compare Source


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot added release_note:skip Skip the PR/issue when compiling release notes renovate Renovate dependency update with major version updates v7.5.0 v8.0.0 labels Oct 11, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@spalger spalger merged commit 6ddbef0 into master Oct 13, 2019
spalger added a commit to spalger/kibana that referenced this pull request Oct 13, 2019
@renovate renovate bot deleted the renovate/hjson-3.x branch October 13, 2019 03:07
@sulemanof
Copy link
Copy Markdown
Contributor

Hey @spalger !
I'm currently working on EUIfication of Vega editor, which uses hjson parser.
I've noticed that after upgrading it to 3.2.0, the stringify works incorrectly with keepWsc: true and produces weird string (strings are duplicated several times) :

vega_bug

Do we need to revert this upgrade?

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Oct 18, 2019

@sulemanof is this a bug in master too or only in your fork? Would you mind opening an issue with hjson? Maybe there is a change we need to make to the way we're calling it to get it to work correctly?

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Oct 18, 2019

7.x/7.6: 4eb745f

@sulemanof
Copy link
Copy Markdown
Contributor

I created an issue for this and prepared a fix also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported release_note:skip Skip the PR/issue when compiling release notes renovate Renovate dependency update with major version updates v7.6.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants