Update gulp related packages (major)#46665
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…r-gulp # Conflicts: # yarn.lock
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
added 2 commits
September 27, 2019 11:20
…r-gulp # Conflicts: # yarn.lock
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
clintandrewhall
approved these changes
Oct 3, 2019
Contributor
clintandrewhall
left a comment
There was a problem hiding this comment.
Looks good for Canvas. Just a few nits/suggestions.
| // @ts-ignore | ||
| import { findPluginSpecs } from '../../../src/legacy/plugin_discovery'; | ||
|
|
||
| /* |
Contributor
There was a problem hiding this comment.
nit: perhaps add a help flag to output this?
Contributor
There was a problem hiding this comment.
I would, but gulp hijacks the --help flag. If we migrate this away from gulp (which would be ideal) then we could definitely do this.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Oct 5, 2019
* Update gulp related packages * ts-ify and gulp4-ify x-pack tasks, remove unused canvas tasks * remove unnecessary gulp.TaskFunction usage * fix old references * update renovate config * move constants into helpers directory * typo * compact tasks a bit, remove unnecessary paths * fix build directories * deprecate testonly task * rather than justifying an unjustifiable ts-ignore, ts-ify the imported module * update renovate config * update browser download tests to mock axios * add root index.d.ts to tsconfig * export BrowserType * remove unnecessary `@ts-ignore` * use consistent casing
spalger
pushed a commit
that referenced
this pull request
Oct 7, 2019
* Update gulp related packages (major) (#46665) * Update gulp related packages * ts-ify and gulp4-ify x-pack tasks, remove unused canvas tasks * remove unnecessary gulp.TaskFunction usage * fix old references * update renovate config * move constants into helpers directory * typo * compact tasks a bit, remove unnecessary paths * fix build directories * deprecate testonly task * rather than justifying an unjustifiable ts-ignore, ts-ify the imported module * update renovate config * update browser download tests to mock axios * add root index.d.ts to tsconfig * export BrowserType * remove unnecessary `@ts-ignore` * use consistent casing * correct import for createAutoJUnitReporter * Update gulp related packages (#47421) (cherry picked from commit 35751f9)
Contributor
|
7.x/7.5: ef6727c |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 7, 2019
… into console-token-iterator * 'console-token-iterator' of github.com:jloleysens/kibana: (184 commits) [functional/services] update webdriver lib and types (elastic#47381) Standardizing IconField implementation across the app (elastic#47196) Move ui/value_suggestions ⇒ NP data plugin (elastic#45762) Remove ui/persisted_log - Part 2 (elastic#47236) Update gulp related packages (elastic#47421) Update dependency idx to ^2.5.6 (elastic#47399) try running fewer jobs in parallel on the same worker (elastic#47403) Update webpack related packages (elastic#47402) Update jsonwebtoken related packages (elastic#47400) Update gulp related packages (major) (elastic#46665) Update dependency prettier to ^1.18.2 (elastic#47340) Update dependency @types/puppeteer to ^1.20.1 (elastic#47339) Update dependency @elastic/elasticsearch to ^7.4.0 (elastic#47338) Update dependency tar-fs to ^1.16.3 (elastic#47341) [Code] Code Integrator Component (elastic#47180) [Canvas][i18n] Sidebar (elastic#46090) Generate uuid in task Manager as Kibana uuid may not yet have been initialised [Code] Embedded Code Snippet Component (elastic#47183) Revert "Add pipeline for flaky test runner job (elastic#46740)" SearchSource: fix docvalue_fields and fields intersection logic (elastic#46724) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3.9.1->4.0.22.2.0->7.0.14.2.0->5.0.0Release Notes
gulpjs/gulp
v4.0.2Compare Source
Fix
Docs
Build
v4.0.1Compare Source
Fix
Docs
(c960c1d)
Upgrade
Build
Scaffold
v4.0.0Compare Source
Task system changes
gulp.taskgulp.taskshould only be used when you will call the task with the CLIgulp.seriesandgulp.parallelmethods for composing tasks. Everything must use these now.gulp.taskwhich allows a named function to be used as the name of the task and task function.gulp.treemethod for retrieving the task tree. Pass{ deep: true }for anarchycompatible node list.gulp.registryfor setting custom registries.CLI changes
npm install gulp -gornpm install gulp-cli -g, where gulp-cli is the smaller one (no module code included)--tasks-jsonflag to CLI to dump the whole tree out for other tools to consume--verifyflag to check the dependencies in package.json against the plugin blacklist.vinyl/vinyl-fs changes
gulp.symlinkwhich functions exactly likegulp.dest, but symlinks instead.dirModeparam togulp.destandgulp.symlinkwhich allows better control over the mode of the destination folder that is created.gulp.srcwill be evaluated in order, which means this is possiblegulp.src(['*.js', '!b*.js', 'bad.js'])(exclude every JS file that starts with a b except bad.js)gulp.src(['**/*', '!b.js'])will no longer eat CPU since negations happen during walking nowsinceoption togulp.srcwhich lets you only match files that have been modified since a certain date (for incremental builds)gulp.srcnot following symlinksoverwriteoption togulp.destwhich allows you to enable or disable overwriting of existing filessindresorhus/gulp-mocha
v7.0.1Compare Source
f60a346v7.0.0Compare Source
Breaking:
49244374924437v6.0.0Compare Source
v5.0.0Compare Source
v4.3.1Compare Source
v4.3.0Compare Source
v4.2.0Compare Source
v4.1.0Compare Source
v4.0.1Compare Source
v4.0.0Compare Source
mochabinary instead using its broken programmatic API. This means you can use any of themochaCLI flags (in a camelCased form). This should also fix most of the issues people have been having with this task. Thanks to @shellscape for doing most of the work.If you were using Babel with
babel-registerin your gulpfile, you now need to use the Mochacompilersoption instead:{compilers: 'js:babel-core/register'}. See https://babeljs.io/docs/setup/#installationv3.0.1Compare Source
v3.0.0Compare Source
sindresorhus/gulp-zip
v5.0.0Compare Source
Breaking:
ddbacceRenovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "
rebase!".👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Renovate Bot. View repository job log here.