Merged
Conversation
Contributor
💔 Build Failed |
02c62fa to
2f5b3bd
Compare
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Extracts i18n strings from sidebar_content Extracts i18n strings from element_settings Extracted i18n strings from workpad_config Extracts i18n strings from page_config Extracts i18n strings from group_settings Extracts i18n strings from element_config and multi_element_settings Extracted remaining strings from element_config Extracts i18n strings from sidebar_header Extracts i18n strings from custom_element_modal Fixed file picker placeholder Fixed i18n ids
607940b to
1511eb8
Compare
Contributor
|
Pinging @elastic/kibana-canvas |
Contributor
💚 Build Succeeded |
Contributor
|
This translation being long makes it overflow the box. Probably should make an issue separate from this PR to see if we can stop that from happening since we're not sure how long translations will be. |
crob611
approved these changes
Sep 24, 2019
| PageConfig: { | ||
| getBackgroundColorDescription: () => | ||
| i18n.translate('xpack.canvas.pageConfig.backgroundColorDescription', { | ||
| defaultMessage: 'Accepts HEX, RGB or HTML color names', |
Contributor
There was a problem hiding this comment.
Should Hex RGB and HTML be constants?
Contributor
Author
There was a problem hiding this comment.
I don't think so. I looked them up in wikipedia in multiple languages, and in some languages they are translated to something else. I'll leave that to the translators to decide how to handle those.
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Oct 7, 2019
… into console-token-iterator * 'console-token-iterator' of github.com:jloleysens/kibana: (184 commits) [functional/services] update webdriver lib and types (elastic#47381) Standardizing IconField implementation across the app (elastic#47196) Move ui/value_suggestions ⇒ NP data plugin (elastic#45762) Remove ui/persisted_log - Part 2 (elastic#47236) Update gulp related packages (elastic#47421) Update dependency idx to ^2.5.6 (elastic#47399) try running fewer jobs in parallel on the same worker (elastic#47403) Update webpack related packages (elastic#47402) Update jsonwebtoken related packages (elastic#47400) Update gulp related packages (major) (elastic#46665) Update dependency prettier to ^1.18.2 (elastic#47340) Update dependency @types/puppeteer to ^1.20.1 (elastic#47339) Update dependency @elastic/elasticsearch to ^7.4.0 (elastic#47338) Update dependency tar-fs to ^1.16.3 (elastic#47341) [Code] Code Integrator Component (elastic#47180) [Canvas][i18n] Sidebar (elastic#46090) Generate uuid in task Manager as Kibana uuid may not yet have been initialised [Code] Embedded Code Snippet Component (elastic#47183) Revert "Add pipeline for flaky test runner job (elastic#46740)" SearchSource: fix docvalue_fields and fields intersection logic (elastic#46724) ...
cqliu1
added a commit
to cqliu1/kibana
that referenced
this pull request
Oct 7, 2019
* This is a combination of 5 commits.
Extracts i18n strings from sidebar_content
Extracts i18n strings from element_settings
Extracted i18n strings from workpad_config
Extracts i18n strings from page_config
Extracts i18n strings from group_settings
Extracts i18n strings from element_config and multi_element_settings
Extracted remaining strings from element_config
Extracts i18n strings from sidebar_header
Extracts i18n strings from custom_element_modal
Fixed file picker placeholder
Fixed i18n ids
* Alphabetize keys
* Fixed save button label
* fixed merge conflict
cqliu1
added a commit
that referenced
this pull request
Oct 7, 2019
* This is a combination of 5 commits.
Extracts i18n strings from sidebar_content
Extracts i18n strings from element_settings
Extracted i18n strings from workpad_config
Extracts i18n strings from page_config
Extracts i18n strings from group_settings
Extracts i18n strings from element_config and multi_element_settings
Extracted remaining strings from element_config
Extracts i18n strings from sidebar_header
Extracts i18n strings from custom_element_modal
Fixed file picker placeholder
Fixed i18n ids
* Alphabetize keys
* Fixed save button label
* fixed merge conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #23222.
This adds i18n support to the
Sidebarcomponent and all nested components.Default view (no elements selected)
One non-group element selected
Multiple elements selected
One grouped element selected
Sidebar header context menu
Save custom element modal
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers