[SIEM] fix redirect to maintain search query string#45184
Merged
XavierM merged 1 commit intoelastic:masterfrom Sep 9, 2019
Merged
[SIEM] fix redirect to maintain search query string#45184XavierM merged 1 commit intoelastic:masterfrom
XavierM merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/siem |
Contributor
💚 Build Succeeded |
| <Route | ||
| path="/ml-hosts/" | ||
| render={({ location: { search = '' } }) => ( | ||
| <Redirect from="/ml-hosts/" to={`/ml-hosts${search}`} /> |
Contributor
There was a problem hiding this comment.
Thanks for adding this for the ml-hosts, it would be a bug there as well.
| <Route | ||
| path="/ml-network/" | ||
| render={({ location: { search = '' } }) => ( | ||
| <Redirect from="/ml-network/" to={`/ml-network${search}`} /> |
Contributor
There was a problem hiding this comment.
Thanks for adding this for the ml-network, it would be a bug there as well.
FrankHassanabad
approved these changes
Sep 9, 2019
Contributor
FrankHassanabad
left a comment
There was a problem hiding this comment.
Checked it out, played with it, and this looks like it is working great.
Thank you for adding in the ML side of the house.
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 10, 2019
…-to-np-ready * 'master' of github.com:elastic/kibana: (138 commits) [Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript (elastic#44943) update close/delete system index modals (elastic#45037) TS return type of createIndexPatternSelect (elastic#45107) [ML] Fix focus chart updating. (elastic#45146) [ML] Data frame transform: Fix progress in wizard create step. (elastic#45116) [Graph] Re-enable functional test (elastic#44683) [SIEM] unique table id for each top talkers table (elastic#45014) [SIEM] ip details heading draggable (elastic#45179) [Maps][File upload] Set complete on index pattern creation (elastic#44423) [Maps] unmount map embeddable component on destroy (elastic#45183) [SIEM] Adds error toasts to MapEmbeddable component (elastic#45088) fix redirect to maintain search query string (elastic#45184) [APM] One-line trace summary (elastic#44842) [Infra UI] Display non-metric details on Node Detail page (elastic#43551) [Maps][File upload] Removing bbox from parsed file pending upstream lib fix (elastic#45194) [Logs UI] Improve live streaming behavior when scrolling (elastic#44923) [APM] Fix indefinite loading state in agent settings for unauthorized user roles (elastic#44970) [Reporting] Rewrite addForceNowQuerystring to getFullUrls (elastic#44851) [Reporting/ESQueue] Improve logging of doc-update events (elastic#45077) [Reporting] Make screenshot capture less noisy by default (elastic#45185) ...
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Sep 12, 2019
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Sep 12, 2019
XavierM
added a commit
that referenced
this pull request
Sep 12, 2019
XavierM
added a commit
that referenced
this pull request
Sep 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
we add a bug where the component
Redirectofreact-routerwas not transferring the search query string to the new route. So this PR should fix that.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately