[SIEM] Adds error toasts to MapEmbeddable component by spong · Pull Request #45088 · elastic/kibana

spong · 2019-09-06T23:38:02Z

Summary

Displays error toasts when an error occurs within the MapEmbeddable component. This PR also updates the maps colors as per team discussion, removes filter on source/destination layers (to show points when either src/dest are configured), and also increases test coverage.

fixes https://github.com/elastic/siem-team/issues/449

Error Toast when exception is thrown creating embeddable

Toast with map hidden:

Toast Details:

Updated Colors

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

~~This was checked for breaking API changes and was labeled appropriately~~
~~This includes a feature addition or change that requires a release note and was labeled appropriately~~

elasticmachine · 2019-09-06T23:38:04Z

Pinging @elastic/siem

…asts

…verage

…asts

elasticmachine · 2019-09-09T13:50:42Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…asts

elasticmachine · 2019-09-09T21:15:09Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

spong · 2019-09-09T21:21:40Z

retest

…asts

x-pack/legacy/plugins/siem/public/components/embeddables/embedded_map_helpers.tsx

andrew-goldstein · 2019-09-09T22:30:26Z

x-pack/legacy/plugins/siem/public/components/embeddables/embedded_map_helpers.test.tsx

+  });
+
+  describe('createEmbeddable', () => {
+    test('attaches refresh action', () => {


missing async

Thank-you thank-you! There was a broken test hiding behind this, so great find! 🙂

…asts

andrew-goldstein

I ran this locally and verified the error handling UX by first deleting the index patterns used by the map, and for the non-index-pattern related toaster errors, peppered the code with some throws, and verified the errors appeared in the toaster.

LGTM 🗺

elasticmachine · 2019-09-10T00:25:52Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

## Summary Displays error toasts when an error occurs within the MapEmbeddable component. This PR also updates the maps colors as per team discussion, removes filter on source/destination layers (to show points when either src/dest are configured), and also increases test coverage. fixes elastic/siem-team#449 #### Error Toast when exception is thrown creating embeddable Toast with map hidden: ![image](https://user-images.githubusercontent.com/2946766/64562698-c03f0500-d30a-11e9-8a8a-d6a352cf0d93.png) Toast Details: ![image](https://user-images.githubusercontent.com/2946766/64562725-cd5bf400-d30a-11e9-8e49-dbaa425b6f2e.png) #### Updated Colors ![image](https://user-images.githubusercontent.com/2946766/64561629-73f2c580-d308-11e9-9f28-c76c0bc99d39.png) ![image](https://user-images.githubusercontent.com/2946766/64562517-62122200-d30a-11e9-9e1e-737d7dc785f7.png) ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~ - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~ ### For maintainers - [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~ - [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

Displays error toasts when an error occurs within the MapEmbeddable component. This PR also updates the maps colors as per team discussion, removes filter on source/destination layers (to show points when either src/dest are configured), and also increases test coverage. fixes elastic/siem-team#449 Toast with map hidden: ![image](https://user-images.githubusercontent.com/2946766/64562698-c03f0500-d30a-11e9-8a8a-d6a352cf0d93.png) Toast Details: ![image](https://user-images.githubusercontent.com/2946766/64562725-cd5bf400-d30a-11e9-8e49-dbaa425b6f2e.png) ![image](https://user-images.githubusercontent.com/2946766/64561629-73f2c580-d308-11e9-9f28-c76c0bc99d39.png) ![image](https://user-images.githubusercontent.com/2946766/64562517-62122200-d30a-11e9-9e1e-737d7dc785f7.png) Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~ - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~ - [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~ - [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

## Summary Displays error toasts when an error occurs within the MapEmbeddable component. This PR also updates the maps colors as per team discussion, removes filter on source/destination layers (to show points when either src/dest are configured), and also increases test coverage. fixes elastic/siem-team#449 #### Error Toast when exception is thrown creating embeddable Toast with map hidden: ![image](https://user-images.githubusercontent.com/2946766/64562698-c03f0500-d30a-11e9-8a8a-d6a352cf0d93.png) Toast Details: ![image](https://user-images.githubusercontent.com/2946766/64562725-cd5bf400-d30a-11e9-8e49-dbaa425b6f2e.png) #### Updated Colors ![image](https://user-images.githubusercontent.com/2946766/64561629-73f2c580-d308-11e9-9f28-c76c0bc99d39.png) ![image](https://user-images.githubusercontent.com/2946766/64562517-62122200-d30a-11e9-9e1e-737d7dc785f7.png) ### Checklist Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~ - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~ ### For maintainers - [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~ - [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

Displays error toasts when an error occurs within the MapEmbeddable component. This PR also updates the maps colors as per team discussion, removes filter on source/destination layers (to show points when either src/dest are configured), and also increases test coverage. fixes elastic/siem-team#449 Toast with map hidden: ![image](https://user-images.githubusercontent.com/2946766/64562698-c03f0500-d30a-11e9-8a8a-d6a352cf0d93.png) Toast Details: ![image](https://user-images.githubusercontent.com/2946766/64562725-cd5bf400-d30a-11e9-8e49-dbaa425b6f2e.png) ![image](https://user-images.githubusercontent.com/2946766/64561629-73f2c580-d308-11e9-9f28-c76c0bc99d39.png) ![image](https://user-images.githubusercontent.com/2946766/64562517-62122200-d30a-11e9-9e1e-737d7dc785f7.png) Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR. - [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~ - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios - [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~ - [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~ - [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~

…-to-np-ready * 'master' of github.com:elastic/kibana: (138 commits) [Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript (elastic#44943) update close/delete system index modals (elastic#45037) TS return type of createIndexPatternSelect (elastic#45107) [ML] Fix focus chart updating. (elastic#45146) [ML] Data frame transform: Fix progress in wizard create step. (elastic#45116) [Graph] Re-enable functional test (elastic#44683) [SIEM] unique table id for each top talkers table (elastic#45014) [SIEM] ip details heading draggable (elastic#45179) [Maps][File upload] Set complete on index pattern creation (elastic#44423) [Maps] unmount map embeddable component on destroy (elastic#45183) [SIEM] Adds error toasts to MapEmbeddable component (elastic#45088) fix redirect to maintain search query string (elastic#45184) [APM] One-line trace summary (elastic#44842) [Infra UI] Display non-metric details on Node Detail page (elastic#43551) [Maps][File upload] Removing bbox from parsed file pending upstream lib fix (elastic#45194) [Logs UI] Improve live streaming behavior when scrolling (elastic#44923) [APM] Fix indefinite loading state in agent settings for unauthorized user roles (elastic#44970) [Reporting] Rewrite addForceNowQuerystring to getFullUrls (elastic#44851) [Reporting/ESQueue] Improve logging of doc-update events (elastic#45077) [Reporting] Make screenshot capture less noisy by default (elastic#45185) ...

Adding error toasters

ec377d4

spong added bug Fixes for quality problems that affect the customer experience Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v7.5.0 labels Sep 6, 2019

spong self-assigned this Sep 6, 2019

Merge branch 'master' of github.com:elastic/kibana into maps-error-to…

42703ec

…asts

This comment has been minimized.

Sign in to view

spong added 3 commits September 8, 2019 18:12

Merge branch 'master' of github.com:elastic/kibana into maps-error-to…

07c5ae5

…asts

Refactors embeddable_map to be easier to test, and increasing test co…

932e34b

…verage

Merge branch 'master' of github.com:elastic/kibana into maps-error-to…

2534308

…asts

spong marked this pull request as ready for review September 9, 2019 14:36

spong added 3 commits September 9, 2019 13:43

Fixing source & destination colors and constraints

790b5a9

Merge branch 'master' of github.com:elastic/kibana into maps-error-to…

d1c7c22

…asts

Updating mocks

1008e35

spong added 2 commits September 9, 2019 15:27

Merge branch 'master' of github.com:elastic/kibana into maps-error-to…

0707525

…asts

Merge branch 'master' of github.com:elastic/kibana into maps-error-to…

9e6e19c

…asts

andrew-goldstein reviewed Sep 9, 2019

View reviewed changes

x-pack/legacy/plugins/siem/public/components/embeddables/embedded_map_helpers.tsx Show resolved Hide resolved

andrew-goldstein reviewed Sep 9, 2019

View reviewed changes

spong added 2 commits September 9, 2019 16:55

Fixes from comments

e641514

Merge branch 'master' of github.com:elastic/kibana into maps-error-to…

4c8fc80

…asts

andrew-goldstein approved these changes Sep 9, 2019

View reviewed changes

spong merged commit 5b6d4a7 into elastic:master Sep 10, 2019

spong mentioned this pull request Sep 10, 2019

[7.x] [SIEM] Adds error toasts to MapEmbeddable component (#45088) #45226

Merged

spong mentioned this pull request Sep 10, 2019

[7.4] [SIEM] Adds error toasts to MapEmbeddable component (#45088) #45227

Merged

spong deleted the maps-error-toasts branch September 10, 2019 02:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SIEM] Adds error toasts to MapEmbeddable component#45088

[SIEM] Adds error toasts to MapEmbeddable component#45088
spong merged 12 commits intoelastic:masterfrom
spong:maps-error-toasts

spong commented Sep 6, 2019 •

edited

Loading

Uh oh!

elasticmachine commented Sep 6, 2019

Uh oh!

This comment has been minimized.

elasticmachine commented Sep 9, 2019

Uh oh!

elasticmachine commented Sep 9, 2019

Uh oh!

spong commented Sep 9, 2019

Uh oh!

Uh oh!

andrew-goldstein Sep 9, 2019

Uh oh!

spong Sep 9, 2019

Uh oh!

andrew-goldstein left a comment

Uh oh!

elasticmachine commented Sep 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

spong commented Sep 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Error Toast when exception is thrown creating embeddable

Updated Colors

Checklist

For maintainers

Uh oh!

elasticmachine commented Sep 6, 2019

Uh oh!

This comment has been minimized.

elasticmachine commented Sep 9, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Sep 9, 2019

💔 Build Failed

Uh oh!

spong commented Sep 9, 2019

Uh oh!

Uh oh!

andrew-goldstein Sep 9, 2019

Choose a reason for hiding this comment

Uh oh!

spong Sep 9, 2019

Choose a reason for hiding this comment

Uh oh!

andrew-goldstein left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Sep 10, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

spong commented Sep 6, 2019 •

edited

Loading