Timefilter - replace SimpleEmitter with observables#43748
Merged
lizozom merged 28 commits intoelastic:masterfrom Aug 27, 2019
Merged
Timefilter - replace SimpleEmitter with observables#43748lizozom merged 28 commits intoelastic:masterfrom
lizozom merged 28 commits intoelastic:masterfrom
Conversation
added 19 commits
August 8, 2019 12:59
…ilter/observables
…ilter/observables
…ilter/observables
…ilter/observables
Contributor
|
Pinging @elastic/kibana-app-arch |
Contributor
Author
|
@chrisronline I fixed the error you saw when stopping auto refresh. |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
clintandrewhall
approved these changes
Aug 25, 2019
Contributor
clintandrewhall
left a comment
There was a problem hiding this comment.
LGTM, and the changes wrt to Canvas seem very straightforward. Accepting for Canvas.
…ilter/observables
walterra
reviewed
Aug 26, 2019
Contributor
walterra
left a comment
There was a problem hiding this comment.
Looks good overall, just added a question about a line that could possibly removed.
x-pack/legacy/plugins/ml/public/timeseriesexplorer/timeseriesexplorer.js
Outdated
Show resolved
Hide resolved
Contributor
|
@lizozom, I added @jgowdyelastic as a reviewer too since he's more into the new anomaly job wizards code. |
added 2 commits
August 27, 2019 09:57
Contributor
Author
|
Thanks. @jgowdyelastic let me know if you have any questions. |
Contributor
💚 Build Succeeded |
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Aug 27, 2019
* Replaced 'timeUpdate' and 'enabledUpdated' timefilter events with observables. * Change enabledUpdated$ to a BehaviorSubject * refreshIntervalUpdate + fixes in monitoring * autoRefreshFetch * getFetch + delete listenAndDigestAsync * Removed SimpleEmitter parent * Updated timefilter tests * Post merge code updates in ML + type fixes * visual editor unsubscribe * removed unused import * timefilter mock * Import only from top level of timefilter * Fixed typo in discover * unsubscribe in monitoring * Deleted two tests relying on timefilter implementing EventEmitter * Renamed subscribtion var name * import path for fixing jest test ? * Removed unused row
lizozom
pushed a commit
that referenced
this pull request
Aug 28, 2019
* Replaced 'timeUpdate' and 'enabledUpdated' timefilter events with observables. * Change enabledUpdated$ to a BehaviorSubject * refreshIntervalUpdate + fixes in monitoring * autoRefreshFetch * getFetch + delete listenAndDigestAsync * Removed SimpleEmitter parent * Updated timefilter tests * Post merge code updates in ML + type fixes * visual editor unsubscribe * removed unused import * timefilter mock * Import only from top level of timefilter * Fixed typo in discover * unsubscribe in monitoring * Deleted two tests relying on timefilter implementing EventEmitter * Renamed subscribtion var name * import path for fixing jest test ? * Removed unused row
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of [NP Migration Phase I/II]: de-angularize & shim timefilter
Replace SimpleEmitter with observables.
FYI checked each event bieng triggered in this PR one by one
DevDocs
Timefilterexposes 5 events:getEnabledUpdated$- Fired whenisTimeRangeSelectorEnabled\isAutoRefreshSelectorEnabledare toggled.getTimeUpdate$- Fired when a user changes the timerange.getRefreshIntervalUpdate$- Fired when a user changes the the autorefresh settings.getAutoRefreshFetch$- Used when search_poll triggers an auto refresh.getFetch$- Used when data is set, or the first time auto-refresh is enabled.Old subscription:
New subscription:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers