[7.x] Timefilter - replace SimpleEmitter with observables (#43748)#44089
Merged
lizozom merged 4 commits intoelastic:7.xfrom Aug 28, 2019
Merged
[7.x] Timefilter - replace SimpleEmitter with observables (#43748)#44089lizozom merged 4 commits intoelastic:7.xfrom
lizozom merged 4 commits intoelastic:7.xfrom
Conversation
* Replaced 'timeUpdate' and 'enabledUpdated' timefilter events with observables. * Change enabledUpdated$ to a BehaviorSubject * refreshIntervalUpdate + fixes in monitoring * autoRefreshFetch * getFetch + delete listenAndDigestAsync * Removed SimpleEmitter parent * Updated timefilter tests * Post merge code updates in ML + type fixes * visual editor unsubscribe * removed unused import * timefilter mock * Import only from top level of timefilter * Fixed typo in discover * unsubscribe in monitoring * Deleted two tests relying on timefilter implementing EventEmitter * Renamed subscribtion var name * import path for fixing jest test ? * Removed unused row
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: