[New Platform Migration Phase I]: update dateHisogramInterval & parseEsInterval imports by alexwizp · Pull Request #42917 · elastic/kibana

alexwizp · 2019-08-08T10:18:13Z

Partially fix: #40553

Summary

In #39091, dateHistogramInterval, parseEsInterval and a few others were moved to the data plugin. However, imports from ui/public/utils were not switched over.

We need to update imports across Kibana so that we can remove ui/public/utils/parse_es_interval completely and consider Phase I "done" for this item.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

…EsInterval imports

elasticmachine · 2019-08-08T10:20:20Z

Pinging @elastic/kibana-app-arch

elasticmachine · 2019-08-08T11:18:14Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

lizozom · 2019-08-08T12:26:30Z

x-pack/legacy/plugins/rollup/public/crud_app/sections/job_create/steps/step_date_histogram.js

 import {
  parseEsInterval,
-} from 'ui/utils/parse_es_interval';
+} from '../../../../../../../../../src/legacy/core_plugins/data/public';


=( but we should use relative imports now

Yeah, I know. Was just acknowledging that it's ugly.

lizozom · 2019-08-08T12:27:09Z

src/legacy/core_plugins/data/public/index.ts

-  parseEsInterval,
-  ParsedInterval,
-} from '../common/parse_es_interval';
+export * from '../common';


…rval_imports

elasticmachine · 2019-08-08T13:37:54Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

lizozom · 2019-08-08T14:47:45Z

For the type of errors in your jest tests, I found this style of mocking very useful:

jest.mock('../../../../../data/public', () => {
  return {
    FilterBar: () => <div className="filterBar"></div>,
    ... any other components and services you actually need...
  };
});

elasticmachine · 2019-08-08T16:25:23Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…_imports

elasticmachine · 2019-08-09T11:39:55Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

joshdover

Changes to Core look fine 👍

rudolf

Just a small error in the docs

src/core/MIGRATION.md

Co-Authored-By: Rudolf Meijering <skaapgif@gmail.com>

elasticmachine · 2019-08-09T20:52:52Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

lizozom · 2019-08-11T13:53:59Z

Code LGTM.

Didn't test because I'm unfamiliar with rollups (where these are mostly used).
@alexwizp lets chat.

…rval_imports

elasticmachine · 2019-08-12T12:55:42Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

lizozom

Tested in rollups and LGTM

…EsInterval imports (elastic#42917) * [New Platform Migration Phase I]: update dateHisogramInterval & parseEsInterval imports * fix tests * modify MIGRATION.md * Update src/core/MIGRATION.md Co-Authored-By: Rudolf Meijering <skaapgif@gmail.com> # Conflicts: # src/core/MIGRATION.md

…EsInterval imports (#42917) (#43169) * [New Platform Migration Phase I]: update dateHisogramInterval & parseEsInterval imports * fix tests * modify MIGRATION.md * Update src/core/MIGRATION.md Co-Authored-By: Rudolf Meijering <skaapgif@gmail.com> # Conflicts: # src/core/MIGRATION.md

…p-metrics-selectall * 'master' of github.com:elastic/kibana: (27 commits) [ML] Data Frames: Analytics job creation. (elastic#43102) [Vis Default editor] Fix issue with Rollup (elastic#42430) [Vis: Default editor] EUIficate Markdown tab (elastic#42677) [New Platform Migration Phase I]: update dateHisogramInterval & parseEsInterval imports (elastic#42917) [Infra UI] Add AWS metrics to node detail page (elastic#42153) update apm index pattern (elastic#43106) [SIEM] Toggle Column / Code Coverage and Cypress (elastic#42766) skip failing test (elastic#43163) [code] Add option to turn the go dependency download on/off. (elastic#43096) disable visual regression jobs Removed dead code (elastic#42774) fixes csv export of saved searches that have _source field (elastic#43123) Export missing Context types (elastic#43051) Update dependency supports-color to v7 (elastic#43064) switch to icon type string instead of node (elastic#43111) [Maps] Enable borders for icon symbols (elastic#43066) [ftr] enable visualRegression jobs (elastic#42989) [ML] Converting single to multi metric job (elastic#42532) fix(NA): dont clean dll module if it is a package json file (elastic#42904) [Logs UI] Add link from the sample web logs to the Logs UI (elastic#42635) ...

[New Platform Migration Phase I]: update dateHisogramInterval & parse…

30b21d6

…EsInterval imports

alexwizp requested review from a team, lizozom, lukeelmers and timroes August 8, 2019 10:18

alexwizp added Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0 Team:AppArch labels Aug 8, 2019

alexwizp self-assigned this Aug 8, 2019

lukeelmers mentioned this pull request Aug 8, 2019

[New Platform Migration Phase I]: update dateHisogramInterval & parseEsInterval imports #40553

Closed

3 tasks

lizozom reviewed Aug 8, 2019

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into parse_es_inte…

e89d389

…rval_imports

fix tests

ed2765b

alexwizp requested a review from lizozom August 9, 2019 05:45

alexwizp added 2 commits August 9, 2019 12:00

Merge remote-tracking branch 'upstream/master' into parse_es_interval…

a28f6f5

…_imports

modify MIGRATION.md

725edab

alexwizp requested a review from a team as a code owner August 9, 2019 10:36

joshdover approved these changes Aug 9, 2019

View reviewed changes

rudolf reviewed Aug 9, 2019

View reviewed changes

src/core/MIGRATION.md Outdated Show resolved Hide resolved

Update src/core/MIGRATION.md

06ac750

Co-Authored-By: Rudolf Meijering <skaapgif@gmail.com>

alexwizp requested a review from rudolf August 9, 2019 19:46

maryia-lapata approved these changes Aug 12, 2019

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into parse_es_inte…

a390a02

…rval_imports

lizozom approved these changes Aug 12, 2019

View reviewed changes

alexwizp merged commit a5284a5 into elastic:master Aug 13, 2019

alexwizp mentioned this pull request Aug 13, 2019

[7.x] [New Platform Migration Phase I]: update dateHisogramInterval & parseEsInterval imports (#42917) #43169

Merged

lukeelmers mentioned this pull request Aug 19, 2019

App Architecture roadmap for New Platform migration #31968

Closed

alexwizp deleted the parse_es_interval_imports branch January 4, 2020 08:17

Conversation

alexwizp commented Aug 8, 2019

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Aug 8, 2019

Uh oh!

elasticmachine commented Aug 8, 2019

💔 Build Failed

Uh oh!

lizozom Aug 8, 2019

Choose a reason for hiding this comment

Uh oh!

alexwizp Aug 8, 2019

Choose a reason for hiding this comment

Uh oh!

lizozom Aug 8, 2019

Choose a reason for hiding this comment

Uh oh!

lizozom Aug 8, 2019

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Aug 8, 2019

💔 Build Failed

Uh oh!

lizozom commented Aug 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Aug 8, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Aug 9, 2019

💚 Build Succeeded

Uh oh!

joshdover left a comment

Choose a reason for hiding this comment

Uh oh!

rudolf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticmachine commented Aug 9, 2019

💚 Build Succeeded

Uh oh!

lizozom commented Aug 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Aug 12, 2019

💚 Build Succeeded

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

lizozom commented Aug 8, 2019 •

edited

Loading

lizozom commented Aug 11, 2019 •

edited

Loading