[ML] Converting single to multi metric job#42532
Merged
jgowdyelastic merged 3 commits intoelastic:masterfrom Aug 12, 2019
Merged
[ML] Converting single to multi metric job#42532jgowdyelastic merged 3 commits intoelastic:masterfrom
jgowdyelastic merged 3 commits intoelastic:masterfrom
Conversation
Contributor
💚 Build Succeeded |
bf7e7e4 to
036ca50
Compare
Contributor
|
Pinging @elastic/ml-ui |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
walterra
approved these changes
Aug 12, 2019
Contributor
walterra
left a comment
There was a problem hiding this comment.
LGTM, just added some minor suggestions/questions.
...obs/new_job_new/pages/components/pick_fields_step/components/single_metric_view/settings.tsx
Outdated
Show resolved
Hide resolved
...ck/legacy/plugins/ml/public/jobs/new_job_new/pages/components/time_range_step/time_range.tsx
Outdated
Show resolved
Hide resolved
alvarezmelissa87
approved these changes
Aug 12, 2019
Contributor
alvarezmelissa87
left a comment
There was a problem hiding this comment.
Agree with existing comments but LGTM overall 👍
Contributor
💚 Build Succeeded |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Aug 12, 2019
* [ML] Converting single to multi metric job * removing summary_count_field_name from copied job * changes based on review
jgowdyelastic
added a commit
that referenced
this pull request
Aug 12, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 13, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (27 commits) [ML] Data Frames: Analytics job creation. (elastic#43102) [Vis Default editor] Fix issue with Rollup (elastic#42430) [Vis: Default editor] EUIficate Markdown tab (elastic#42677) [New Platform Migration Phase I]: update dateHisogramInterval & parseEsInterval imports (elastic#42917) [Infra UI] Add AWS metrics to node detail page (elastic#42153) update apm index pattern (elastic#43106) [SIEM] Toggle Column / Code Coverage and Cypress (elastic#42766) skip failing test (elastic#43163) [code] Add option to turn the go dependency download on/off. (elastic#43096) disable visual regression jobs Removed dead code (elastic#42774) fixes csv export of saved searches that have _source field (elastic#43123) Export missing Context types (elastic#43051) Update dependency supports-color to v7 (elastic#43064) switch to icon type string instead of node (elastic#43111) [Maps] Enable borders for icon symbols (elastic#43066) [ftr] enable visualRegression jobs (elastic#42989) [ML] Converting single to multi metric job (elastic#42532) fix(NA): dont clean dll module if it is a package json file (elastic#42904) [Logs UI] Add link from the sample web logs to the Logs UI (elastic#42635) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ability to convert a single metric job to a multi metric job mid as the using is configuring it.
Adds an object to
mlJobServicefor temporarily storing the job and datafeed objects when switching over to the multi metric wizard. This is similar to thecurrentJobobject which is used for cloning. When the advanced job wizard is converted to react, thecurrentJobobject will be removed andtempJobCloningObjectswill be used for all cloning operations.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers