[Logs UI] Disable flaky log column reorder test#42285
Merged
Zacqary merged 1 commit intoelastic:masterfrom Jul 30, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/infra-logs-ui |
spalger
approved these changes
Jul 30, 2019
Contributor
spalger
left a comment
There was a problem hiding this comment.
Recent failure after the fix was merged: https://kibana-ci.elastic.co/job/elastic+kibana+7.x/JOB=x-pack-firefoxSmoke,node=linux-immutable/1265/console
Happy to test out future fixes @Zacqary!
weltenwort
approved these changes
Jul 30, 2019
Member
weltenwort
left a comment
There was a problem hiding this comment.
thanks for doing this, LGTM once CI is green
spalger
reviewed
Jul 30, 2019
| expect(columnHeaderLabels).to.eql(['host.name', 'Timestamp', '']); | ||
| // TODO: make test more robust | ||
| // expect(columnHeaderLabels).to.eql(['host.name', 'Timestamp', '']); | ||
| expect(columnHeaderLabels).to.eql(['Timestamp', 'host.name', '']); |
Contributor
There was a problem hiding this comment.
Do we want this assertion?
Contributor
Author
There was a problem hiding this comment.
That assertion is for the test to see if log columns can successfully be added. It's not flaky since it's not a drag-and-drop/keyboard interaction like the reordering is.
Contributor
💚 Build Succeeded |
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Jul 30, 2019
Zacqary
added a commit
that referenced
this pull request
Jul 30, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 31, 2019
…-or-edit-existing-rollup-job * 'master' of github.com:elastic/kibana: (114 commits) [ML] Fixing empty index pattern list (elastic#42299) [Markdown] Shim new platform - cleanup plugin (elastic#41760) [Code] Enable hierarchicalDocumentSymbolSupport for java language server (elastic#42233) Add New Platform mocks for data plugin (elastic#42261) Http server route handler implementation (elastic#41894) [SR] Allow custom index pattern to be used instead of selectable list when choosing indices to restore (elastic#41534) [Code] distributed Code abstraction (elastic#41374) [SIEM] Sets page titles to the current page you are on (elastic#42157) Saved Objects export API stable type order (elastic#42310) cancellation of interpreter execution (elastic#40238) [SIEM] Fixes a crash when Machine Learning influencers is an undefined value (elastic#42198) Changed the job to work with a dedicated index (elastic#42297) FTR: fix testSubjects.missingOrFail (elastic#42290) Increase retry timeout to prevent flaky tests (elastic#42291) Spaces - make space a hidden saved object type (elastic#41688) Allow applications to register feature privileges which are excluded from the base privileges (elastic#41300) Disable flaky log column reorder test (elastic#42285) Fixing add element in element reducer (elastic#42276) Fix infinite loop (elastic#42228) [Maps][File upload] Remove geojson deep clone logic, handle on maps side (elastic#41835) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the re-enabling of the log column reorder test in #41777. It unfortunately did not help #41749.