[Logs UI] Increase keypress delay in functional tests#41777
Merged
Zacqary merged 10 commits intoelastic:masterfrom Jul 29, 2019
Merged
[Logs UI] Increase keypress delay in functional tests#41777Zacqary merged 10 commits intoelastic:masterfrom
Zacqary merged 10 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/infra-logs-ui |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
Contributor
Author
|
Trying to make sure this test isn't flaky so I'm about to retest again |
Contributor
Author
|
retest [EDIT: retesting again below because a different test flaked] |
Contributor
Author
|
retest |
weltenwort
approved these changes
Jul 25, 2019
Member
weltenwort
left a comment
There was a problem hiding this comment.
LGTM - I can't think of a different option that wouldn't introduce other problems in turn.
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Member
|
well, at least we're getting more confirmation that the test in question doesn't fail 😉 |
Member
|
we'll probably have to merge |
…-reduce-flakiness
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
…-reduce-flakiness
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💚 Build Succeeded |
Zacqary
added a commit
to Zacqary/kibana
that referenced
this pull request
Jul 29, 2019
* [Logs UI] Increase keypress delay in functional tests * Re-enable moveLogColumn test * Use charByChar instead of arbitrary key delays * Remove contradictory expect statement * Revert to 500ms keypress delay
Zacqary
added a commit
that referenced
this pull request
Jul 29, 2019
This was referenced Jul 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
May help #41749; confirm before closing this issue
Increases the delay betweenpressKeyscalls in the functional test for reordering log columns. This will hopefully reduce the flakiness of this test on CI, whereas on desktop a 100ms delay seems to work consistently.In the functional test for reordering log columns, uses the
charByCharAPI ofpressKeysto execute key presses in a sequence, which seems to include some provisions to retry keypresses on the CI. This will hopefully reduce the flakiness of this test.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorialsFor maintainers