docs(streams): update Discovery settings labels and help text#258328
Merged
ruflin merged 3 commits intoelastic:mainfrom Mar 18, 2026
Merged
docs(streams): update Discovery settings labels and help text#258328ruflin merged 3 commits intoelastic:mainfrom
ruflin merged 3 commits intoelastic:mainfrom
Conversation
- Rename "Knowledge indicator extraction" to "Knowledge Indicator feature extraction" - Rename "Rule generation" to "Knowledge Indicator Query generation" - Update help text for Discovery model and KI query generation
crespocarlos
approved these changes
Mar 18, 2026
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates UI text labels and help descriptions in the Significant Events Discovery settings component to reflect updated terminology around Knowledge Indicator features. All changes are string literal updates with no modifications to control flow or data handling. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@x-pack/platform/plugins/shared/streams_app/public/components/significant_events_discovery/components/settings/tab.tsx`:
- Around line 244-245: Update the i18n defaultMessage strings in the Significant
Events settings tab to use the canonical plural "Significant Events" and ensure
help text ends with terminal punctuation: replace occurrences like 'Discovery &
Significant Event generation' (in the JSX i18n entries inside tab.tsx, e.g., the
label/defaultMessage and the help/defaultMessage in the settings Tab component)
with 'Discovery & Significant Events generation' and add a period at the end of
the help text defaultMessage; search for other nearby defaultMessage instances
in this file (the entries around the current block) and apply the same
pluralization and punctuation consistently.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: ff8a0d72-d47c-4bc6-ae9e-7ede08791bc9
📒 Files selected for processing (1)
x-pack/platform/plugins/shared/streams_app/public/components/significant_events_discovery/components/settings/tab.tsx
Comment on lines
+244
to
245
| { defaultMessage: 'Discovery & Significant Event generation' } | ||
| )} |
Contributor
There was a problem hiding this comment.
Use the canonical “Significant Events” term in these i18n strings.
Line 244 and Line 250 use singular “Significant Event”. Please use “Significant Events” consistently in user-facing text here (and add terminal punctuation for the help text).
💬 Suggested text update
label={i18n.translate(
'xpack.streams.significantEventsDiscovery.settings.discoveryLabel',
- { defaultMessage: 'Discovery & Significant Event generation' }
+ { defaultMessage: 'Discovery & Significant Events generation' }
)}
helpText={i18n.translate(
'xpack.streams.significantEventsDiscovery.settings.discoveryHelp',
{
defaultMessage:
- 'Model used during Discovery phase and Significant Event generation',
+ 'Model used during Discovery phase and Significant Events generation.',
}
)}Based on learnings: In Streams app user-facing i18n defaultMessage strings, the term must be written as “Significant Events” (title case).
Also applies to: 249-250
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@x-pack/platform/plugins/shared/streams_app/public/components/significant_events_discovery/components/settings/tab.tsx`
around lines 244 - 245, Update the i18n defaultMessage strings in the
Significant Events settings tab to use the canonical plural "Significant Events"
and ensure help text ends with terminal punctuation: replace occurrences like
'Discovery & Significant Event generation' (in the JSX i18n entries inside
tab.tsx, e.g., the label/defaultMessage and the help/defaultMessage in the
settings Tab component) with 'Discovery & Significant Events generation' and add
a period at the end of the help text defaultMessage; search for other nearby
defaultMessage instances in this file (the entries around the current block) and
apply the same pluralization and punctuation consistently.
Contributor
💛 Build succeeded, but was flaky
Failed CI Steps
Test Failures
Metrics [docs]Async chunks
cc @ruflin |
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Mar 18, 2026
…d_agent_navigation2 * commit 'b511b784a89644463497411bc8cfac03522d43a9': (40 commits) skip failing test suite (elastic#252959) skip failing test suite (elastic#255548) skip failing test suite (elastic#256140) skip failing test suite (elastic#257103) skip failing test suite (elastic#258148) [SharedUX] Add solution view switch callout to spaces plugin (elastic#258093) skip tests consistently failing on ECH (elastic#258157) [EDR Workflows][Osquery] Disable tags for scheduled queries (elastic#258222) [Security solution][Attacks] Add navigation E2E test (elastic#255373) [canvas] fix unable to load embeddable when no references are provided (elastic#257779) docs(streams): update Discovery settings labels and help text (elastic#258328) [ResponseOps] Fixes x-pack/platform/test/alerting_api_integration/spaces_only/tests/alerting/group4/alert_severity.ts flaky test (elastic#258226) [Lens as Code] Fix legend truncation issues (elastic#258216) Upgraded flatted (elastic#258252) [One Discover][Logs UX] Update OpenTelemetry Semantic Conventions (elastic#256613) add Agent Builder compatibility to connectors (elastic#257491) [Obs AI] Add o11y data-generators (OpenRCA and RCAEval) for producing logs, metrics, traces (elastic#256591) [One Workflow] Update execution history UI: show nested workflows steps (elastic#257352) [One Workflow] bulkUpdateSchedules should be called with request to follow auth (elastic#258150) [Agent Builder] Semantic Meta Layer (elastic#254849) ...
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Mar 18, 2026
…c#258328) - Rename "Knowledge indicator extraction" to "Knowledge Indicator feature extraction" - Rename "Rule generation" to "Knowledge Indicator Query generation" - Update help text for Discovery model and KI query generation
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Mar 26, 2026
…c#258328) - Rename "Knowledge indicator extraction" to "Knowledge Indicator feature extraction" - Rename "Rule generation" to "Knowledge Indicator Query generation" - Update help text for Discovery model and KI query generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit