[Agent Builder] Semantic Meta Layer#254849
Merged
ppisljar merged 46 commits intoelastic:mainfrom Mar 18, 2026
Merged
Conversation
3d377c8 to
66e7714
Compare
66e7714 to
61cfb21
Compare
… into agentbuilder/sml_2
9cda943 to
50d92f4
Compare
…ilder/sml_2 # Conflicts: # x-pack/platform/plugins/shared/agent_builder/server/services/sml/sml_task_definitions.ts
mdbirnstiehl
approved these changes
Mar 17, 2026
pgayvallet
approved these changes
Mar 17, 2026
pmuellr
requested changes
Mar 17, 2026
Contributor
pmuellr
left a comment
There was a problem hiding this comment.
LGTM, but requesting you use the provided AbortController in your code to handle TM cancelling the task.
| maxAttempts: 3, | ||
| priority: TaskPriority.Low, | ||
| createTaskRunner: (context) => { | ||
| const { taskInstance } = context; |
Contributor
There was a problem hiding this comment.
context also provides an AbortController, which you should use in the task executor, for cases where task manager needs to cancel the task (for instance, when it times out). You can then remove the cancel() method. The AC's signal can be passed into ES calls, or checked explicitly in your code for loops, etc.
Contributor
💔 Build Failed
Failed CI Steps
Metrics [docs]
History
|
pmuellr
approved these changes
Mar 18, 2026
Contributor
pmuellr
left a comment
There was a problem hiding this comment.
LGTM, thanks for the change!
szwarckonrad
pushed a commit
to szwarckonrad/kibana
that referenced
this pull request
Mar 18, 2026
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Mar 18, 2026
…d_agent_navigation2 * commit 'b511b784a89644463497411bc8cfac03522d43a9': (40 commits) skip failing test suite (elastic#252959) skip failing test suite (elastic#255548) skip failing test suite (elastic#256140) skip failing test suite (elastic#257103) skip failing test suite (elastic#258148) [SharedUX] Add solution view switch callout to spaces plugin (elastic#258093) skip tests consistently failing on ECH (elastic#258157) [EDR Workflows][Osquery] Disable tags for scheduled queries (elastic#258222) [Security solution][Attacks] Add navigation E2E test (elastic#255373) [canvas] fix unable to load embeddable when no references are provided (elastic#257779) docs(streams): update Discovery settings labels and help text (elastic#258328) [ResponseOps] Fixes x-pack/platform/test/alerting_api_integration/spaces_only/tests/alerting/group4/alert_severity.ts flaky test (elastic#258226) [Lens as Code] Fix legend truncation issues (elastic#258216) Upgraded flatted (elastic#258252) [One Discover][Logs UX] Update OpenTelemetry Semantic Conventions (elastic#256613) add Agent Builder compatibility to connectors (elastic#257491) [Obs AI] Add o11y data-generators (OpenRCA and RCAEval) for producing logs, metrics, traces (elastic#256591) [One Workflow] Update execution history UI: show nested workflows steps (elastic#257352) [One Workflow] bulkUpdateSchedules should be called with request to follow auth (elastic#258150) [Agent Builder] Semantic Meta Layer (elastic#254849) ...
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Mar 18, 2026
jeramysoucy
pushed a commit
to jeramysoucy/kibana
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
semantic meta layer as described in https://docs.google.com/document/d/10ZlcUZhrnxpWc6NDgv1YIXIUxc6AtNVhTpto_yQl9PU/edit?tab=t.lyibq72c0c35#heading=h.oh536kry7bqw
resolves https://github.com/elastic/search-team/issues/13210
sml.mov