[Lens API] ESQL schema for XY separately for Agent and some small token optimizations#256885
Merged
mbondyra merged 8 commits intoelastic:mainfrom Mar 11, 2026
Merged
[Lens API] ESQL schema for XY separately for Agent and some small token optimizations#256885mbondyra merged 8 commits intoelastic:mainfrom
mbondyra merged 8 commits intoelastic:mainfrom
Conversation
joemcelroy
approved these changes
Mar 10, 2026
markov00
approved these changes
Mar 10, 2026
src/platform/packages/shared/kbn-lens-embeddable-utils/config_builder/schema/charts/xy.ts
Outdated
Show resolved
Hide resolved
…builder/schema/charts/xy.ts Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
mbondyra
commented
Mar 10, 2026
| } | ||
| \`\`\` | ||
|
|
||
| ${additionalContext}`, |
Contributor
Author
There was a problem hiding this comment.
there was an ugly undefined sent to the agent here.
mbondyra
commented
Mar 10, 2026
| const USEFUL_DESCRIPTION_RE = | ||
| /(\d|default|e\.g\.|i\.e\.|example|must|between|minimum|maximum|at least|at most|up to|pixels|millisecond|factor|typical|legacy|truncat)/i; | ||
|
|
||
| const trimSchemaDescriptions = (node: unknown): unknown => { |
Contributor
Author
There was a problem hiding this comment.
most of the descriptions are very redundant and we can save around 1.5k tokens just getting rid of them.
mbondyra
commented
Mar 10, 2026
...platform/plugins/shared/agent_builder_platform/server/skills/visualization_creation_skill.ts
Outdated
Show resolved
Hide resolved
mbondyra
commented
Mar 10, 2026
| ); | ||
|
|
||
| // TODO: temporary ESQL schema for XY chart to not feed agent with heavy schema for DSL that is not used in agent | ||
| export const xyStateSchemaESQL = schema.object( |
Contributor
Author
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Mar 11, 2026
…e_fix * commit '565f7545c422192218b803874fbdf93e8d8f08ee': (27 commits) [Lens API] ESQL schema for XY separately for Agent and some small token optimizations (elastic#256885) Fix "Accessing resource attributes before async attributes settled" telemetry error (elastic#256880) [Security Solution][Attacks/Alerts][Attacks page][Table section] Preserver "Sort by" state on Attacks page (elastic#256717) (elastic#256795) [APM] Improve redirect with default date range guard (elastic#256887) [Security Solution][Attacks/Alerts][Attacks page][Table section] Add assignees avatars to the group component (elastic#250126) (elastic#256901) [Docs] add xpack.alerting.rules.maxScheduledPerMinute setting description (elastic#257041) [SO] Fix non-deterministic ordering in nested find API integration tests (elastic#256447) [Write-restricted dashboards] Update user profile retrieval for getShouldAddAccessControl (elastic#255065) [One Workflow] Add Scout API test scaffold and execution tests (elastic#256300) [Fleet] add use_apm if dynamic_signal_types are enabled (elastic#256429) [Fleet] ignore data streams starting with `.` in Fleet API (elastic#256625) [ES|QL] METRICS_INFO support: columns_after & summary (elastic#256758) [Agent Builder] Agent plugins: initial installation support (elastic#256478) [Streams] Add field descriptions and documentation-only field overrides (elastic#255136) [api-docs] 2026-03-11 Daily api_docs build (elastic#257023) [Security Solution] fix alerts page infinite loading state due to data view error (elastic#256983) [Logging] Add `service.*` global fields (elastic#256878) [Canvas] Apply embeddable transforms to embeddable elements (elastic#252191) [table_list_view_table] stabilize jest test (elastic#254991) [Obs AI] get_index_info: add unit tests (elastic#256802) ...
sorenlouv
pushed a commit
that referenced
this pull request
Mar 17, 2026
…en optimizations (#256885) ## Summary Right now we send the entire schema to the agent, which ends up being confusing for it—first, because it includes parts that aren’t actually supported (like reference layers or multilayer charts), and second, because in practice we can only use the ESQL data layer anyway. So I extracted just the ESQL-relevant part of the schema (which also saves ~8k input tokens on each visualization creation). It’s a small change on your side, and it’s only used by the agent. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Right now we send the entire schema to the agent, which ends up being confusing for it—first, because it includes parts that aren’t actually supported (like reference layers or multilayer charts), and second, because in practice we can only use the ESQL data layer anyway.
So I extracted just the ESQL-relevant part of the schema (which also saves ~8k input tokens on each visualization creation). It’s a small change on your side, and it’s only used by the agent.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.