Fix "Accessing resource attributes before async attributes settled" telemetry error#256880
Merged
mbondyra merged 5 commits intoelastic:mainfrom Mar 11, 2026
Merged
Fix "Accessing resource attributes before async attributes settled" telemetry error#256880mbondyra merged 5 commits intoelastic:mainfrom
mbondyra merged 5 commits intoelastic:mainfrom
Conversation
Contributor
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
|
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Mar 11, 2026
…e_fix * commit '565f7545c422192218b803874fbdf93e8d8f08ee': (27 commits) [Lens API] ESQL schema for XY separately for Agent and some small token optimizations (elastic#256885) Fix "Accessing resource attributes before async attributes settled" telemetry error (elastic#256880) [Security Solution][Attacks/Alerts][Attacks page][Table section] Preserver "Sort by" state on Attacks page (elastic#256717) (elastic#256795) [APM] Improve redirect with default date range guard (elastic#256887) [Security Solution][Attacks/Alerts][Attacks page][Table section] Add assignees avatars to the group component (elastic#250126) (elastic#256901) [Docs] add xpack.alerting.rules.maxScheduledPerMinute setting description (elastic#257041) [SO] Fix non-deterministic ordering in nested find API integration tests (elastic#256447) [Write-restricted dashboards] Update user profile retrieval for getShouldAddAccessControl (elastic#255065) [One Workflow] Add Scout API test scaffold and execution tests (elastic#256300) [Fleet] add use_apm if dynamic_signal_types are enabled (elastic#256429) [Fleet] ignore data streams starting with `.` in Fleet API (elastic#256625) [ES|QL] METRICS_INFO support: columns_after & summary (elastic#256758) [Agent Builder] Agent plugins: initial installation support (elastic#256478) [Streams] Add field descriptions and documentation-only field overrides (elastic#255136) [api-docs] 2026-03-11 Daily api_docs build (elastic#257023) [Security Solution] fix alerts page infinite loading state due to data view error (elastic#256983) [Logging] Add `service.*` global fields (elastic#256878) [Canvas] Apply embeddable transforms to embeddable elements (elastic#252191) [table_list_view_table] stabilize jest test (elastic#254991) [Obs AI] get_index_info: add unit tests (elastic#256802) ...
sorenlouv
pushed a commit
that referenced
this pull request
Mar 17, 2026
…elemetry error (#256880) This has been developed with Cursor, please check carefully. ## Summary - Fixes a race condition in `initTelemetry` where `initTracing` and `initMetrics` were called with a `Resource` whose async detectors (host, OS, env, process) hadn't resolved yet, causing repeated `[ERROR][telemetry] Accessing resource attributes before async attributes settled` errors at startup - Defers tracer/metrics provider initialization until `resource.waitForAsyncAttributes()` resolves, while keeping auto-instrumentations registered synchronously so HTTP context propagation isn't missed ## Details `resources.detectResources()` uses async detectors that return promises. The resulting `Resource` has `asyncAttributesPending = true` until those promises settle. The previous code passed this resource directly to `initTracing()`, which meant: 1. `BaseInferenceSpanProcessor.onEnd` and `PhoenixSpanProcessor.processInferenceSpan` accessed `span.resource.attributes` while promises were still pending 2. OpenTelemetry's `Resource.attributes` getter logged the error and **silently skipped unsettled attribute values**, producing spans with incomplete resource data 3. This could cause exported spans to not appear correctly in Phoenix/Langfuse The fix awaits `resource.waitForAsyncAttributes()` before creating the tracer provider and span processors. Auto-instrumentations (`maybeInitAutoInstrumentations`) remain synchronous since they need to monkey-patch HTTP modules before any requests are made and don't depend on resource attributes. The deferral is safe because inference tracing spans only occur well after Kibana startup (~seconds), while async resource detection resolves in <100ms. ## Test plan - [ ] Start Kibana with `telemetry.tracing.enabled: true` and a Phoenix exporter configured - [ ] Verify no `Accessing resource attributes before async attributes settled` errors in logs - [ ] Trigger an inference call (e.g. via Agent Builder) and verify the trace appears in Phoenix - [ ] Existing unit test (`init_telemetry.test.ts`) continues to pass — it validates `resourceFromAttributes` is called with correct attributes, which still happens synchronously --- --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been developed with Cursor, please check carefully.
Summary
initTelemetrywhereinitTracingandinitMetricswere called with aResourcewhose async detectors (host, OS, env, process) hadn't resolved yet, causing repeated[ERROR][telemetry] Accessing resource attributes before async attributes settlederrors at startupresource.waitForAsyncAttributes()resolves, while keeping auto-instrumentations registered synchronously so HTTP context propagation isn't missedDetails
resources.detectResources()uses async detectors that return promises. The resultingResourcehasasyncAttributesPending = trueuntil those promises settle. The previous code passed this resource directly toinitTracing(), which meant:BaseInferenceSpanProcessor.onEndandPhoenixSpanProcessor.processInferenceSpanaccessedspan.resource.attributeswhile promises were still pendingResource.attributesgetter logged the error and silently skipped unsettled attribute values, producing spans with incomplete resource dataThe fix awaits
resource.waitForAsyncAttributes()before creating the tracer provider and span processors. Auto-instrumentations (maybeInitAutoInstrumentations) remain synchronous since they need to monkey-patch HTTP modules before any requests are made and don't depend on resource attributes. The deferral is safe because inference tracing spans only occur well after Kibana startup (~seconds), while async resource detection resolves in <100ms.Test plan
telemetry.tracing.enabled: trueand a Phoenix exporter configuredAccessing resource attributes before async attributes settlederrors in logsinit_telemetry.test.ts) continues to pass — it validatesresourceFromAttributesis called with correct attributes, which still happens synchronously