[Obs Presentation] Code Scanning Alert Fixes#250858
Merged
rmyz merged 9 commits intoelastic:mainfrom Jan 30, 2026
Merged
Conversation
Contributor
Author
|
/ci |
rmyz
commented
Jan 29, 2026
| serviceName: schema.maybe(schema.string()), | ||
| environment: schema.string(), | ||
| groupBy: schema.maybe(schema.arrayOf(schema.string())), | ||
| groupBy: schema.maybe(schema.arrayOf(schema.string(), { maxSize: 10 })), |
Contributor
Author
There was a problem hiding this comment.
UI max is 5 (2 preselected + 3 selectable), using 10 as buffer just in case
rmyz
commented
Jan 29, 2026
| ]), | ||
| environment: schema.string(), | ||
| groupBy: schema.maybe(schema.arrayOf(schema.string())), | ||
| groupBy: schema.maybe(schema.arrayOf(schema.string(), { maxSize: 10 })), |
Contributor
Author
There was a problem hiding this comment.
UI max is 4 (3 preselected + 1 selectable), using 10 as a buffer just in case
rmyz
commented
Jan 29, 2026
| schema.literal(ML_ANOMALY_SEVERITY.WARNING), | ||
| ]), | ||
| anomalyDetectorTypes: schema.maybe(schema.arrayOf(detectorsSchema, { minSize: 1 })), | ||
| anomalyDetectorTypes: schema.maybe(schema.arrayOf(detectorsSchema, { minSize: 1, maxSize: 3 })), |
Contributor
Author
There was a problem hiding this comment.
Only 3 detector types exist in the schema
rmyz
commented
Jan 29, 2026
| serviceName: schema.maybe(schema.string()), | ||
| environment: schema.string(), | ||
| groupBy: schema.maybe(schema.arrayOf(schema.string())), | ||
| groupBy: schema.maybe(schema.arrayOf(schema.string(), { maxSize: 10 })), |
Contributor
Author
There was a problem hiding this comment.
UI max is 4 (3 preselected + 1 selectable), using 10 as a buffer just in case
Contributor
Author
|
/ci |
…tion_tests/ci_checks
Contributor
Author
|
/ci |
rmyz
commented
Jan 29, 2026
| timeTo: schema.number(), | ||
| functionName: schema.string(), | ||
| serviceNames: schema.arrayOf(schema.string()), | ||
| serviceNames: schema.arrayOf(schema.string(), { maxSize: 10 }), |
Contributor
Author
There was a problem hiding this comment.
The frontend is limited at 5 services per page, 10 as a buffer just in case
Contributor
|
Pinging @elastic/obs-presentation-team (Team:obs-presentation) |
Contributor
Author
|
/ci |
x-pack/solutions/security/plugins/entity_store/test/scout/api/tests/entity_extraction.spec.ts
Outdated
Show resolved
Hide resolved
Contributor
💔 Build Failed
Failed CI StepsHistory
cc @rmyz |
crespocarlos
approved these changes
Jan 30, 2026
Contributor
|
Starting backport for target branches: 9.2, 9.3 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 30, 2026
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 21943ce)
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 30, 2026
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 21943ce)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 30, 2026
# Backport This will backport the following commits from `main` to `9.3`: - [[Obs Presentation] Code Scanning Alert Fixes (#250858)](#250858) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2026-01-30T08:34:17Z","message":"[Obs Presentation] Code Scanning Alert Fixes (#250858)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"21943ce862db47dcc7d600a7fec81d941d374265","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.4.0","Team:obs-presentation","v9.2.5","v9.3.1"],"title":"[Obs Presentation] Code Scanning Alert Fixes","number":250858,"url":"https://github.com/elastic/kibana/pull/250858","mergeCommit":{"message":"[Obs Presentation] Code Scanning Alert Fixes (#250858)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"21943ce862db47dcc7d600a7fec81d941d374265"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.3"],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/250858","number":250858,"mergeCommit":{"message":"[Obs Presentation] Code Scanning Alert Fixes (#250858)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"21943ce862db47dcc7d600a7fec81d941d374265"}},{"branch":"9.2","label":"v9.2.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.3","label":"v9.3.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jan 30, 2026
# Backport This will backport the following commits from `main` to `9.2`: - [[Obs Presentation] Code Scanning Alert Fixes (#250858)](#250858) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"sergi.romeu@elastic.co"},"sourceCommit":{"committedDate":"2026-01-30T08:34:17Z","message":"[Obs Presentation] Code Scanning Alert Fixes (#250858)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"21943ce862db47dcc7d600a7fec81d941d374265","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.4.0","Team:obs-presentation","v9.2.5","v9.3.1"],"title":"[Obs Presentation] Code Scanning Alert Fixes","number":250858,"url":"https://github.com/elastic/kibana/pull/250858","mergeCommit":{"message":"[Obs Presentation] Code Scanning Alert Fixes (#250858)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"21943ce862db47dcc7d600a7fec81d941d374265"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.3"],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/250858","number":250858,"mergeCommit":{"message":"[Obs Presentation] Code Scanning Alert Fixes (#250858)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"21943ce862db47dcc7d600a7fec81d941d374265"}},{"branch":"9.2","label":"v9.2.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.3","label":"v9.3.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Romeu <sergi.romeu@elastic.co>
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Jan 30, 2026
…iew_cps * commit '5f7fec57cb01883038810bd735a0666683b49904': (116 commits) [Security Solution][Attacks/Alerts][Setup and miscellaneous] Advanced setting to control feature visibility (elastic#250157) (elastic#250830) Fix synthtrace `fetch` usage (elastic#250950) [APM] Add Nodes and Edges components and selection logic (elastic#250937) [Docs] Update alerting-settings.md and add serverless value for one parameter (elastic#250842) [Agent Builder] filestore: initial implementation (elastic#250043) [CPS] Support CPS in Vega ESQL (elastic#250693) Adjustments to cascade document esql helpers (elastic#250560) [Security Solutions] Trial Companion - adds ai chat and elastic agent detectors (elastic#250908) [Obs Presentation] Code Scanning Alert Fixes (elastic#250858) [performance] add return and refresh render scenarios to dashboard journeys (elastic#250939) skip failing test suite (elastic#245458) Add Cloud Forwarder onboarding tile to O11y Solution (elastic#250325) [Traces] Remove APM unified trace waterall embeddable registration (elastic#250808) [Discover] [Metrics] Fix: metrics grid titles do not update on order change (elastic#250963) [a11y] Fix Eui modal title annoucment (elastic#250459) [Cloud Security] [Fleet] Add cloud connector access scope for input or package level credential definitions (elastic#250280) [WorkplaceAI] SharePoint Online stack connector (elastic#248737) [Response Ops][Task Manager] Update functions do not handle API key invalidation (elastic#249109) [Osquery] Remove @kbn/timelines-plugin dependency from osquery plugin (elastic#250055) [One Discover][Logs UX] Update OpenTelemetry Semantic Conventions (elastic#250346) ...
hannahbrooks
pushed a commit
to hannahbrooks/kibana
that referenced
this pull request
Jan 30, 2026
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the code-scanning alerts by adding
maxSizeto our array params.