Skip to content

Adjustments to cascade document esql helpers#250560

Merged
eokoneyo merged 1 commit intoelastic:mainfrom
eokoneyo:chore/cascade-document-helpers-changes
Jan 30, 2026
Merged

Adjustments to cascade document esql helpers#250560
eokoneyo merged 1 commit intoelastic:mainfrom
eokoneyo:chore/cascade-document-helpers-changes

Conversation

@eokoneyo
Copy link
Copy Markdown
Contributor

@eokoneyo eokoneyo commented Jan 27, 2026

Summary

Response to #250402

  • This PR makes changes so that any STATS command that specifies a categorize grouping function that specifies a function argument doesn't qualify for the cascade experience, for example the command below;
     FROM kibana_sample_data_logs
    | STATS AVG(bytes) BY CATEGORIZE(to_upper(event.dataset))
    
    would not trigger the cascade experience.
  • Furthermore any query that also specifies a grouping function that is not supported in any combination would not result in a cascade experience, for example the command below;
     FROM kibana_sample_data_logs | STATS COUNT() BY col1 = BUCKET(@timestamp, 50, ?_tstart, ?_tend), extension.keyword
    
    would not trigger the cascade experience.

P.S. Also in this PR the utils used by the cascaded document helpers have been split out into a separate file.

@eokoneyo eokoneyo self-assigned this Jan 27, 2026
@eokoneyo eokoneyo added release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// labels Jan 27, 2026
@eokoneyo eokoneyo force-pushed the chore/cascade-document-helpers-changes branch from 98f1bbd to bcabce0 Compare January 27, 2026 11:51
@eokoneyo
Copy link
Copy Markdown
Contributor Author

/ci

1 similar comment
@eokoneyo
Copy link
Copy Markdown
Contributor Author

/ci

@eokoneyo eokoneyo force-pushed the chore/cascade-document-helpers-changes branch from 7306720 to eb244d4 Compare January 28, 2026 08:46
@eokoneyo
Copy link
Copy Markdown
Contributor Author

/ci

@eokoneyo eokoneyo marked this pull request as ready for review January 28, 2026 11:57
@eokoneyo eokoneyo requested review from a team as code owners January 28, 2026 11:57
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@eokoneyo eokoneyo added the (do not use) backport:9.3 This doesn't do backports! use `backport:version` `v9.3.0` instead label Jan 28, 2026
Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Eyo, it is significantly more cleaner now! LGTM (code review only)

@eokoneyo eokoneyo force-pushed the chore/cascade-document-helpers-changes branch 2 times, most recently from 794b9e4 to fa88f18 Compare January 29, 2026 11:58
@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner January 29, 2026 12:30
@eokoneyo
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 29, 2026

💔 Build Failed

Failed CI Steps

History

cc @eokoneyo

@eokoneyo eokoneyo force-pushed the chore/cascade-document-helpers-changes branch from b9e6014 to 2e292d2 Compare January 29, 2026 14:27
@eokoneyo eokoneyo changed the title adjustments to cascade document esql helpers Adjustments to cascade document esql helpers Jan 29, 2026
@eokoneyo eokoneyo removed the request for review from a team January 29, 2026 15:38
Copy link
Copy Markdown
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple import changes in Discover, but I tested both scenarios locally and they work as described. Thanks @eokoneyo!

@eokoneyo eokoneyo merged commit 96d8f2c into elastic:main Jan 30, 2026
16 checks passed
@eokoneyo eokoneyo deleted the chore/cascade-document-helpers-changes branch January 30, 2026 08:51
mbondyra added a commit to mbondyra/kibana that referenced this pull request Jan 30, 2026
…iew_cps

* commit '5f7fec57cb01883038810bd735a0666683b49904': (116 commits)
  [Security Solution][Attacks/Alerts][Setup and miscellaneous] Advanced setting to control feature visibility (elastic#250157) (elastic#250830)
  Fix synthtrace `fetch` usage (elastic#250950)
  [APM] Add Nodes and Edges components and selection logic (elastic#250937)
  [Docs] Update alerting-settings.md and add serverless value for one parameter (elastic#250842)
  [Agent Builder] filestore: initial implementation (elastic#250043)
  [CPS] Support CPS in Vega ESQL (elastic#250693)
  Adjustments to cascade document esql helpers (elastic#250560)
  [Security Solutions] Trial Companion - adds ai chat and elastic agent detectors (elastic#250908)
  [Obs Presentation] Code Scanning Alert Fixes (elastic#250858)
  [performance] add return and refresh render scenarios to dashboard journeys (elastic#250939)
  skip failing test suite (elastic#245458)
  Add Cloud Forwarder onboarding tile to O11y Solution (elastic#250325)
  [Traces] Remove APM unified trace waterall embeddable registration (elastic#250808)
  [Discover] [Metrics] Fix: metrics grid titles do not update on order change (elastic#250963)
  [a11y] Fix Eui modal title annoucment (elastic#250459)
  [Cloud Security] [Fleet] Add cloud connector access scope for input or package level credential definitions (elastic#250280)
  [WorkplaceAI] SharePoint Online stack connector (elastic#248737)
  [Response Ops][Task Manager] Update functions do not handle API key invalidation (elastic#249109)
  [Osquery] Remove @kbn/timelines-plugin dependency from osquery plugin (elastic#250055)
  [One Discover][Logs UX] Update OpenTelemetry Semantic Conventions (elastic#250346)
  ...
hannahbrooks pushed a commit to hannahbrooks/kibana that referenced this pull request Jan 30, 2026
## Summary

Response to elastic#250402

- This PR makes changes so that any STATS command that specifies a
`categorize` grouping function that specifies a function argument
doesn't qualify for the cascade experience, for example the command
below;
	```
	FROM kibana_sample_data_logs
  | STATS AVG(bytes) BY CATEGORIZE(to_upper(event.dataset))
	```
	would not trigger the cascade experience.
- Furthermore any query that also specifies a grouping function that is
not supported in any combination would not result in a cascade
experience, for example the command below;
	```
FROM kibana_sample_data_logs | STATS COUNT() BY col1 =
BUCKET(@timestamp, 50, ?_tstart, ?_tend), extension.keyword
	```
	would not trigger the cascade experience.
	

_P.S. Also in this PR the utils used by the cascaded document helpers
have been split out into a separate file._

<!--
### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...

-->
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 2, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 250560 locally
cc: @eokoneyo

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 250560 locally
cc: @eokoneyo

@eokoneyo eokoneyo removed backport missing Added to PRs automatically when the are determined to be missing a backport. (do not use) backport:9.3 This doesn't do backports! use `backport:version` `v9.3.0` instead labels Feb 3, 2026
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants