Adjustments to cascade document esql helpers#250560
Conversation
98f1bbd to
bcabce0
Compare
|
/ci |
1 similar comment
|
/ci |
7306720 to
eb244d4
Compare
|
/ci |
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
stratoula
left a comment
There was a problem hiding this comment.
Thank you Eyo, it is significantly more cleaner now! LGTM (code review only)
794b9e4 to
fa88f18
Compare
|
@elasticmachine merge upstream |
💔 Build Failed
Failed CI StepsHistory
cc @eokoneyo |
b9e6014 to
2e292d2
Compare
davismcphee
left a comment
There was a problem hiding this comment.
Only a couple import changes in Discover, but I tested both scenarios locally and they work as described. Thanks @eokoneyo!
…iew_cps * commit '5f7fec57cb01883038810bd735a0666683b49904': (116 commits) [Security Solution][Attacks/Alerts][Setup and miscellaneous] Advanced setting to control feature visibility (elastic#250157) (elastic#250830) Fix synthtrace `fetch` usage (elastic#250950) [APM] Add Nodes and Edges components and selection logic (elastic#250937) [Docs] Update alerting-settings.md and add serverless value for one parameter (elastic#250842) [Agent Builder] filestore: initial implementation (elastic#250043) [CPS] Support CPS in Vega ESQL (elastic#250693) Adjustments to cascade document esql helpers (elastic#250560) [Security Solutions] Trial Companion - adds ai chat and elastic agent detectors (elastic#250908) [Obs Presentation] Code Scanning Alert Fixes (elastic#250858) [performance] add return and refresh render scenarios to dashboard journeys (elastic#250939) skip failing test suite (elastic#245458) Add Cloud Forwarder onboarding tile to O11y Solution (elastic#250325) [Traces] Remove APM unified trace waterall embeddable registration (elastic#250808) [Discover] [Metrics] Fix: metrics grid titles do not update on order change (elastic#250963) [a11y] Fix Eui modal title annoucment (elastic#250459) [Cloud Security] [Fleet] Add cloud connector access scope for input or package level credential definitions (elastic#250280) [WorkplaceAI] SharePoint Online stack connector (elastic#248737) [Response Ops][Task Manager] Update functions do not handle API key invalidation (elastic#249109) [Osquery] Remove @kbn/timelines-plugin dependency from osquery plugin (elastic#250055) [One Discover][Logs UX] Update OpenTelemetry Semantic Conventions (elastic#250346) ...
## Summary Response to elastic#250402 - This PR makes changes so that any STATS command that specifies a `categorize` grouping function that specifies a function argument doesn't qualify for the cascade experience, for example the command below; ``` FROM kibana_sample_data_logs | STATS AVG(bytes) BY CATEGORIZE(to_upper(event.dataset)) ``` would not trigger the cascade experience. - Furthermore any query that also specifies a grouping function that is not supported in any combination would not result in a cascade experience, for example the command below; ``` FROM kibana_sample_data_logs | STATS COUNT() BY col1 = BUCKET(@timestamp, 50, ?_tstart, ?_tend), extension.keyword ``` would not trigger the cascade experience. _P.S. Also in this PR the utils used by the cascaded document helpers have been split out into a separate file._ <!-- ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... -->
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Summary
Response to #250402
categorizegrouping function that specifies a function argument doesn't qualify for the cascade experience, for example the command below;P.S. Also in this PR the utils used by the cascaded document helpers have been split out into a separate file.