[Dashboard][Controls Anywhere] Move panel placement registry to presentationUtil plugin by Zacqary · Pull Request #246628 · elastic/kibana

Zacqary · 2025-12-16T19:11:05Z

Summary

Moves the panel placement registry from the dashboard plugin into the presentationUtil plugin. This is necessary to avoid circular dependency issues in the Controls Anywhere project.

Background

Controls Anywhere introduces the concept of dashboard controls being rendered as movable panels. For this, we need to define their PanelPlacementStrategy: creating them with a very short height, medium width, and in the top left corner of the dashboard.

This required adding the dashboard plugin as a requiredPlugin for controls.

Unfortunately, #245299 introduced onechat as a dependency to observabilityAIAssistant, triggering this circular dependency cycle:

   │ERROR Detected circular dependencies:
   │ERROR   dashboard -> observabilityAIAssistant -> onechat -> stackConnectors -> triggersActionsUi -> controls -> dashboard
   │ERROR   triggersActionsUi -> controls -> dashboard -> observabilityAIAssistant -> onechat -> triggersActionsUi
   │ERROR   workflowsManagement -> triggersActionsUi -> controls -> dashboard -> observabilityAIAssistant -> onechat -> workflowsManagement
   │ERROR   stackConnectors -> triggersActionsUi -> controls -> dashboard -> observabilityAIAssistant -> onechat -> workflowsManagement -> stackConnectors

Unfortunately, Kibana architecture doesn't have a good way of moving registries into @kbn packages yet, so we need to find a safer plugin for it to live in. We determined that controls and dashboard both depend on the presentationUtil plugin without incident, and it's already a place to put other miscellaneous dashboard-related things.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

into panel-placement-util

Zacqary · 2025-12-16T22:38:07Z

packages/kbn-optimizer/limits.yml

  painlessLab: 6299
  presentationPanel: 11418
-  presentationUtil: 9000
+  presentationUtil: 9948


This PR does increase the size of presentationUtil, but does it by removing code from dashboard, so it's about even

@elastic/kibana-operations As recommended by CI I ran node scripts/build_kibana_platform_plugins --focus presentationUtil --update-limits. I'm not sure if it was supposed to update limits for plugins besides the --focus plugin, but this is what it did.

# Conflicts: # packages/kbn-optimizer/limits.yml

elasticmachine · 2025-12-16T22:39:31Z

Pinging @elastic/kibana-presentation (Team:Presentation)

Heenawter

Left one nit but otherwise LGTM - changes are straightforward. Maybe worth getting @nreese's input on the decision to move this to presentationUtil for some extra confidence - but the code looks good to me, and I tested to ensure that the Links panel still respects its panel placement :)

src/platform/plugins/shared/dashboard/tsconfig.json

elasticmachine · 2025-12-16T23:07:00Z

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

nreese · 2025-12-16T23:25:06Z

Would it make more sense to move the registry to embeddables? Maybe there should be a quick conversation about the best long term place for this registry.

nreese

kibana-presentation changes LGTM
code review only

mgiota

Code review only. LGTM

kibanamachine · 2025-12-18T00:11:16Z

Starting backport for target branches: 9.2

https://github.com/elastic/kibana/actions/runs/20321353487

elasticmachine · 2025-12-18T00:11:39Z

💚 Build Succeeded

Buildkite Build
Commit: 5abcba3

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`dashboard`	998	996	-2
`presentationUtil`	108	111	+3
total			+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`dashboard`	104	100	-4
`presentationUtil`	82	96	+14
total			+10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dashboard`	721.4KB	721.4KB	+75.0B
`links`	99.1KB	99.1KB	+10.0B
total			+85.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`dashboard`	12	11	-1
`presentationUtil`	5	7	+2
total			+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`dashboard`	18.0KB	17.5KB	-584.0B
`links`	7.7KB	7.7KB	+7.0B
`presentationUtil`	8.3KB	8.8KB	+530.0B
`slo`	33.6KB	33.6KB	+14.0B
`synthetics`	29.1KB	29.1KB	+14.0B
total			-19.0B

Unknown metric groups

API count

id	before	after	diff
`dashboard`	106	102	-4
`presentationUtil`	108	122	+14
total			+10

History

cc @Zacqary

kibanamachine · 2025-12-18T00:18:52Z

💔 All backports failed

Status	Branch	Result
❌	9.2	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 246628

Questions ?

Please refer to the Backport tool documentation

… presentationUtil plugin (#246950) # Backport This will backport the following commits from `main` to `9.2`: - [[Dashboard][Controls Anywhere] Move panel placement registry to presentationUtil plugin (#246628)](#246628)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

[Dashboard] Move panel placement registry to presentationUtil plugin

47af4c9

kibanamachine added 2 commits December 16, 2025 19:22

Changes from node scripts/lint_ts_projects --fix

4672092

Changes from node scripts/regenerate_moon_projects.js --update

1162802

Heenawter assigned Zacqary Dec 16, 2025

Zacqary added 3 commits December 16, 2025 14:53

Fix i18n, mocks, example kibana.jsonc

37a67e5

Merge branch 'panel-placement-util' of https://github.com/Zacqary/kibana

ebac345

into panel-placement-util

Increase bundle size limit for presentationUtil

e2208ff

Zacqary commented Dec 16, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/main' into panel-placement-util

fc9ebe6

# Conflicts: # packages/kbn-optimizer/limits.yml

Zacqary marked this pull request as ready for review December 16, 2025 22:39

Zacqary requested review from a team as code owners December 16, 2025 22:39

Heenawter approved these changes Dec 16, 2025

View reviewed changes

src/platform/plugins/shared/dashboard/tsconfig.json Outdated Show resolved Hide resolved

botelastic bot added the Team:obs-ux-management label Dec 16, 2025

Zacqary added backport:version Backport to applied version labels v9.3.0 labels Dec 16, 2025

Revert dashboard tsconfig.json change

cccdba4

jbudz approved these changes Dec 16, 2025

View reviewed changes

nreese approved these changes Dec 17, 2025

View reviewed changes

mgiota approved these changes Dec 17, 2025

View reviewed changes

Zacqary enabled auto-merge (squash) December 17, 2025 16:16

Merge branch 'main' into panel-placement-util

fbdedef

Zacqary added the v9.2.4 label Dec 17, 2025

Fix example plugin kibana.jsonc

5abcba3

Zacqary merged commit 5312bbb into elastic:main Dec 18, 2025
13 checks passed

Heenawter mentioned this pull request Dec 18, 2025

[Controls Anywhere] Feature Branch #245588

Merged

5 tasks

Zacqary mentioned this pull request Dec 18, 2025

[9.2] [Dashboard][Controls Anywhere] Move panel placement registry to presentationUtil plugin #246950

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Dashboard][Controls Anywhere] Move panel placement registry to presentationUtil plugin#246628

[Dashboard][Controls Anywhere] Move panel placement registry to presentationUtil plugin#246628
Zacqary merged 10 commits intoelastic:mainfrom
Zacqary:panel-placement-util

Zacqary commented Dec 16, 2025 •

edited by kibanamachine

Loading

Uh oh!

Zacqary Dec 16, 2025

Uh oh!

elasticmachine commented Dec 16, 2025

Uh oh!

Heenawter left a comment •

edited

Loading

Uh oh!

Uh oh!

elasticmachine commented Dec 16, 2025

Uh oh!

nreese commented Dec 16, 2025

Uh oh!

nreese left a comment

Uh oh!

mgiota left a comment

Uh oh!

Uh oh!

kibanamachine commented Dec 18, 2025

Uh oh!

elasticmachine commented Dec 18, 2025

API count

Uh oh!

kibanamachine commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

Zacqary commented Dec 16, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Background

Checklist

Uh oh!

Zacqary Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Dec 16, 2025

Uh oh!

Heenawter left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticmachine commented Dec 16, 2025

Uh oh!

nreese commented Dec 16, 2025

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

mgiota left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Dec 18, 2025

Uh oh!

elasticmachine commented Dec 18, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

History

Uh oh!

kibanamachine commented Dec 18, 2025

💔 All backports failed

Manual backport

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Zacqary commented Dec 16, 2025 •

edited by kibanamachine

Loading

Heenawter left a comment •

edited

Loading