[9.2] [Dashboard][Controls Anywhere] Move panel placement registry to presentationUtil plugin#246950
Merged
Zacqary merged 2 commits intoelastic:9.2from Dec 18, 2025
Merged
Conversation
…ntationUtil plugin (elastic#246628) Moves the panel placement registry from the `dashboard` plugin into the `presentationUtil` plugin. This is necessary to avoid circular dependency issues in the [Controls Anywhere project](elastic#245588). Controls Anywhere introduces the concept of dashboard controls being rendered as movable panels. For this, we need to define their `PanelPlacementStrategy`: creating them with a very short height, medium width, and in the top left corner of the dashboard. This required adding the `dashboard` plugin as a `requiredPlugin` for `controls`. Unfortunately, elastic#245299 introduced `onechat` as a dependency to `observabilityAIAssistant`, triggering this circular dependency cycle: ``` │ERROR Detected circular dependencies: │ERROR dashboard -> observabilityAIAssistant -> onechat -> stackConnectors -> triggersActionsUi -> controls -> dashboard │ERROR triggersActionsUi -> controls -> dashboard -> observabilityAIAssistant -> onechat -> triggersActionsUi │ERROR workflowsManagement -> triggersActionsUi -> controls -> dashboard -> observabilityAIAssistant -> onechat -> workflowsManagement │ERROR stackConnectors -> triggersActionsUi -> controls -> dashboard -> observabilityAIAssistant -> onechat -> workflowsManagement -> stackConnectors ``` Unfortunately, Kibana architecture doesn't have a good way of moving registries into `@kbn` packages yet, so we need to find a safer plugin for it to live in. We determined that `controls` and `dashboard` both depend on the `presentationUtil` plugin without incident, and it's already a place to put other miscellaneous dashboard-related things. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
nickpeihl
reviewed
Dec 18, 2025
| import { DASHBOARD_APP_ID, LANDING_PAGE_PATH, SEARCH_SESSION_ID } from '../common/constants'; | ||
| import type { GetPanelPlacementSettings } from './panel_placement'; | ||
| import { registerDashboardPanelSettings } from './panel_placement'; | ||
| import type { FindDashboardsService } from './services/dashboard_content_management_service/types'; |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.2:Questions ?
Please refer to the Backport tool documentation