Skip to content

[Security Solution] Update Security Roles with new Rules RBAC permissions#245576

Merged
rylnd merged 6 commits intoelastic:mainfrom
rylnd:rules-rbac-role-updates-rebased
Dec 11, 2025
Merged

[Security Solution] Update Security Roles with new Rules RBAC permissions#245576
rylnd merged 6 commits intoelastic:mainfrom
rylnd:rules-rbac-role-updates-rebased

Conversation

@rylnd
Copy link
Copy Markdown
Contributor

@rylnd rylnd commented Dec 8, 2025

Summary

With #239634 in main and the build being green, we have demonstrated the correct behavior for existing users with existing kibana privileges. This PR now updates existing test/prebuilt roles to explicitly use these new privileges moving forward.

Reference

  • Discussion about the benefits/logic for this PR can be found here.
  • Accompanying elasticsearch-controller PR can be found here.

Checklist

  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

denar50 and others added 2 commits December 8, 2025 15:55
This updates prebuilt roles and those used in tests to:

* Reference siemv5 instead of the older siemv4
* Add the new `rules:read` or `rules:all` feature where appropriate

Without this change, our tests are implicitly testing the
`replacedBy`/"migration" path that existing users will follow. With that
version of the code being green, we can have confidence in the behavior
for existing users, and can then update our tests to use the latest
features, here.
@rylnd rylnd self-assigned this Dec 8, 2025
@rylnd rylnd added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Detection Alerts/Rules RBAC Security Solution RBAC for rules and alerts Team:Detection Engine Security Solution Detection Engine Area v9.3.0 labels Dec 8, 2025
@rylnd rylnd marked this pull request as ready for review December 8, 2025 22:06
@rylnd rylnd requested review from a team as code owners December 8, 2025 22:06
@rylnd rylnd requested review from ashokaditya and tomsonpl December 8, 2025 22:06
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

This reverts commit ac4378d.

Testing to see whether this change is what's causing our current CI
failures.
Copy link
Copy Markdown
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, LGTM for the @elastic/security-threat-hunting team

Copy link
Copy Markdown
Contributor

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roles update in kbn/es LGTM

@rylnd rylnd enabled auto-merge (squash) December 11, 2025 00:01
@rylnd rylnd merged commit e812038 into elastic:main Dec 11, 2025
12 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

cc @rylnd

@rylnd rylnd deleted the rules-rbac-role-updates-rebased branch December 11, 2025 03:36
seanrathier pushed a commit to seanrathier/kibana that referenced this pull request Dec 15, 2025
…ions (elastic#245576)

## Summary

With elastic#239634 in `main` and the
build being green, we have demonstrated the correct behavior for
_existing_ users with existing kibana privileges. This PR now updates
existing test/prebuilt roles to explicitly use these new privileges
moving forward.

## Reference
* Discussion about the benefits/logic for this PR can be found
[here](elastic#232113 (comment)).
* Accompanying `elasticsearch-controller` PR can be found
[here](elastic/elasticsearch-controller#1400).


### Checklist


- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [x] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

---------

Co-authored-by: Edgar Santos <edgar.santos@elastic.co>
dhurley14 added a commit that referenced this pull request Feb 4, 2026
## Summary

With #245576 in `main` and the
build being green, we have demonstrated the correct behavior for
_existing_ users with existing kibana privileges. This PR now updates
existing test/prebuilt roles to explicitly use these new privileges
moving forward.

## Reference
* Discussion about the benefits/logic for this PR can be found
[here](#232113 (comment)).
* Accompanying `elasticsearch-controller` PR can be found
[here](elastic/elasticsearch-controller#1509).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Detection Alerts/Rules RBAC Security Solution RBAC for rules and alerts release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants