Skip to content

updates the rulesV1 feature references to rulesV2#250929

Merged
dhurley14 merged 5 commits intoelastic:mainfrom
dhurley14:exceptions-privileges-role-updates
Feb 4, 2026
Merged

updates the rulesV1 feature references to rulesV2#250929
dhurley14 merged 5 commits intoelastic:mainfrom
dhurley14:exceptions-privileges-role-updates

Conversation

@dhurley14
Copy link
Copy Markdown
Contributor

@dhurley14 dhurley14 commented Jan 29, 2026

Summary

With #245576 in main and the build being green, we have demonstrated the correct behavior for existing users with existing kibana privileges. This PR now updates existing test/prebuilt roles to explicitly use these new privileges moving forward.

Reference

  • Discussion about the benefits/logic for this PR can be found here.
  • Accompanying elasticsearch-controller PR can be found here.

Checklist

  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@dhurley14 dhurley14 force-pushed the exceptions-privileges-role-updates branch from 19f4e4e to eebd042 Compare January 29, 2026 16:21
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #64 / "before all" hook in "{root}"

Metrics [docs]

✅ unchanged

@dhurley14 dhurley14 added backport:skip This PR does not require backporting Feature:Rule Exceptions Security Solution Detection Rule Exceptions area Team:Detection Engine Security Solution Detection Engine Area v9.4.0 labels Feb 2, 2026
@dhurley14 dhurley14 self-assigned this Feb 2, 2026
@dhurley14 dhurley14 marked this pull request as ready for review February 2, 2026 19:39
@dhurley14 dhurley14 requested review from a team as code owners February 2, 2026 19:39
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@dhurley14 dhurley14 added the release_note:skip Skip the PR/issue when compiling release notes label Feb 2, 2026
@szwarckonrad szwarckonrad requested review from gergoabraham and szwarckonrad and removed request for gergoabraham and szwarckonrad February 3, 2026 09:55
@szwarckonrad
Copy link
Copy Markdown
Contributor

DW changes LGTM!

Copy link
Copy Markdown
Contributor

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kbn/es changes LGTM

Copy link
Copy Markdown
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was concerned at first that this would cause new users with this role to lose the exceptions feature, but then I remembered that exceptions is a subfeature of Rules, and is automatically included in the RulesV2 feature 👍

Copy link
Copy Markdown
Contributor

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-engineering-productivity LGTM!

@dhurley14 dhurley14 merged commit 44a45fa into elastic:main Feb 4, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Rule Exceptions Security Solution Detection Rule Exceptions area release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants