Skip to content

[9.1] [Security Solution][Detection Engine] removes FTR "deletes the underlying migration task" test (#233995)#234430

Merged
kibanamachine merged 1 commit intoelastic:9.1from
kibanamachine:backport/9.1/pr-233995
Sep 9, 2025
Merged

[9.1] [Security Solution][Detection Engine] removes FTR "deletes the underlying migration task" test (#233995)#234430
kibanamachine merged 1 commit intoelastic:9.1from
kibanamachine:backport/9.1/pr-233995

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 9.1:

Questions ?

Please refer to the Backport tool documentation

…ying migration task" test (elastic#233995)

## Summary

- addresses elastic#179593
- removes FTR "deletes the underlying migration task" test
- test was skipped from the moment it was introduced, 5 yers ago -
https://github.com/elastic/kibana/pull/85690/files#diff-d3ab7ab5d42b0e7dfe7a3162188693eb420f0a819444aa36380148f2a450a6dbR166-R185,
so was never functional
- While looked at code of [finalize migration
util](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/migrations/finalize_migration.ts),
I did not see any indications, it actually deletes underlying migration
task
- since this API is deprecated anyway, the most reasonable approach
seems just to remove that test

(cherry picked from commit 980469a)
@kibanamachine kibanamachine merged commit cba8f00 into elastic:9.1 Sep 9, 2025
16 checks passed
vitaliidm added a commit that referenced this pull request Sep 10, 2025
… underlying migration task" test (#233995) (#234540)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Security Solution][Detection Engine] removes FTR "deletes the
underlying migration task" test
(#233995)](#233995)

<!--- Backport version: 10.0.2 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Vitalii
Dmyterko","email":"92328789+vitaliidm@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-09-09T12:03:12Z","message":"[Security
Solution][Detection Engine] removes FTR \"deletes the underlying
migration task\" test (#233995)\n\n## Summary\n\n- addresses
https://github.com/elastic/kibana/issues/179593\n- removes FTR \"deletes
the underlying migration task\" test\n- test was skipped from the moment
it was introduced, 5 yers ago
-\nhttps://github.com//pull/85690/files#diff-d3ab7ab5d42b0e7dfe7a3162188693eb420f0a819444aa36380148f2a450a6dbR166-R185,\nso
was never functional\n- While looked at code of [finalize
migration\nutil](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/migrations/finalize_migration.ts),\nI
did not see any indications, it actually deletes underlying
migration\ntask\n- since this API is deprecated anyway, the most
reasonable approach\nseems just to remove that
test","sha":"980469abd01528b8c3ad6959fe35f240d95e3584","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Detection
Engine","backport:version","v9.1.0","v8.19.0","v9.2.0","v9.1.4"],"title":"[Security
Solution][Detection Engine] removes FTR \"deletes the underlying
migration task\"
test","number":233995,"url":"https://github.com/elastic/kibana/pull/233995","mergeCommit":{"message":"[Security
Solution][Detection Engine] removes FTR \"deletes the underlying
migration task\" test (#233995)\n\n## Summary\n\n- addresses
https://github.com/elastic/kibana/issues/179593\n- removes FTR \"deletes
the underlying migration task\" test\n- test was skipped from the moment
it was introduced, 5 yers ago
-\nhttps://github.com//pull/85690/files#diff-d3ab7ab5d42b0e7dfe7a3162188693eb420f0a819444aa36380148f2a450a6dbR166-R185,\nso
was never functional\n- While looked at code of [finalize
migration\nutil](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/migrations/finalize_migration.ts),\nI
did not see any indications, it actually deletes underlying
migration\ntask\n- since this API is deprecated anyway, the most
reasonable approach\nseems just to remove that
test","sha":"980469abd01528b8c3ad6959fe35f240d95e3584"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/234430","number":234430,"state":"MERGED","mergeCommit":{"sha":"cba8f00affeae8f004c497e612636ce38eedc2c8","message":"[9.1]
[Security Solution][Detection Engine] removes FTR \"deletes the
underlying migration task\" test (#233995) (#234430)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`9.1`:\n- [[Security Solution][Detection Engine] removes FTR \"deletes
the\nunderlying migration task\"
test\n(#233995)](https://github.com/elastic/kibana/pull/233995)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Vitalii Dmyterko
<92328789+vitaliidm@users.noreply.github.com>"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/234429","number":234429,"state":"OPEN"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/233995","number":233995,"mergeCommit":{"message":"[Security
Solution][Detection Engine] removes FTR \"deletes the underlying
migration task\" test (#233995)\n\n## Summary\n\n- addresses
https://github.com/elastic/kibana/issues/179593\n- removes FTR \"deletes
the underlying migration task\" test\n- test was skipped from the moment
it was introduced, 5 yers ago
-\nhttps://github.com//pull/85690/files#diff-d3ab7ab5d42b0e7dfe7a3162188693eb420f0a819444aa36380148f2a450a6dbR166-R185,\nso
was never functional\n- While looked at code of [finalize
migration\nutil](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/migrations/finalize_migration.ts),\nI
did not see any indications, it actually deletes underlying
migration\ntask\n- since this API is deprecated anyway, the most
reasonable approach\nseems just to remove that
test","sha":"980469abd01528b8c3ad6959fe35f240d95e3584"}}]}] BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants