Skip to content

[8.19] [Security Solution][Detection Engine] removes FTR "deletes the underlying migration task" test (#233995)#234540

Merged
vitaliidm merged 2 commits intoelastic:8.19from
vitaliidm:backport/8.19/pr-233995
Sep 10, 2025
Merged

[8.19] [Security Solution][Detection Engine] removes FTR "deletes the underlying migration task" test (#233995)#234540
vitaliidm merged 2 commits intoelastic:8.19from
vitaliidm:backport/8.19/pr-233995

Conversation

@vitaliidm
Copy link
Copy Markdown
Contributor

@vitaliidm vitaliidm commented Sep 10, 2025

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

@vitaliidm
[Security Solution][Detection Engine] removes FTR "deletes the underl…
90118b9 
…ying migration task" test (elastic#233995)

## Summary

- addresses elastic#179593
- removes FTR "deletes the underlying migration task" test
- test was skipped from the moment it was introduced, 5 yers ago -
https://github.com/elastic/kibana/pull/85690/files#diff-d3ab7ab5d42b0e7dfe7a3162188693eb420f0a819444aa36380148f2a450a6dbR166-R185,
so was never functional
- While looked at code of [finalize migration
util](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/migrations/finalize_migration.ts),
I did not see any indications, it actually deletes underlying migration
task
- since this API is deprecated anyway, the most reasonable approach
seems just to remove that test

(cherry picked from commit 980469a)
@vitaliidm vitaliidm added the backport This PR is a backport of another PR label Sep 10, 2025
@vitaliidm vitaliidm enabled auto-merge (squash) September 10, 2025 08:59
@vitaliidm vitaliidm mentioned this pull request Sep 10, 2025
Merged
@vitaliidm vitaliidm merged commit 95c6cca into elastic:8.19 Sep 10, 2025
8 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 10, 2025

💚 Build Succeeded

Metrics [docs]

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/saved-objects-service.html#_mappings

id before after diff
_data_stream_timestamp 1 - -1
_doc_count 1 - -1
_ignored_source 1 - -1
_index_mode 1 - -1
_inference_fields 1 - -1
_tier 1 - -1
apm-custom-dashboards 5 - -5
apm-server-schema 2 - -2
apm-service-group 5 - -5
application_usage_daily 2 - -2
config 2 - -2
config-global 2 - -2
coreMigrationVersion 1 - -1
created_at 1 - -1
created_by 1 - -1
entity-definition 9 - -9
entity-discovery-api-key 2 - -2
event_loop_delays_daily 2 - -2
favorites 4 - -4
file 11 - -11
file-upload-usage-collection-telemetry 3 - -3
fileShare 5 - -5
guided-onboarding-guide-state 3 - -3
infra-custom-dashboards 4 - -4
infrastructure-monitoring-log-view 2 - -2
intercept_trigger_record 5 - -5
legacy-url-alias 7 - -7
managed 1 - -1
ml-job 6 - -6
ml-module 13 - -13
ml-trained-model 7 - -7
monitoring-telemetry 2 - -2
namespace 1 - -1
namespaces 1 - -1
observability-onboarding-state 2 - -2
originId 1 - -1
product-doc-install-status 7 - -7
references 4 - -4
sample-data-telemetry 3 - -3
security-ai-prompt 8 - -8
slo 11 - -11
space 5 - -5
synthetics-monitor 34 - -34
synthetics-monitor-multi-space 34 - -34
tag 4 - -4
type 1 - -1
typeMigrationVersion 1 - -1
ui-metric 2 - -2
updated_at 1 - -1
updated_by 1 - -1
upgrade-assistant-ml-upgrade-operation 3 - -3
upgrade-assistant-reindex-operation 3 - -3
uptime-synthetics-api-key 2 - -2
url 5 - -5
usage-counters 2 - -2
total -249

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denar50 denar50 denar50 approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vitaliidm @elasticmachine @denar50