Skip to content

[Workspace Chrome] Grid layout by default#228626

Closed
Dosant wants to merge 28 commits intoelastic:mainfrom
Dosant:qa-grid-layout
Closed

[Workspace Chrome] Grid layout by default#228626
Dosant wants to merge 28 commits intoelastic:mainfrom
Dosant:qa-grid-layout

Conversation

@Dosant
Copy link
Copy Markdown
Contributor

@Dosant Dosant commented Jul 18, 2025 •
edited
Loading

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 18, 2025 •
edited
Loading

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!

@Dosant Dosant added ci:cloud-deploy Create or update a Cloud deployment ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project ci:project-deploy-observability Create an Observability project ci:project-deploy-security Create a Security Serverless Project ci:project-persist-deployment Persist project deployment indefinitely labels Jul 18, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 18, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elastic elastic deleted a comment from kibanamachine Aug 7, 2025
@Dosant Dosant removed ci:cloud-deploy Create or update a Cloud deployment ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project ci:project-deploy-observability Create an Observability project ci:project-deploy-security Create a Security Serverless Project ci:project-persist-deployment Persist project deployment indefinitely labels Aug 27, 2025
@Dosant
Copy link
Copy Markdown
Contributor Author

Dosant commented Aug 27, 2025

After merging:

We significantly cut down on the failing tests (still need to launch all cypress tests)

Looking further:

[job] [logs] FTR Configs #134 / Cases - group 1 Create case creates a case from the stack management page
[job] [logs] FTR Configs #3 / serverless security UI Serverless Security Cases Create Case creates a case

These are caused by elastic/eui#8984 that I created

Dosant
Dosant commented Aug 27, 2025
View reviewed changes
x-pack/platform/plugins/shared/cases/public/components/severity/selector.tsx
onChange={onSeverityChange}
data-test-subj="case-severity-selection"
aria-label={i18n.SEVERITY_TITLE}
popoverProps={{
Copy link
Copy Markdown
Contributor Author

@Dosant Dosant Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[job] [logs] FTR Configs #134 / Cases - group 1 Create case creates a case from the stack management page
[job] [logs] FTR Configs #3 / serverless security UI Serverless Security Cases Create Case creates a case

These are caused by elastic/eui#8984 that I created

This was referenced Sep 11, 2025
Merged
Closed
rbrtj added a commit that referenced this pull request Sep 11, 2025
@rbrtj
[ML] Data Drift: Update functional tests comparison chart click coord…
b068a0d 
…inates (#234732)

Fixes the test for new grid layout
#228626
PR with CI and flaky test runner, with the new grid feature flag ON:
#234733
@Dosant Dosant mentioned this pull request Sep 12, 2025
Merged
KodeRad pushed a commit to KodeRad/kibana that referenced this pull request Sep 15, 2025
@rbrtj @KodeRad
[ML] Data Drift: Update functional tests comparison chart click coord…
f427c00 
…inates (elastic#234732)

Fixes the test for new grid layout
elastic#228626
PR with CI and flaky test runner, with the new grid feature flag ON:
elastic#234733
Dosant added a commit that referenced this pull request Sep 16, 2025
@Dosant
[FTR] Fixes for upcoming grid layout (#234874)
bc111de 
## Summary

Part of #225263
Extracted from #228626

We're working on changes for Kibana layout which is behind feature flag
in main and preparing for wider announcements and rollout. In
#228626 I was going through
functional test failures with the new layout and in this PR I am
extracting backward compatible fixes.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Sep 24, 2025
@rbrtj @CAWilson94
[ML] Data Drift: Update functional tests comparison chart click coord…
39b419c 
…inates (elastic#234732)

Fixes the test for new grid layout
elastic#228626
PR with CI and flaky test runner, with the new grid feature flag ON:
elastic#234733
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Sep 24, 2025
@Dosant @CAWilson94
[FTR] Fixes for upcoming grid layout (elastic#234874)
3ced19a 
## Summary

Part of elastic#225263
Extracted from elastic#228626

We're working on changes for Kibana layout which is behind feature flag
in main and preparing for wider announcements and rollout. In
elastic#228626 I was going through
functional test failures with the new layout and in this PR I am
extracting backward compatible fixes.
niros1 pushed a commit that referenced this pull request Sep 30, 2025
@rbrtj @niros1
[ML] Data Drift: Update functional tests comparison chart click coord…
ea3bbd7 
…inates (#234732)

Fixes the test for new grid layout
#228626
PR with CI and flaky test runner, with the new grid feature flag ON:
#234733
niros1 pushed a commit that referenced this pull request Sep 30, 2025
@Dosant @niros1
[FTR] Fixes for upcoming grid layout (#234874)
f0434f3 
## Summary

Part of #225263
Extracted from #228626

We're working on changes for Kibana layout which is behind feature flag
in main and preparing for wider announcements and rollout. In
#228626 I was going through
functional test failures with the new layout and in this PR I am
extracting backward compatible fixes.
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 20, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #6 / discover/group1 discover histogram should update correctly when switching data views and brushing the histogram
  • [job] [logs] FTR Configs #17 / discover/group1 discover histogram should update correctly when switching data views and brushing the histogram
  • [job] [logs] FTR Configs #48 / discover/group1 discover histogram should update correctly when switching data views and brushing the histogram
  • [job] [logs] FTR Configs #48 / discover/group1 discover histogram should update correctly when switching data views and brushing the histogram
  • [job] [logs] FTR Configs #17 / discover/group1 discover histogram should update correctly when switching data views and brushing the histogram
  • [job] [logs] FTR Configs #6 / discover/group1 discover histogram should update correctly when switching data views and brushing the histogram
  • [job] [logs] FTR Configs #121 / machine learning - data visualizer file based with an artificial server log displays and imports a file
  • [job] [logs] FTR Configs #121 / machine learning - data visualizer file based with an artificial server log displays and imports a file
  • [job] [logs] FTR Configs #65 / machine learning basic license - data visualizer - group 1 file based with an artificial server log displays and imports a file
  • [job] [logs] FTR Configs #65 / machine learning basic license - data visualizer - group 1 file based with an artificial server log displays and imports a file
  • [job] [logs] FTR Configs #73 / Solution navigation smoke tests observability solution sidenav & breadcrumbs renders the correct nav and navigate to links
  • [job] [logs] FTR Configs #73 / Solution navigation smoke tests observability solution sidenav & breadcrumbs renders the correct nav and navigate to links

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 1.4MB 1.4MB +37.0B
indexManagement 691.8KB 691.8KB +42.0B
total +79.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 511.0KB 511.0KB -8.0B

History

@Dosant Dosant added ci:cloud-deploy Create or update a Cloud deployment ci:cloud-persist-deployment Persist cloud deployment indefinitely labels Nov 5, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 5, 2025

Cloud deployment initiated, see credentials at: https://buildkite.com/elastic/kibana-deploy-cloud-from-pr/builds/540

@Dosant Dosant added ci:all-cypress-suites and removed ci:cloud-deploy Create or update a Cloud deployment ci:cloud-persist-deployment Persist cloud deployment indefinitely labels Nov 14, 2025
@Dosant
Copy link
Copy Markdown
Contributor Author

Dosant commented Nov 17, 2025

Close in favor of #243181

@Dosant Dosant closed this Nov 17, 2025
@Dosant Dosant added the chrome-grid Work related to Chrome refactor to grid layout label Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

chrome-grid Work related to Chrome refactor to grid layout ci:all-cypress-suites

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Dosant @elasticmachine @kibanamachine