Skip to content

Populate scope with country name, not only country codes.#3

Closed
saez0pub wants to merge 2 commits intoelastic:masterfrom
saez0pub:master
Closed

Populate scope with country name, not only country codes.#3
saez0pub wants to merge 2 commits intoelastic:masterfrom
saez0pub:master

Conversation

@saez0pub
Copy link
Copy Markdown

Some firewalls give the country name with the event. Maps use only country code.

unknown and others added 2 commits February 20, 2013 15:05
Populate scope with country name, not only country codes.
Some firewalls give the country name with the event. Maps use only country code.
@rashidkpc rashidkpc closed this Feb 20, 2013
rashidkpc pushed a commit that referenced this pull request Oct 6, 2014
Move test server to port 8001
rashidkpc pushed a commit that referenced this pull request Oct 6, 2014
Move test server to port 8001
spalger pushed a commit that referenced this pull request Nov 7, 2014
spalger referenced this pull request in spalger/kibana Dec 19, 2014
abh1nav pushed a commit to crowdriff/kibana that referenced this pull request Jan 23, 2015
lukasolson added a commit that referenced this pull request Feb 19, 2015
tweak style, add info to propularity
spalger pushed a commit that referenced this pull request Mar 3, 2016
Makes agg autocomplete rules up to date with ES 2.0

Closes #3
jbudz referenced this pull request in jbudz/kibana Jun 27, 2016
[npm] update makelogs to version supporting latest es master
@KnightOfNight KnightOfNight mentioned this pull request Jul 19, 2016
This was referenced Feb 14, 2017
kimjoar referenced this pull request in kimjoar/kibana Jul 9, 2017
upgrade deps in preperation for babel6 transition
stacey-gammon pushed a commit that referenced this pull request Sep 26, 2017
* Initial check-in to replace gridster with react-grid-layout and reactify panels

* # This is a combination of 3 commits.
# This is the 1st commit message:
Add margin of error to test determining panel widths

# This is the commit message #2:

use real kibana version when creating panel data. Will make future conversions easier.

# This is the commit message #3:

Fix lint errors

* Add margin of error to test determining panel widths

use real kibana version when creating panel data. Will make future conversions easier.

Move default height and width to dashboard_constants so those that need it don't end up including extra stuff like ui/chrome

* Remove unnecessary _.once when creating react directives in dashboard.js

* Remove unnecessary constructors

* Use componentDidMount instead of componentWillMount bc of async calls, and handle case where destroyEmbeddable is not defined.

* Remove unnecessary null in classNames

* Use loads defaultsDeep instead of Object.assign

* use render* instead of get* for functions returning an element

* use relative css paths

* Use local import path

* Switch to local imports and remove need for plugins path in jest tests

* Improve accessibility of max/min panel toggle icon

* remove unused css

Had to implement this via code

* disable eslint rule for setState in componentDidMount

Am not aware of a better way to handle this, aside from switching to
redux, since it’s recommended not to put async calls in
componentWillMount.  Since I plan to investigate redux next, disabling
for now. Open to other’s opinions on the matter.

* Use native map instead of lodash

* Have the grid handle setting the z-indexes of the right reactgriditem

* Make the draggable handle the title, not the whole heading

Otherwise the drag event often takes over click events when trying to
open the panel options menu and it gets really annoying.

* Change from click to mouse down detector in KuiOutsideClickDector so drags also close pop ups.

* Fix mistaken commit

Code from the redux PR snuck into this one.

* Run getEditPath and getTitle async calls in parallel - no need to wait on the return value of one before starting the others.

* Fix tests: update snapshots, add promise returns.

* version being added to panelData in the wrong spot caused isDirty flag to be true when it shouldn't be

* Fix unmounting/mounting problem with panels due to view/edit mode switch

* Fix bug where panels get squashed to one side when view mode is changed while a panel is expanded.

* Update snapshots to match wrong view mode comparison

* Improve naming of a variable

* Fix issue with pop over hiding behind tile maps

* Previous panel.js included ui/doc_table and ui/visualize - needed to include them in the chain for Dash only mode but not in that file.

* Fix bad merge: remove baseline screenshots
stacey-gammon pushed a commit that referenced this pull request Oct 2, 2017
* Initial check-in to replace gridster with react-grid-layout and reactify panels

* # This is a combination of 3 commits.
# This is the 1st commit message:
Add margin of error to test determining panel widths

# This is the commit message #2:

use real kibana version when creating panel data. Will make future conversions easier.

# This is the commit message #3:

Fix lint errors

* Add margin of error to test determining panel widths

use real kibana version when creating panel data. Will make future conversions easier.

Move default height and width to dashboard_constants so those that need it don't end up including extra stuff like ui/chrome

* Remove unnecessary _.once when creating react directives in dashboard.js

* Remove unnecessary constructors

* Use componentDidMount instead of componentWillMount bc of async calls, and handle case where destroyEmbeddable is not defined.

* Remove unnecessary null in classNames

* Use loads defaultsDeep instead of Object.assign

* use render* instead of get* for functions returning an element

* use relative css paths

* Use local import path

* Switch to local imports and remove need for plugins path in jest tests

* Improve accessibility of max/min panel toggle icon

* remove unused css

Had to implement this via code

* disable eslint rule for setState in componentDidMount

Am not aware of a better way to handle this, aside from switching to
redux, since it’s recommended not to put async calls in
componentWillMount.  Since I plan to investigate redux next, disabling
for now. Open to other’s opinions on the matter.

* Use native map instead of lodash

* Have the grid handle setting the z-indexes of the right reactgriditem

* Make the draggable handle the title, not the whole heading

Otherwise the drag event often takes over click events when trying to
open the panel options menu and it gets really annoying.

* Change from click to mouse down detector in KuiOutsideClickDector so drags also close pop ups.

* Fix mistaken commit

Code from the redux PR snuck into this one.

* Run getEditPath and getTitle async calls in parallel - no need to wait on the return value of one before starting the others.

* Fix tests: update snapshots, add promise returns.

* version being added to panelData in the wrong spot caused isDirty flag to be true when it shouldn't be

* Fix unmounting/mounting problem with panels due to view/edit mode switch

* Fix bug where panels get squashed to one side when view mode is changed while a panel is expanded.

* Update snapshots to match wrong view mode comparison

* Improve naming of a variable

* Fix issue with pop over hiding behind tile maps

* Previous panel.js included ui/doc_table and ui/visualize - needed to include them in the chain for Dash only mode but not in that file.

* Fix bad merge: remove baseline screenshots
timroes added a commit that referenced this pull request Jun 19, 2018
* Update to EUI 0.0.53

* Remove input vis specific styling

* remove double close button in dashboard add panel flyout (#2)

* Fix functional tests

* fix x-pack snapshots

* EUI 0.0.53 no longer closes combo box when clear btn is pressed (#3)
timroes added a commit that referenced this pull request Jun 19, 2018
* Update to EUI 0.0.53

* Remove input vis specific styling

* remove double close button in dashboard add panel flyout (#2)

* Fix functional tests

* fix x-pack snapshots

* EUI 0.0.53 no longer closes combo box when clear btn is pressed (#3)
maryia-lapata referenced this pull request in maryia-lapata/kibana Jun 25, 2018
* Update to EUI 0.0.53

* Remove input vis specific styling

* remove double close button in dashboard add panel flyout (#2)

* Fix functional tests

* fix x-pack snapshots

* EUI 0.0.53 no longer closes combo box when clear btn is pressed (#3)
kobelb added a commit that referenced this pull request Sep 12, 2018
* Splitting to a client and a wrapper, integation tests are passing
without spaces

* Adding the spaces wrapper back in the mix using a priority collection

* Restructuring the secure wrapper as we don't need to switch between
repositories

* Checking authorization at the current space

* Beginning to make the rbac api integration tests run against spaces

* Adding identical data to the rbac esArchives for two more spaces

* Adding some space tests for find

* Beginning to work on the spaces client

* Fixing find and filtering out unrequested privileges from response

* Adding get code and test

* Introducing an RBAC Auth Scope

* Exposing the spacesClient a bit better

* Moving the server.expose to the security plugin init

* Moving checkPrivilegesAtAllResources to it's own thing

* No longer using the auth scope for RBAC, dashboard mode didn't work with
it

* Securing the create space method

* Adding secure update method

* Adding secured delete endpoints

* Restructuring some code in the spaces client

* Adding tests for the select endpoint

* Spaces can't be managed via the SavedObjectsClient now

* Creating separate space_all and space_read privileges

* Splitting out the spaces and global privileges

* Fixing edit role screen after API changes

* Revising comment, there is a Set in JavaScript now, but lodash can't
equal them

* Using authorization mode to log deprecation warning on login

* Changing the signature of checkPrivileges

We're now using the legacy fallback when there are no application
privileges. This improves performance at the sake of legacy 403s being
displayed to users who have no application privileges.

* Refactoring the way we specify resources when checking privileges

* Exposing the space service more intuitively

* Fixing comments

* Security defines all actions

* Renaming `response` returned by the checkPrivileges function

* Hard-coding the kibana app privileges teporarily

* Adding Authenticator authorization mode tests

* Adding actions.manageSpaces tests

* Adding check privileges tests

* Fixing checkPrivileges test snapshots

* Making sure tests fail until I correct this deficiency

* Adding stubbed out authorization mode tests

* Fixing tests for RegisterPrivilegesWithCluster

* Fixing service AuthorizationService tests

* Addinng serializer tests

* Adding validateEsResponse tests

* We don't need the SecureSavedObjectsClient anymore!

* Adding SecureSavedObjectsClientWrapper tests...

* Fixing a few stray tests

* Fixing issue when user isn't authenticated and check useRbacForRequest

* Validating spaces we're adding to roles

* Reusing hasAnyPrivileges from hasAnyResourcePrivileges

* Better variable name

* toArray -> toPrioritizedArray

* Using Space throughout the SpacesClient

* GetActiveSpace uses the SpacesClient now

* Squashed commit of the following:

commit 23515b1
Author: kobelb <brandon.kobel@elastic.co>
Date:   Mon Sep 10 06:57:58 2018 -0400

    Adding more users to the spaces tests

commit 4bbde73
Author: kobelb <brandon.kobel@elastic.co>
Date:   Mon Sep 10 06:09:35 2018 -0400

    Adding not space aware get tests

commit 5d11bef
Author: kobelb <brandon.kobel@elastic.co>
Date:   Sat Sep 8 14:06:20 2018 -0400

    Adding not space aware test to find

commit f9383fd
Author: kobelb <brandon.kobel@elastic.co>
Date:   Sat Sep 8 13:49:04 2018 -0400

    Adding bulk create tests and testing non space aware type with bulkGet

commit 5388b5a
Author: kobelb <brandon.kobel@elastic.co>
Date:   Fri Sep 7 16:18:04 2018 -0400

    Adding bulk create test

commit 0674263
Author: kobelb <brandon.kobel@elastic.co>
Date:   Fri Sep 7 15:58:21 2018 -0400

    Ignoring some modules

commit 6b011d3
Author: kobelb <brandon.kobel@elastic.co>
Date:   Fri Sep 7 15:55:58 2018 -0400

    Making the users match for saved objects security and spaces

commit de2f994
Author: kobelb <brandon.kobel@elastic.co>
Date:   Fri Sep 7 14:18:53 2018 -0400

    Making the space suites define their own test expectations

commit 5407866
Author: kobelb <brandon.kobel@elastic.co>
Date:   Fri Sep 7 13:15:46 2018 -0400

    Removing redundant spaces folder

commit 9913923
Author: kobelb <brandon.kobel@elastic.co>
Date:   Fri Sep 7 13:14:45 2018 -0400

    Removing unneeded objects from the esarchive

commit bc602b1
Author: kobelb <brandon.kobel@elastic.co>
Date:   Fri Sep 7 13:08:12 2018 -0400

    Moving some tests around

commit 7fec308
Author: kobelb <brandon.kobel@elastic.co>
Date:   Fri Sep 7 12:38:23 2018 -0400

    Deleting rbac_api_integration tests, they've been migrated elsewhere

commit 29c018e
Author: kobelb <brandon.kobel@elastic.co>
Date:   Fri Sep 7 10:01:16 2018 -0400

    Importing SuperTest where needed

commit 38d2e74
Author: kobelb <brandon.kobel@elastic.co>
Date:   Fri Sep 7 08:44:53 2018 -0400

    Removing the "saved_objects" folder

commit 70eada4
Merge: 1b2708f 9023431
Author: Brandon Kobel <brandon.kobel@gmail.com>
Date:   Fri Sep 7 10:04:03 2018 -0400

    Merge pull request #4 from legrego/spaces-api-tests

    Initial round of spaces api testing

commit 9023431
Merge: 6410f72 1b2708f
Author: Larry Gregory <larry.gregory@elastic.co>
Date:   Fri Sep 7 09:37:57 2018 -0400

    Merge remote-tracking branch 'kobelb/spaces/securing-api-tests' into spaces-api-tests

commit 1b2708f
Author: kobelb <brandon.kobel@elastic.co>
Date:   Fri Sep 7 08:17:25 2018 -0400

    Even more typescript

commit 369a429
Author: kobelb <brandon.kobel@elastic.co>
Date:   Fri Sep 7 08:08:28 2018 -0400

    Typescriptifying Get

commit f53f2ab
Author: kobelb <brandon.kobel@elastic.co>
Date:   Fri Sep 7 08:01:48 2018 -0400

    Typescriptifying Find

commit f707e03
Author: kobelb <brandon.kobel@elastic.co>
Date:   Fri Sep 7 07:55:10 2018 -0400

    Typescriptifying Create

commit 485d983
Author: kobelb <brandon.kobel@elastic.co>
Date:   Fri Sep 7 07:31:54 2018 -0400

    Changing the namespace agnostic type name

commit 71c2122
Author: kobelb <brandon.kobel@elastic.co>
Date:   Fri Sep 7 07:25:15 2018 -0400

    Adding update tests

commit f60e953
Author: kobelb <brandon.kobel@elastic.co>
Date:   Thu Sep 6 15:53:34 2018 -0400

    Delete tests

commit 94682e5
Author: kobelb <brandon.kobel@elastic.co>
Date:   Thu Sep 6 12:07:39 2018 -0400

    Adding get security and spaces tests

commit 481943f
Author: kobelb <brandon.kobel@elastic.co>
Date:   Thu Sep 6 11:58:42 2018 -0400

    Generalizing bulk get

commit 14d9058
Merge: 6627127 fc5f7fa
Author: Brandon Kobel <brandon.kobel@gmail.com>
Date:   Thu Sep 6 10:46:07 2018 -0400

    Merge pull request #3 from legrego/remove-privs-api

    Remove privs api and hardcoded privs list

commit 6410f72
Author: Larry Gregory <larry.gregory@elastic.co>
Date:   Thu Sep 6 09:35:30 2018 -0400

    add missing superagent type

commit 4afacc0
Author: Larry Gregory <larry.gregory@elastic.co>
Date:   Wed Sep 5 20:19:15 2018 -0400

    initial round of spaces api testing

commit 6627127
Author: kobelb <brandon.kobel@elastic.co>
Date:   Wed Sep 5 17:29:37 2018 -0400

    Adding GET test suite

commit 68a5537
Author: kobelb <brandon.kobel@elastic.co>
Date:   Wed Sep 5 13:32:49 2018 -0400

    Copying find to security and spaces

commit fc5f7fa
Author: Larry Gregory <larry.gregory@elastic.co>
Date:   Wed Sep 5 12:36:30 2018 -0400

    move es privilege tests to api_integration

commit 189fbe6
Author: kobelb <brandon.kobel@elastic.co>
Date:   Wed Sep 5 12:24:41 2018 -0400

    Switching approach to dynamically enabling security

commit c72200f
Author: Larry Gregory <larry.gregory@elastic.co>
Date:   Wed Sep 5 11:57:26 2018 -0400

    remove get privileges api

commit 1607f80
Author: kobelb <brandon.kobel@elastic.co>
Date:   Wed Sep 5 11:47:19 2018 -0400

    Dynamically supplying users so we reduce some duplication

commit 9deec1b
Author: kobelb <brandon.kobel@elastic.co>
Date:   Wed Sep 5 09:32:36 2018 -0400

    Security and Spaces create tests

commit a8232dd
Author: kobelb <brandon.kobel@elastic.co>
Date:   Wed Sep 5 07:22:10 2018 -0400

    Using a create "test suite"

commit f07f668
Author: kobelb <brandon.kobel@elastic.co>
Date:   Wed Sep 5 05:54:46 2018 -0400

    Using the spaces esArchive always now

commit b2021ad
Merge: d3babea 7b4575b
Author: kobelb <brandon.kobel@elastic.co>
Date:   Wed Sep 5 05:43:48 2018 -0400

    Merge branch 'spaces/securing' into spaces/securing-api-tests

commit d3babea
Author: kobelb <brandon.kobel@elastic.co>
Date:   Tue Sep 4 17:43:38 2018 -0400

    Moving over the spaces only saved objects tests

commit 94054a2
Author: kobelb <brandon.kobel@elastic.co>
Date:   Tue Sep 4 17:26:43 2018 -0400

    Copying over the security only saved object api tests

* update public api to use SpacesClient

* fix

* test and api fixes

* fix tests

* Disallowing use of Spaces with the SpacesSavedObjectsClientWrapper

* Adding spaces audit logging

* Updating snapshots

* Adding get and getAll tests for the spaces client

* Adding update tests

* Adding create tests

* Adding SpacesClient delete tests

* Fixing authenticate tests

* Making tests more consistent

* Fixing kibana privileges tests

* Fixing a few type issues

* Making typescript ignore the .only test suites

* Switching to beforeEach and afterEach and removing the mocha types

* Switching to our own expect.js definitions

The definitions in @types/expect have expect being globally defined
which conflicts with the jest definitions, and expect isn't globally
defined in the mocha tests and we must use the module value

* Fixing more linting rules

* Removing test stubs and replacing with TODOs. Updating snapshots

* No longer shadowing application for the put role API

* Relying on the errors thrown by the SpacedClient when determining active
space

* Back to after/before... mocha doesn't have beforeAll/afterAll

* We got them types, thanks Spencer!!!

* Ignoring space type from the secure saved objects client find with no
type
njd5475 pushed a commit to njd5475/kibana that referenced this pull request Oct 18, 2018
…eturn-taskdoc-to-caller

add default client module, more wrapper methods
talboren pushed a commit to talboren/kibana that referenced this pull request Jul 13, 2025
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants