[Upgrade Assistant] Fix uniq keys bug in ES deprecations table#227416
Merged
sabarasaba merged 4 commits intoelastic:mainfrom Jul 14, 2025
Merged
[Upgrade Assistant] Fix uniq keys bug in ES deprecations table#227416sabarasaba merged 4 commits intoelastic:mainfrom
sabarasaba merged 4 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
damian-polewski
approved these changes
Jul 14, 2025
Contributor
damian-polewski
left a comment
There was a problem hiding this comment.
Tested locally and everything works as expected, LGTM!
Member
Author
|
@elasticmachine merge upstream |
Contributor
|
Starting backport for target branches: 8.18, 8.19 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @sabarasaba |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 14, 2025
…ic#227416) (cherry picked from commit 769404b)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
sabarasaba
added a commit
to sabarasaba/kibana
that referenced
this pull request
Jul 14, 2025
…ic#227416) (cherry picked from commit 769404b) # Conflicts: # x-pack/platform/plugins/private/upgrade_assistant/public/application/components/es_deprecations/es_deprecations_table.tsx
kibanamachine
added a commit
that referenced
this pull request
Jul 14, 2025
…#227416) (#227802) # Backport This will backport the following commits from `main` to `8.19`: - [[Upgrade Assistant] Fix uniq keys bug in ES deprecations table (#227416)](#227416) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ignacio Rivas","email":"rivasign@gmail.com"},"sourceCommit":{"committedDate":"2025-07-14T11:37:22Z","message":"[Upgrade Assistant] Fix uniq keys bug in ES deprecations table (#227416)","sha":"769404bd4ac35f1d38b6b2bf8dc0f56a43cb4533","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","Feature:Upgrade Assistant","backport:version","v8.19.0","v9.2.0","v8.18.4"],"title":"[Upgrade Assistant] Fix uniq keys bug in ES deprecations table","number":227416,"url":"https://github.com/elastic/kibana/pull/227416","mergeCommit":{"message":"[Upgrade Assistant] Fix uniq keys bug in ES deprecations table (#227416)","sha":"769404bd4ac35f1d38b6b2bf8dc0f56a43cb4533"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","8.18"],"targetPullRequestStates":[{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227416","number":227416,"mergeCommit":{"message":"[Upgrade Assistant] Fix uniq keys bug in ES deprecations table (#227416)","sha":"769404bd4ac35f1d38b6b2bf8dc0f56a43cb4533"}},{"branch":"8.18","label":"v8.18.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ignacio Rivas <rivasign@gmail.com>
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
sabarasaba
added a commit
that referenced
this pull request
Jul 16, 2025
…#227416) (#227806) # Backport This will backport the following commits from `main` to `8.18`: - [[Upgrade Assistant] Fix uniq keys bug in ES deprecations table (#227416)](#227416) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Ignacio Rivas","email":"rivasign@gmail.com"},"sourceCommit":{"committedDate":"2025-07-14T11:37:22Z","message":"[Upgrade Assistant] Fix uniq keys bug in ES deprecations table (#227416)","sha":"769404bd4ac35f1d38b6b2bf8dc0f56a43cb4533","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","Feature:Upgrade Assistant","backport:version","v8.19.0","v9.2.0","v8.18.4"],"title":"[Upgrade Assistant] Fix uniq keys bug in ES deprecations table","number":227416,"url":"https://github.com/elastic/kibana/pull/227416","mergeCommit":{"message":"[Upgrade Assistant] Fix uniq keys bug in ES deprecations table (#227416)","sha":"769404bd4ac35f1d38b6b2bf8dc0f56a43cb4533"}},"sourceBranch":"main","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/227802","number":227802,"state":"OPEN"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/227416","number":227416,"mergeCommit":{"message":"[Upgrade Assistant] Fix uniq keys bug in ES deprecations table (#227416)","sha":"769404bd4ac35f1d38b6b2bf8dc0f56a43cb4533"}},{"branch":"8.18","label":"v8.18.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Bluefinger
pushed a commit
to Bluefinger/kibana
that referenced
this pull request
Jul 22, 2025
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #227291
Summary
The issue was that the row keys are being generated using the visible array index (0-based for each page), resulting in duplicate keys like deprecation-row-0 appearing on every page. This caused React to incorrectly reuse component instances when navigating between pages.
The fix calculates an absolute index by adding the pager's
firstItemIndexto the current row index, ensuring unique keys across all pages (e.g., page 1 has keys 0-49, page 2 has keys 50-99). This prevents React from confusing components between pages and ensures that actions like reindexing only affect the correct deprecation item.