Skip to content

chore(streams): disable sig events on logs essentials#226853

Merged
kdelemme merged 9 commits intoelastic:mainfrom
kdelemme:disable-sig-events-log-essentials
Jul 8, 2025
Merged

chore(streams): disable sig events on logs essentials#226853
kdelemme merged 9 commits intoelastic:mainfrom
kdelemme:disable-sig-events-log-essentials

Conversation

@kdelemme
Copy link
Copy Markdown
Contributor

@kdelemme kdelemme commented Jul 7, 2025

Summary

Resolves #225632

This PR conditionally registers the streams significant events UI settings based on the current tier (disabled for log essentials)
It also extracts both streams UI settings registration into a common function, and conditionally registers the settings in the allow list based on the tier.

Testing

  • Run Kibana/ES with serverless logs essentials
yarn es serverless --projectType oblt --serverless.observability.tier=logs_essentials -E xpack.ml.enabled=false
yarn serverless-oblt --pricing.tiers.products='[{"name":"observability","tier":"logs_essentials"}]'\
  • Assert advanced setting for Streams Significant Events is not displayed
  • Enable streams: POST kbn:/api/streams/_enable
  • Add a doc:
POST logs/_doc
{
    "@timestamp": "2025-07-07T10:00:10.000Z",
    "message": "test 2",
}
  • Go to Streams UI, Assert Significant Events tab is not displayed
  • Assert going to the hidden tab URL redirects to another tab: http://localhost:5601/app/streams/logs/management/significantEvents

@github-actions github-actions bot added the author:obs-ux-management PRs authored by the obs ux management team label Jul 7, 2025
@kdelemme kdelemme marked this pull request as ready for review July 7, 2025 16:03
@kdelemme kdelemme requested review from a team as code owners July 7, 2025 16:03
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jul 7, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 7, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. backport:version Backport to applied version labels v9.2.0 labels Jul 7, 2025
@kdelemme kdelemme self-assigned this Jul 7, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 7, 2025

💚 Build Succeeded

  • Buildkite Build
  • Commit: ddd3529
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-226853-ddd3529a1415

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/serverless-observability-settings 2 3 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 578.2KB 578.4KB +130.0B
Unknown metric groups

API count

id before after diff
@kbn/serverless-observability-settings 2 3 +1

History

cc @kdelemme

Copy link
Copy Markdown
Contributor

@tonyghiani tonyghiani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks for this quick update!

@tonyghiani tonyghiani changed the title chore(streams): diasble sig events on logs essentials chore(streams): disable sig events on logs essentials Jul 8, 2025
@kdelemme kdelemme merged commit 18352a4 into elastic:main Jul 8, 2025
12 checks passed
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 10, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 226853 locally
cc: @kdelemme

6 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 226853 locally
cc: @kdelemme

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 226853 locally
cc: @kdelemme

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 226853 locally
cc: @kdelemme

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 226853 locally
cc: @kdelemme

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 226853 locally
cc: @kdelemme

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 226853 locally
cc: @kdelemme

@kdelemme kdelemme added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels labels Jul 21, 2025
kertal pushed a commit to kertal/kibana that referenced this pull request Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author:obs-ux-management PRs authored by the obs ux management team backport:skip This PR does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Logs Essentials] Remove Significant Events view and settings

5 participants