[8.19] Remapping iInCircle and questionInCircle and deprecating help icon (#223142)#225535
Merged
tsullivan merged 6 commits intoelastic:8.19from Jul 1, 2025
Merged
Conversation
…con (elastic#223142) ## Summary This PR closes the issue elastic#221380 and does 3 things: 1. Replaces all current usages of `iInCircle` with `info` (no visual changes) 2. Replaces all current usages of `questionInCircle` with `question`(no visual changes) 3. Replaces all current `help` icon usages with `question`(lifesaver icon replaced with question) ## Screenshots:    --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Anton Dosov <anton.dosov@elastic.co> (cherry picked from commit 0d21254) # Conflicts: # src/platform/packages/shared/content-management/content_editor/src/components/metadata_form.tsx # src/platform/packages/shared/shared-ux/chrome/navigation/src/ui/navigation.stories.tsx # src/platform/plugins/shared/inspector/public/views/requests/components/details/req_details_stats.tsx # src/platform/plugins/shared/saved_objects/public/save_modal/saved_object_save_modal.tsx # x-pack/platform/plugins/private/monitoring/public/components/chart/monitoring_timeseries_container.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/connector_detail/components/advanced_config_override_callout.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/connector_detail/components/example_config_callout.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/connector_detail/components/waiting_for_connector_step.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/connector_detail/overview.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/connectors/create_connector/components/connector_description_popover.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/search_index/connector/native_connector_configuration/native_connector_configuration_config.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/search_index/connector/native_connector_configuration/research_configuration.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/search_index/connector/sync_rules/connector_rules.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/search_index/documents.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/search_index/index_mappings.tsx # x-pack/platform/plugins/shared/content_connectors/public/components/shared/flash_messages/constants.ts # x-pack/platform/plugins/shared/content_connectors/public/components/shared/flash_messages/flash_messages.test.tsx # x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agents/agent_details_page/components/agent_details/agent_details_overview.tsx # x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_list_table.tsx # x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/settings/components/edit_output_flyout/output_form_remote_es.tsx # x-pack/platform/plugins/shared/fleet/public/applications/fleet/sections/settings/components/outputs_table/integration_status_badge.tsx # x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/installed_integrations/components/confirm_bulk_uninstall_modal.tsx # x-pack/platform/plugins/shared/fleet/public/applications/integrations/sections/epm/screens/installed_integrations/components/confirm_bulk_upgrade_modal.tsx # x-pack/platform/plugins/shared/ml/public/application/model_management/test_models/models/ner/ner_output.test.tsx # x-pack/platform/plugins/shared/ml/public/application/model_management/test_models/models/ner/ner_output.tsx # x-pack/solutions/chat/plugins/workchat-app/public/application/components/assistant/details/assistant_view.tsx # x-pack/solutions/chat/plugins/workchat-app/public/application/components/assistant/list/assistant_list_view.tsx # x-pack/solutions/chat/plugins/workchat-app/public/application/components/integrations/listing/integration_catalog_view.tsx # x-pack/solutions/observability/plugins/exploratory_view/public/components/shared/exploratory_view/header/last_updated.tsx # x-pack/solutions/observability/plugins/infra/public/pages/metrics/hosts/components/common/popover.tsx # x-pack/solutions/observability/plugins/infra/public/pages/metrics/hosts/components/search_bar/limit_options.tsx # x-pack/solutions/search/plugins/enterprise_search/public/applications/enterprise_search_content/components/connector_detail/overview.tsx # x-pack/solutions/search/plugins/serverless_search/public/application/components/connectors/connector_config/connector_link.tsx # x-pack/solutions/security/plugins/cloud_security_posture/public/pages/configurations/findings_flyout/findings_right/content.tsx # x-pack/solutions/security/plugins/security_solution/public/detection_engine/rule_exceptions/components/value_with_space_warning/__tests__/__snapshots__/value_with_space_warning.test.tsx.snap
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Contributor
💛 Build succeeded, but was flaky
Failed CI Steps
Metrics [docs]Async chunks
Page load bundle
History
|
kowalczyk-krzysztof
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:iInCircleandquestionInCircleand deprecatinghelpicon (#223142)Questions ?
Please refer to the Backport tool documentation